Tue, 11 Nov 2014 11:05:41 +0100
8056071: compiler/whitebox/IsMethodCompilableTest.java fails with 'method() is not compilable after 3 iterations'
Summary: Always use MDO if valid and always compile trivial methods with C1 if available.
Reviewed-by: kvn, iveresov
duke@435 | 1 | /* |
drchase@6680 | 2 | * Copyright (c) 1997, 2014, Oracle and/or its affiliates. All rights reserved. |
duke@435 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
duke@435 | 4 | * |
duke@435 | 5 | * This code is free software; you can redistribute it and/or modify it |
duke@435 | 6 | * under the terms of the GNU General Public License version 2 only, as |
duke@435 | 7 | * published by the Free Software Foundation. |
duke@435 | 8 | * |
duke@435 | 9 | * This code is distributed in the hope that it will be useful, but WITHOUT |
duke@435 | 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
duke@435 | 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
duke@435 | 12 | * version 2 for more details (a copy is included in the LICENSE file that |
duke@435 | 13 | * accompanied this code). |
duke@435 | 14 | * |
duke@435 | 15 | * You should have received a copy of the GNU General Public License version |
duke@435 | 16 | * 2 along with this work; if not, write to the Free Software Foundation, |
duke@435 | 17 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
duke@435 | 18 | * |
trims@1907 | 19 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
trims@1907 | 20 | * or visit www.oracle.com if you need additional information or have any |
trims@1907 | 21 | * questions. |
duke@435 | 22 | * |
duke@435 | 23 | */ |
duke@435 | 24 | |
stefank@2314 | 25 | #include "precompiled.hpp" |
stefank@2314 | 26 | #include "classfile/symbolTable.hpp" |
stefank@2314 | 27 | #include "classfile/systemDictionary.hpp" |
stefank@2314 | 28 | #include "memory/oopFactory.hpp" |
stefank@2314 | 29 | #include "oops/instanceKlass.hpp" |
stefank@2314 | 30 | #include "oops/oop.inline.hpp" |
coleenp@2497 | 31 | #include "oops/symbol.hpp" |
stefank@2314 | 32 | #include "oops/typeArrayKlass.hpp" |
stefank@2314 | 33 | #include "runtime/signature.hpp" |
duke@435 | 34 | |
drchase@6680 | 35 | PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC |
duke@435 | 36 | |
duke@435 | 37 | // Implementation of SignatureIterator |
duke@435 | 38 | |
duke@435 | 39 | // Signature syntax: |
duke@435 | 40 | // |
duke@435 | 41 | // Signature = "(" {Parameter} ")" ReturnType. |
duke@435 | 42 | // Parameter = FieldType. |
duke@435 | 43 | // ReturnType = FieldType | "V". |
duke@435 | 44 | // FieldType = "B" | "C" | "D" | "F" | "I" | "J" | "S" | "Z" | "L" ClassName ";" | "[" FieldType. |
duke@435 | 45 | // ClassName = string. |
duke@435 | 46 | |
duke@435 | 47 | |
coleenp@2497 | 48 | SignatureIterator::SignatureIterator(Symbol* signature) { |
duke@435 | 49 | _signature = signature; |
duke@435 | 50 | _parameter_index = 0; |
duke@435 | 51 | } |
duke@435 | 52 | |
duke@435 | 53 | void SignatureIterator::expect(char c) { |
jcoomes@1845 | 54 | if (_signature->byte_at(_index) != c) fatal(err_msg("expecting %c", c)); |
duke@435 | 55 | _index++; |
duke@435 | 56 | } |
duke@435 | 57 | |
duke@435 | 58 | |
duke@435 | 59 | void SignatureIterator::skip_optional_size() { |
coleenp@2497 | 60 | Symbol* sig = _signature; |
duke@435 | 61 | char c = sig->byte_at(_index); |
duke@435 | 62 | while ('0' <= c && c <= '9') c = sig->byte_at(++_index); |
duke@435 | 63 | } |
duke@435 | 64 | |
duke@435 | 65 | |
duke@435 | 66 | int SignatureIterator::parse_type() { |
duke@435 | 67 | // Note: This function could be simplified by using "return T_XXX_size;" |
duke@435 | 68 | // instead of the assignment and the break statements. However, it |
duke@435 | 69 | // seems that the product build for win32_i486 with MS VC++ 6.0 doesn't |
duke@435 | 70 | // work (stack underflow for some tests) - this seems to be a VC++ 6.0 |
duke@435 | 71 | // compiler bug (was problem - gri 4/27/2000). |
duke@435 | 72 | int size = -1; |
duke@435 | 73 | switch(_signature->byte_at(_index)) { |
duke@435 | 74 | case 'B': do_byte (); if (_parameter_index < 0 ) _return_type = T_BYTE; |
duke@435 | 75 | _index++; size = T_BYTE_size ; break; |
duke@435 | 76 | case 'C': do_char (); if (_parameter_index < 0 ) _return_type = T_CHAR; |
duke@435 | 77 | _index++; size = T_CHAR_size ; break; |
duke@435 | 78 | case 'D': do_double(); if (_parameter_index < 0 ) _return_type = T_DOUBLE; |
duke@435 | 79 | _index++; size = T_DOUBLE_size ; break; |
duke@435 | 80 | case 'F': do_float (); if (_parameter_index < 0 ) _return_type = T_FLOAT; |
duke@435 | 81 | _index++; size = T_FLOAT_size ; break; |
duke@435 | 82 | case 'I': do_int (); if (_parameter_index < 0 ) _return_type = T_INT; |
duke@435 | 83 | _index++; size = T_INT_size ; break; |
duke@435 | 84 | case 'J': do_long (); if (_parameter_index < 0 ) _return_type = T_LONG; |
duke@435 | 85 | _index++; size = T_LONG_size ; break; |
duke@435 | 86 | case 'S': do_short (); if (_parameter_index < 0 ) _return_type = T_SHORT; |
duke@435 | 87 | _index++; size = T_SHORT_size ; break; |
duke@435 | 88 | case 'Z': do_bool (); if (_parameter_index < 0 ) _return_type = T_BOOLEAN; |
duke@435 | 89 | _index++; size = T_BOOLEAN_size; break; |
duke@435 | 90 | case 'V': do_void (); if (_parameter_index < 0 ) _return_type = T_VOID; |
duke@435 | 91 | _index++; size = T_VOID_size; ; break; |
duke@435 | 92 | case 'L': |
duke@435 | 93 | { int begin = ++_index; |
coleenp@2497 | 94 | Symbol* sig = _signature; |
duke@435 | 95 | while (sig->byte_at(_index++) != ';') ; |
duke@435 | 96 | do_object(begin, _index); |
duke@435 | 97 | } |
duke@435 | 98 | if (_parameter_index < 0 ) _return_type = T_OBJECT; |
duke@435 | 99 | size = T_OBJECT_size; |
duke@435 | 100 | break; |
duke@435 | 101 | case '[': |
duke@435 | 102 | { int begin = ++_index; |
duke@435 | 103 | skip_optional_size(); |
coleenp@2497 | 104 | Symbol* sig = _signature; |
duke@435 | 105 | while (sig->byte_at(_index) == '[') { |
duke@435 | 106 | _index++; |
duke@435 | 107 | skip_optional_size(); |
duke@435 | 108 | } |
duke@435 | 109 | if (sig->byte_at(_index) == 'L') { |
duke@435 | 110 | while (sig->byte_at(_index++) != ';') ; |
duke@435 | 111 | } else { |
duke@435 | 112 | _index++; |
duke@435 | 113 | } |
duke@435 | 114 | do_array(begin, _index); |
duke@435 | 115 | if (_parameter_index < 0 ) _return_type = T_ARRAY; |
duke@435 | 116 | } |
duke@435 | 117 | size = T_ARRAY_size; |
duke@435 | 118 | break; |
duke@435 | 119 | default: |
duke@435 | 120 | ShouldNotReachHere(); |
duke@435 | 121 | break; |
duke@435 | 122 | } |
duke@435 | 123 | assert(size >= 0, "size must be set"); |
duke@435 | 124 | return size; |
duke@435 | 125 | } |
duke@435 | 126 | |
duke@435 | 127 | |
duke@435 | 128 | void SignatureIterator::check_signature_end() { |
duke@435 | 129 | if (_index < _signature->utf8_length()) { |
duke@435 | 130 | tty->print_cr("too many chars in signature"); |
duke@435 | 131 | _signature->print_value_on(tty); |
duke@435 | 132 | tty->print_cr(" @ %d", _index); |
duke@435 | 133 | } |
duke@435 | 134 | } |
duke@435 | 135 | |
duke@435 | 136 | |
duke@435 | 137 | void SignatureIterator::dispatch_field() { |
duke@435 | 138 | // no '(', just one (field) type |
duke@435 | 139 | _index = 0; |
duke@435 | 140 | _parameter_index = 0; |
duke@435 | 141 | parse_type(); |
duke@435 | 142 | check_signature_end(); |
duke@435 | 143 | } |
duke@435 | 144 | |
duke@435 | 145 | |
duke@435 | 146 | void SignatureIterator::iterate_parameters() { |
duke@435 | 147 | // Parse parameters |
duke@435 | 148 | _index = 0; |
duke@435 | 149 | _parameter_index = 0; |
duke@435 | 150 | expect('('); |
duke@435 | 151 | while (_signature->byte_at(_index) != ')') _parameter_index += parse_type(); |
duke@435 | 152 | expect(')'); |
duke@435 | 153 | _parameter_index = 0; |
duke@435 | 154 | } |
duke@435 | 155 | |
duke@435 | 156 | // Optimized version of iterat_parameters when fingerprint is known |
duke@435 | 157 | void SignatureIterator::iterate_parameters( uint64_t fingerprint ) { |
duke@435 | 158 | uint64_t saved_fingerprint = fingerprint; |
duke@435 | 159 | |
duke@435 | 160 | // Check for too many arguments |
duke@435 | 161 | if ( fingerprint == UCONST64(-1) ) { |
duke@435 | 162 | SignatureIterator::iterate_parameters(); |
duke@435 | 163 | return; |
duke@435 | 164 | } |
duke@435 | 165 | |
duke@435 | 166 | assert(fingerprint, "Fingerprint should not be 0"); |
duke@435 | 167 | |
duke@435 | 168 | _parameter_index = 0; |
duke@435 | 169 | fingerprint = fingerprint >> (static_feature_size + result_feature_size); |
duke@435 | 170 | while ( 1 ) { |
duke@435 | 171 | switch ( fingerprint & parameter_feature_mask ) { |
duke@435 | 172 | case bool_parm: |
duke@435 | 173 | do_bool(); |
duke@435 | 174 | _parameter_index += T_BOOLEAN_size; |
duke@435 | 175 | break; |
duke@435 | 176 | case byte_parm: |
duke@435 | 177 | do_byte(); |
duke@435 | 178 | _parameter_index += T_BYTE_size; |
duke@435 | 179 | break; |
duke@435 | 180 | case char_parm: |
duke@435 | 181 | do_char(); |
duke@435 | 182 | _parameter_index += T_CHAR_size; |
duke@435 | 183 | break; |
duke@435 | 184 | case short_parm: |
duke@435 | 185 | do_short(); |
duke@435 | 186 | _parameter_index += T_SHORT_size; |
duke@435 | 187 | break; |
duke@435 | 188 | case int_parm: |
duke@435 | 189 | do_int(); |
duke@435 | 190 | _parameter_index += T_INT_size; |
duke@435 | 191 | break; |
duke@435 | 192 | case obj_parm: |
duke@435 | 193 | do_object(0, 0); |
duke@435 | 194 | _parameter_index += T_OBJECT_size; |
duke@435 | 195 | break; |
duke@435 | 196 | case long_parm: |
duke@435 | 197 | do_long(); |
duke@435 | 198 | _parameter_index += T_LONG_size; |
duke@435 | 199 | break; |
duke@435 | 200 | case float_parm: |
duke@435 | 201 | do_float(); |
duke@435 | 202 | _parameter_index += T_FLOAT_size; |
duke@435 | 203 | break; |
duke@435 | 204 | case double_parm: |
duke@435 | 205 | do_double(); |
duke@435 | 206 | _parameter_index += T_DOUBLE_size; |
duke@435 | 207 | break; |
duke@435 | 208 | case done_parm: |
duke@435 | 209 | return; |
duke@435 | 210 | break; |
duke@435 | 211 | default: |
duke@435 | 212 | tty->print_cr("*** parameter is %d", fingerprint & parameter_feature_mask); |
duke@435 | 213 | tty->print_cr("*** fingerprint is " PTR64_FORMAT, saved_fingerprint); |
duke@435 | 214 | ShouldNotReachHere(); |
duke@435 | 215 | break; |
duke@435 | 216 | } |
duke@435 | 217 | fingerprint >>= parameter_feature_size; |
duke@435 | 218 | } |
duke@435 | 219 | _parameter_index = 0; |
duke@435 | 220 | } |
duke@435 | 221 | |
duke@435 | 222 | |
duke@435 | 223 | void SignatureIterator::iterate_returntype() { |
duke@435 | 224 | // Ignore parameters |
duke@435 | 225 | _index = 0; |
duke@435 | 226 | expect('('); |
coleenp@2497 | 227 | Symbol* sig = _signature; |
duke@435 | 228 | while (sig->byte_at(_index) != ')') _index++; |
duke@435 | 229 | expect(')'); |
duke@435 | 230 | // Parse return type |
duke@435 | 231 | _parameter_index = -1; |
duke@435 | 232 | parse_type(); |
duke@435 | 233 | check_signature_end(); |
duke@435 | 234 | _parameter_index = 0; |
duke@435 | 235 | } |
duke@435 | 236 | |
duke@435 | 237 | |
duke@435 | 238 | void SignatureIterator::iterate() { |
duke@435 | 239 | // Parse parameters |
duke@435 | 240 | _parameter_index = 0; |
duke@435 | 241 | _index = 0; |
duke@435 | 242 | expect('('); |
duke@435 | 243 | while (_signature->byte_at(_index) != ')') _parameter_index += parse_type(); |
duke@435 | 244 | expect(')'); |
duke@435 | 245 | // Parse return type |
duke@435 | 246 | _parameter_index = -1; |
duke@435 | 247 | parse_type(); |
duke@435 | 248 | check_signature_end(); |
duke@435 | 249 | _parameter_index = 0; |
duke@435 | 250 | } |
duke@435 | 251 | |
duke@435 | 252 | |
duke@435 | 253 | // Implementation of SignatureStream |
coleenp@2497 | 254 | SignatureStream::SignatureStream(Symbol* signature, bool is_method) : |
coleenp@2497 | 255 | _signature(signature), _at_return_type(false) { |
coleenp@2497 | 256 | _begin = _end = (is_method ? 1 : 0); // skip first '(' in method signatures |
coleenp@2497 | 257 | _names = new GrowableArray<Symbol*>(10); |
coleenp@2497 | 258 | next(); |
coleenp@2497 | 259 | } |
coleenp@2497 | 260 | |
coleenp@2497 | 261 | SignatureStream::~SignatureStream() { |
coleenp@2497 | 262 | // decrement refcount for names created during signature parsing |
coleenp@2497 | 263 | for (int i = 0; i < _names->length(); i++) { |
coleenp@2497 | 264 | _names->at(i)->decrement_refcount(); |
coleenp@2497 | 265 | } |
coleenp@2497 | 266 | } |
duke@435 | 267 | |
duke@435 | 268 | bool SignatureStream::is_done() const { |
coleenp@2497 | 269 | return _end > _signature->utf8_length(); |
duke@435 | 270 | } |
duke@435 | 271 | |
duke@435 | 272 | |
duke@435 | 273 | void SignatureStream::next_non_primitive(int t) { |
duke@435 | 274 | switch (t) { |
duke@435 | 275 | case 'L': { |
duke@435 | 276 | _type = T_OBJECT; |
coleenp@2497 | 277 | Symbol* sig = _signature; |
duke@435 | 278 | while (sig->byte_at(_end++) != ';'); |
duke@435 | 279 | break; |
duke@435 | 280 | } |
duke@435 | 281 | case '[': { |
duke@435 | 282 | _type = T_ARRAY; |
coleenp@2497 | 283 | Symbol* sig = _signature; |
duke@435 | 284 | char c = sig->byte_at(_end); |
duke@435 | 285 | while ('0' <= c && c <= '9') c = sig->byte_at(_end++); |
duke@435 | 286 | while (sig->byte_at(_end) == '[') { |
duke@435 | 287 | _end++; |
duke@435 | 288 | c = sig->byte_at(_end); |
duke@435 | 289 | while ('0' <= c && c <= '9') c = sig->byte_at(_end++); |
duke@435 | 290 | } |
duke@435 | 291 | switch(sig->byte_at(_end)) { |
duke@435 | 292 | case 'B': |
duke@435 | 293 | case 'C': |
duke@435 | 294 | case 'D': |
duke@435 | 295 | case 'F': |
duke@435 | 296 | case 'I': |
duke@435 | 297 | case 'J': |
duke@435 | 298 | case 'S': |
duke@435 | 299 | case 'Z':_end++; break; |
duke@435 | 300 | default: { |
duke@435 | 301 | while (sig->byte_at(_end++) != ';'); |
duke@435 | 302 | break; |
duke@435 | 303 | } |
duke@435 | 304 | } |
duke@435 | 305 | break; |
duke@435 | 306 | } |
duke@435 | 307 | case ')': _end++; next(); _at_return_type = true; break; |
duke@435 | 308 | default : ShouldNotReachHere(); |
duke@435 | 309 | } |
duke@435 | 310 | } |
duke@435 | 311 | |
duke@435 | 312 | |
duke@435 | 313 | bool SignatureStream::is_object() const { |
duke@435 | 314 | return _type == T_OBJECT |
duke@435 | 315 | || _type == T_ARRAY; |
duke@435 | 316 | } |
duke@435 | 317 | |
duke@435 | 318 | bool SignatureStream::is_array() const { |
duke@435 | 319 | return _type == T_ARRAY; |
duke@435 | 320 | } |
duke@435 | 321 | |
coleenp@2497 | 322 | Symbol* SignatureStream::as_symbol(TRAPS) { |
duke@435 | 323 | // Create a symbol from for string _begin _end |
duke@435 | 324 | int begin = _begin; |
duke@435 | 325 | int end = _end; |
duke@435 | 326 | |
coleenp@2497 | 327 | if ( _signature->byte_at(_begin) == 'L' |
coleenp@2497 | 328 | && _signature->byte_at(_end-1) == ';') { |
duke@435 | 329 | begin++; |
duke@435 | 330 | end--; |
duke@435 | 331 | } |
duke@435 | 332 | |
coleenp@2497 | 333 | // Save names for cleaning up reference count at the end of |
coleenp@2497 | 334 | // SignatureStream scope. |
coleenp@2497 | 335 | Symbol* name = SymbolTable::new_symbol(_signature, begin, end, CHECK_NULL); |
coleenp@2497 | 336 | _names->push(name); // save new symbol for decrementing later |
coleenp@2497 | 337 | return name; |
duke@435 | 338 | } |
duke@435 | 339 | |
coleenp@4037 | 340 | Klass* SignatureStream::as_klass(Handle class_loader, Handle protection_domain, |
jrose@1863 | 341 | FailureMode failure_mode, TRAPS) { |
jrose@1863 | 342 | if (!is_object()) return NULL; |
coleenp@2497 | 343 | Symbol* name = as_symbol(CHECK_NULL); |
jrose@1863 | 344 | if (failure_mode == ReturnNull) { |
jrose@1863 | 345 | return SystemDictionary::resolve_or_null(name, class_loader, protection_domain, THREAD); |
jrose@1863 | 346 | } else { |
jrose@1863 | 347 | bool throw_error = (failure_mode == NCDFError); |
jrose@1863 | 348 | return SystemDictionary::resolve_or_fail(name, class_loader, protection_domain, throw_error, THREAD); |
jrose@1863 | 349 | } |
jrose@1863 | 350 | } |
jrose@1863 | 351 | |
jrose@1863 | 352 | oop SignatureStream::as_java_mirror(Handle class_loader, Handle protection_domain, |
jrose@1863 | 353 | FailureMode failure_mode, TRAPS) { |
jrose@1863 | 354 | if (!is_object()) |
jrose@1863 | 355 | return Universe::java_mirror(type()); |
coleenp@4037 | 356 | Klass* klass = as_klass(class_loader, protection_domain, failure_mode, CHECK_NULL); |
jrose@1863 | 357 | if (klass == NULL) return NULL; |
hseigel@4278 | 358 | return klass->java_mirror(); |
jrose@1863 | 359 | } |
duke@435 | 360 | |
coleenp@2497 | 361 | Symbol* SignatureStream::as_symbol_or_null() { |
duke@435 | 362 | // Create a symbol from for string _begin _end |
duke@435 | 363 | ResourceMark rm; |
duke@435 | 364 | |
duke@435 | 365 | int begin = _begin; |
duke@435 | 366 | int end = _end; |
duke@435 | 367 | |
coleenp@2497 | 368 | if ( _signature->byte_at(_begin) == 'L' |
coleenp@2497 | 369 | && _signature->byte_at(_end-1) == ';') { |
duke@435 | 370 | begin++; |
duke@435 | 371 | end--; |
duke@435 | 372 | } |
duke@435 | 373 | |
duke@435 | 374 | char* buffer = NEW_RESOURCE_ARRAY(char, end - begin); |
duke@435 | 375 | for (int index = begin; index < end; index++) { |
coleenp@2497 | 376 | buffer[index - begin] = _signature->byte_at(index); |
duke@435 | 377 | } |
coleenp@2497 | 378 | Symbol* result = SymbolTable::probe(buffer, end - begin); |
duke@435 | 379 | return result; |
duke@435 | 380 | } |
duke@435 | 381 | |
roland@5914 | 382 | int SignatureStream::reference_parameter_count() { |
roland@5914 | 383 | int args_count = 0; |
roland@5914 | 384 | for ( ; !at_return_type(); next()) { |
roland@5914 | 385 | if (is_object()) { |
roland@5914 | 386 | args_count++; |
roland@5914 | 387 | } |
roland@5914 | 388 | } |
roland@5914 | 389 | return args_count; |
roland@5914 | 390 | } |
roland@5914 | 391 | |
coleenp@2497 | 392 | bool SignatureVerifier::is_valid_signature(Symbol* sig) { |
duke@435 | 393 | const char* signature = (const char*)sig->bytes(); |
duke@435 | 394 | ssize_t len = sig->utf8_length(); |
duke@435 | 395 | if (signature == NULL || signature[0] == '\0' || len < 1) { |
duke@435 | 396 | return false; |
duke@435 | 397 | } else if (signature[0] == '(') { |
duke@435 | 398 | return is_valid_method_signature(sig); |
duke@435 | 399 | } else { |
duke@435 | 400 | return is_valid_type_signature(sig); |
duke@435 | 401 | } |
duke@435 | 402 | } |
duke@435 | 403 | |
coleenp@2497 | 404 | bool SignatureVerifier::is_valid_method_signature(Symbol* sig) { |
duke@435 | 405 | const char* method_sig = (const char*)sig->bytes(); |
duke@435 | 406 | ssize_t len = sig->utf8_length(); |
duke@435 | 407 | ssize_t index = 0; |
duke@435 | 408 | if (method_sig != NULL && len > 1 && method_sig[index] == '(') { |
duke@435 | 409 | ++index; |
duke@435 | 410 | while (index < len && method_sig[index] != ')') { |
duke@435 | 411 | ssize_t res = is_valid_type(&method_sig[index], len - index); |
duke@435 | 412 | if (res == -1) { |
duke@435 | 413 | return false; |
duke@435 | 414 | } else { |
duke@435 | 415 | index += res; |
duke@435 | 416 | } |
duke@435 | 417 | } |
duke@435 | 418 | if (index < len && method_sig[index] == ')') { |
duke@435 | 419 | // check the return type |
duke@435 | 420 | ++index; |
duke@435 | 421 | return (is_valid_type(&method_sig[index], len - index) == (len - index)); |
duke@435 | 422 | } |
duke@435 | 423 | } |
duke@435 | 424 | return false; |
duke@435 | 425 | } |
duke@435 | 426 | |
coleenp@2497 | 427 | bool SignatureVerifier::is_valid_type_signature(Symbol* sig) { |
duke@435 | 428 | const char* type_sig = (const char*)sig->bytes(); |
duke@435 | 429 | ssize_t len = sig->utf8_length(); |
duke@435 | 430 | return (type_sig != NULL && len >= 1 && |
duke@435 | 431 | (is_valid_type(type_sig, len) == len)); |
duke@435 | 432 | } |
duke@435 | 433 | |
duke@435 | 434 | // Checks to see if the type (not to go beyond 'limit') refers to a valid type. |
duke@435 | 435 | // Returns -1 if it is not, or the index of the next character that is not part |
duke@435 | 436 | // of the type. The type encoding may end before 'limit' and that's ok. |
duke@435 | 437 | ssize_t SignatureVerifier::is_valid_type(const char* type, ssize_t limit) { |
duke@435 | 438 | ssize_t index = 0; |
duke@435 | 439 | |
duke@435 | 440 | // Iterate over any number of array dimensions |
duke@435 | 441 | while (index < limit && type[index] == '[') ++index; |
duke@435 | 442 | if (index >= limit) { |
duke@435 | 443 | return -1; |
duke@435 | 444 | } |
duke@435 | 445 | switch (type[index]) { |
duke@435 | 446 | case 'B': case 'C': case 'D': case 'F': case 'I': |
duke@435 | 447 | case 'J': case 'S': case 'Z': case 'V': |
duke@435 | 448 | return index + 1; |
duke@435 | 449 | case 'L': |
duke@435 | 450 | for (index = index + 1; index < limit; ++index) { |
duke@435 | 451 | char c = type[index]; |
duke@435 | 452 | if (c == ';') { |
duke@435 | 453 | return index + 1; |
duke@435 | 454 | } |
duke@435 | 455 | if (invalid_name_char(c)) { |
duke@435 | 456 | return -1; |
duke@435 | 457 | } |
duke@435 | 458 | } |
duke@435 | 459 | // fall through |
duke@435 | 460 | default: ; // fall through |
duke@435 | 461 | } |
duke@435 | 462 | return -1; |
duke@435 | 463 | } |
duke@435 | 464 | |
duke@435 | 465 | bool SignatureVerifier::invalid_name_char(char c) { |
duke@435 | 466 | switch (c) { |
duke@435 | 467 | case '\0': case '.': case ';': case '[': |
duke@435 | 468 | return true; |
duke@435 | 469 | default: |
duke@435 | 470 | return false; |
duke@435 | 471 | } |
duke@435 | 472 | } |