Tue, 26 Nov 2013 14:35:38 +0100
8027675: Full collections with Serial slower in JDK 8 compared to 7u40
Summary: Reduced the number of calls to follow_class_loader and instead marked and pushed the klass holder directly. Also removed unneeded calls to adjust_klass.
Reviewed-by: coleenp, jmasa, mgerdin, tschatzl
duke@435 | 1 | /* |
acorn@4497 | 2 | * Copyright (c) 2005, 2013, Oracle and/or its affiliates. All rights reserved. |
duke@435 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
duke@435 | 4 | * |
duke@435 | 5 | * This code is free software; you can redistribute it and/or modify it |
duke@435 | 6 | * under the terms of the GNU General Public License version 2 only, as |
duke@435 | 7 | * published by the Free Software Foundation. |
duke@435 | 8 | * |
duke@435 | 9 | * This code is distributed in the hope that it will be useful, but WITHOUT |
duke@435 | 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
duke@435 | 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
duke@435 | 12 | * version 2 for more details (a copy is included in the LICENSE file that |
duke@435 | 13 | * accompanied this code). |
duke@435 | 14 | * |
duke@435 | 15 | * You should have received a copy of the GNU General Public License version |
duke@435 | 16 | * 2 along with this work; if not, write to the Free Software Foundation, |
duke@435 | 17 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
duke@435 | 18 | * |
trims@1907 | 19 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
trims@1907 | 20 | * or visit www.oracle.com if you need additional information or have any |
trims@1907 | 21 | * questions. |
duke@435 | 22 | * |
duke@435 | 23 | */ |
duke@435 | 24 | |
stefank@2314 | 25 | #include "precompiled.hpp" |
stefank@2314 | 26 | #include "classfile/classLoader.hpp" |
stefank@2314 | 27 | #include "classfile/javaClasses.hpp" |
stefank@2314 | 28 | #include "gc_implementation/shared/vmGCOperations.hpp" |
stefank@2314 | 29 | #include "memory/gcLocker.inline.hpp" |
stefank@2314 | 30 | #include "memory/genCollectedHeap.hpp" |
stefank@2314 | 31 | #include "memory/oopFactory.hpp" |
stefank@2314 | 32 | #include "oops/instanceKlass.hpp" |
stefank@2314 | 33 | #include "oops/instanceRefKlass.hpp" |
stefank@2314 | 34 | #include "runtime/handles.inline.hpp" |
stefank@2314 | 35 | #include "runtime/init.hpp" |
stefank@2314 | 36 | #include "runtime/interfaceSupport.hpp" |
stefank@2314 | 37 | #include "utilities/dtrace.hpp" |
stefank@2314 | 38 | #include "utilities/preserveException.hpp" |
jprovino@4542 | 39 | #include "utilities/macros.hpp" |
jprovino@4542 | 40 | #if INCLUDE_ALL_GCS |
stefank@2314 | 41 | #include "gc_implementation/g1/g1CollectedHeap.inline.hpp" |
jprovino@4542 | 42 | #endif // INCLUDE_ALL_GCS |
kamg@2445 | 43 | |
dcubed@3202 | 44 | #ifndef USDT2 |
duke@435 | 45 | HS_DTRACE_PROBE_DECL1(hotspot, gc__begin, bool); |
duke@435 | 46 | HS_DTRACE_PROBE_DECL(hotspot, gc__end); |
dcubed@3202 | 47 | #endif /* !USDT2 */ |
duke@435 | 48 | |
duke@435 | 49 | // The same dtrace probe can't be inserted in two different files, so we |
duke@435 | 50 | // have to call it here, so it's only in one file. Can't create new probes |
duke@435 | 51 | // for the other file anymore. The dtrace probes have to remain stable. |
duke@435 | 52 | void VM_GC_Operation::notify_gc_begin(bool full) { |
dcubed@3202 | 53 | #ifndef USDT2 |
duke@435 | 54 | HS_DTRACE_PROBE1(hotspot, gc__begin, full); |
jcoomes@1902 | 55 | HS_DTRACE_WORKAROUND_TAIL_CALL_BUG(); |
dcubed@3202 | 56 | #else /* USDT2 */ |
dcubed@3202 | 57 | HOTSPOT_GC_BEGIN( |
dcubed@3202 | 58 | full); |
dcubed@3202 | 59 | #endif /* USDT2 */ |
duke@435 | 60 | } |
duke@435 | 61 | |
duke@435 | 62 | void VM_GC_Operation::notify_gc_end() { |
dcubed@3202 | 63 | #ifndef USDT2 |
duke@435 | 64 | HS_DTRACE_PROBE(hotspot, gc__end); |
jcoomes@1902 | 65 | HS_DTRACE_WORKAROUND_TAIL_CALL_BUG(); |
dcubed@3202 | 66 | #else /* USDT2 */ |
dcubed@3202 | 67 | HOTSPOT_GC_END( |
dcubed@3202 | 68 | ); |
dcubed@3202 | 69 | #endif /* USDT2 */ |
duke@435 | 70 | } |
duke@435 | 71 | |
duke@435 | 72 | void VM_GC_Operation::acquire_pending_list_lock() { |
duke@435 | 73 | // we may enter this with pending exception set |
coleenp@4047 | 74 | InstanceRefKlass::acquire_pending_list_lock(&_pending_list_basic_lock); |
duke@435 | 75 | } |
duke@435 | 76 | |
duke@435 | 77 | |
duke@435 | 78 | void VM_GC_Operation::release_and_notify_pending_list_lock() { |
duke@435 | 79 | |
coleenp@4047 | 80 | InstanceRefKlass::release_and_notify_pending_list_lock(&_pending_list_basic_lock); |
duke@435 | 81 | } |
duke@435 | 82 | |
duke@435 | 83 | // Allocations may fail in several threads at about the same time, |
duke@435 | 84 | // resulting in multiple gc requests. We only want to do one of them. |
duke@435 | 85 | // In case a GC locker is active and the need for a GC is already signalled, |
duke@435 | 86 | // we want to skip this GC attempt altogether, without doing a futile |
duke@435 | 87 | // safepoint operation. |
duke@435 | 88 | bool VM_GC_Operation::skip_operation() const { |
duke@435 | 89 | bool skip = (_gc_count_before != Universe::heap()->total_collections()); |
duke@435 | 90 | if (_full && skip) { |
duke@435 | 91 | skip = (_full_gc_count_before != Universe::heap()->total_full_collections()); |
duke@435 | 92 | } |
duke@435 | 93 | if (!skip && GC_locker::is_active_and_needs_gc()) { |
duke@435 | 94 | skip = Universe::heap()->is_maximal_no_gc(); |
duke@435 | 95 | assert(!(skip && (_gc_cause == GCCause::_gc_locker)), |
duke@435 | 96 | "GC_locker cannot be active when initiating GC"); |
duke@435 | 97 | } |
duke@435 | 98 | return skip; |
duke@435 | 99 | } |
duke@435 | 100 | |
duke@435 | 101 | bool VM_GC_Operation::doit_prologue() { |
duke@435 | 102 | assert(Thread::current()->is_Java_thread(), "just checking"); |
brutisso@2532 | 103 | assert(((_gc_cause != GCCause::_no_gc) && |
brutisso@2532 | 104 | (_gc_cause != GCCause::_no_cause_specified)), "Illegal GCCause"); |
duke@435 | 105 | |
duke@435 | 106 | acquire_pending_list_lock(); |
duke@435 | 107 | // If the GC count has changed someone beat us to the collection |
duke@435 | 108 | // Get the Heap_lock after the pending_list_lock. |
duke@435 | 109 | Heap_lock->lock(); |
ysr@777 | 110 | |
duke@435 | 111 | // Check invocations |
duke@435 | 112 | if (skip_operation()) { |
duke@435 | 113 | // skip collection |
duke@435 | 114 | Heap_lock->unlock(); |
duke@435 | 115 | release_and_notify_pending_list_lock(); |
duke@435 | 116 | _prologue_succeeded = false; |
duke@435 | 117 | } else { |
duke@435 | 118 | _prologue_succeeded = true; |
ysr@777 | 119 | SharedHeap* sh = SharedHeap::heap(); |
ysr@777 | 120 | if (sh != NULL) sh->_thread_holds_heap_lock_for_gc = true; |
duke@435 | 121 | } |
duke@435 | 122 | return _prologue_succeeded; |
duke@435 | 123 | } |
duke@435 | 124 | |
duke@435 | 125 | |
duke@435 | 126 | void VM_GC_Operation::doit_epilogue() { |
duke@435 | 127 | assert(Thread::current()->is_Java_thread(), "just checking"); |
duke@435 | 128 | // Release the Heap_lock first. |
ysr@777 | 129 | SharedHeap* sh = SharedHeap::heap(); |
ysr@777 | 130 | if (sh != NULL) sh->_thread_holds_heap_lock_for_gc = false; |
duke@435 | 131 | Heap_lock->unlock(); |
duke@435 | 132 | release_and_notify_pending_list_lock(); |
duke@435 | 133 | } |
duke@435 | 134 | |
duke@435 | 135 | bool VM_GC_HeapInspection::doit_prologue() { |
duke@435 | 136 | if (Universe::heap()->supports_heap_inspection()) { |
duke@435 | 137 | return VM_GC_Operation::doit_prologue(); |
duke@435 | 138 | } else { |
duke@435 | 139 | return false; |
duke@435 | 140 | } |
duke@435 | 141 | } |
duke@435 | 142 | |
duke@435 | 143 | bool VM_GC_HeapInspection::skip_operation() const { |
duke@435 | 144 | assert(Universe::heap()->supports_heap_inspection(), "huh?"); |
duke@435 | 145 | return false; |
duke@435 | 146 | } |
duke@435 | 147 | |
sla@5237 | 148 | bool VM_GC_HeapInspection::collect() { |
sla@5237 | 149 | if (GC_locker::is_active()) { |
sla@5237 | 150 | return false; |
sla@5237 | 151 | } |
sla@5237 | 152 | Universe::heap()->collect_as_vm_thread(GCCause::_heap_inspection); |
sla@5237 | 153 | return true; |
sla@5237 | 154 | } |
sla@5237 | 155 | |
duke@435 | 156 | void VM_GC_HeapInspection::doit() { |
duke@435 | 157 | HandleMark hm; |
sla@5237 | 158 | Universe::heap()->ensure_parsability(false); // must happen, even if collection does |
sla@5237 | 159 | // not happen (e.g. due to GC_locker) |
sla@5237 | 160 | // or _full_gc being false |
duke@435 | 161 | if (_full_gc) { |
sla@5237 | 162 | if (!collect()) { |
sla@5237 | 163 | // The collection attempt was skipped because the gc locker is held. |
sla@5237 | 164 | // The following dump may then be a tad misleading to someone expecting |
sla@5237 | 165 | // only live objects to show up in the dump (see CR 6944195). Just issue |
sla@5237 | 166 | // a suitable warning in that case and do not attempt to do a collection. |
sla@5237 | 167 | // The latter is a subtle point, because even a failed attempt |
sla@5237 | 168 | // to GC will, in fact, induce one in the future, which we |
sla@5237 | 169 | // probably want to avoid in this case because the GC that we may |
sla@5237 | 170 | // be about to attempt holds value for us only |
sla@5237 | 171 | // if it happens now and not if it happens in the eventual |
sla@5237 | 172 | // future. |
kevinw@1827 | 173 | warning("GC locker is held; pre-dump GC was skipped"); |
kevinw@1827 | 174 | } |
duke@435 | 175 | } |
acorn@4497 | 176 | HeapInspection inspect(_csv_format, _print_help, _print_class_stats, |
acorn@4497 | 177 | _columns); |
sla@5237 | 178 | inspect.heap_inspection(_out); |
duke@435 | 179 | } |
duke@435 | 180 | |
duke@435 | 181 | |
duke@435 | 182 | void VM_GenCollectForAllocation::doit() { |
kamg@2445 | 183 | SvcGCMarker sgcm(SvcGCMarker::MINOR); |
duke@435 | 184 | |
duke@435 | 185 | GenCollectedHeap* gch = GenCollectedHeap::heap(); |
duke@435 | 186 | GCCauseSetter gccs(gch, _gc_cause); |
duke@435 | 187 | _res = gch->satisfy_failed_allocation(_size, _tlab); |
duke@435 | 188 | assert(gch->is_in_reserved_or_null(_res), "result not in heap"); |
duke@435 | 189 | |
duke@435 | 190 | if (_res == NULL && GC_locker::is_active_and_needs_gc()) { |
duke@435 | 191 | set_gc_locked(); |
duke@435 | 192 | } |
duke@435 | 193 | } |
duke@435 | 194 | |
duke@435 | 195 | void VM_GenCollectFull::doit() { |
kamg@2445 | 196 | SvcGCMarker sgcm(SvcGCMarker::FULL); |
duke@435 | 197 | |
duke@435 | 198 | GenCollectedHeap* gch = GenCollectedHeap::heap(); |
duke@435 | 199 | GCCauseSetter gccs(gch, _gc_cause); |
duke@435 | 200 | gch->do_full_collection(gch->must_clear_all_soft_refs(), _max_level); |
duke@435 | 201 | } |
apetrusenko@574 | 202 | |
coleenp@4037 | 203 | void VM_CollectForMetadataAllocation::doit() { |
kamg@2445 | 204 | SvcGCMarker sgcm(SvcGCMarker::FULL); |
kamg@2445 | 205 | |
coleenp@4037 | 206 | CollectedHeap* heap = Universe::heap(); |
ysr@777 | 207 | GCCauseSetter gccs(heap, _gc_cause); |
coleenp@4037 | 208 | |
coleenp@4037 | 209 | // Check again if the space is available. Another thread |
coleenp@4037 | 210 | // may have similarly failed a metadata allocation and induced |
coleenp@4037 | 211 | // a GC that freed space for the allocation. |
coleenp@4037 | 212 | if (!MetadataAllocationFailALot) { |
coleenp@4037 | 213 | _result = _loader_data->metaspace_non_null()->allocate(_size, _mdtype); |
jmasa@5946 | 214 | } |
coleenp@4037 | 215 | |
coleenp@4037 | 216 | if (_result == NULL) { |
jmasa@4131 | 217 | if (UseConcMarkSweepGC) { |
jmasa@4131 | 218 | if (CMSClassUnloadingEnabled) { |
jmasa@4131 | 219 | MetaspaceGC::set_should_concurrent_collect(true); |
jmasa@4131 | 220 | } |
jmasa@4131 | 221 | // For CMS expand since the collection is going to be concurrent. |
jmasa@4131 | 222 | _result = |
jmasa@4131 | 223 | _loader_data->metaspace_non_null()->expand_and_allocate(_size, _mdtype); |
jmasa@4131 | 224 | } |
jmasa@4131 | 225 | if (_result == NULL) { |
jmasa@5946 | 226 | // Don't clear the soft refs yet. |
jmasa@4131 | 227 | if (Verbose && PrintGCDetails && UseConcMarkSweepGC) { |
jmasa@4131 | 228 | gclog_or_tty->print_cr("\nCMS full GC for Metaspace"); |
jmasa@4131 | 229 | } |
coleenp@4037 | 230 | heap->collect_as_vm_thread(GCCause::_metadata_GC_threshold); |
jmasa@5015 | 231 | // After a GC try to allocate without expanding. Could fail |
jmasa@5015 | 232 | // and expansion will be tried below. |
jmasa@5015 | 233 | _result = |
jmasa@5015 | 234 | _loader_data->metaspace_non_null()->allocate(_size, _mdtype); |
ysr@777 | 235 | } |
jmasa@5946 | 236 | if (_result == NULL) { |
coleenp@4037 | 237 | // If still failing, allow the Metaspace to expand. |
coleenp@4037 | 238 | // See delta_capacity_until_GC() for explanation of the |
coleenp@4037 | 239 | // amount of the expansion. |
coleenp@4037 | 240 | // This should work unless there really is no more space |
coleenp@4037 | 241 | // or a MaxMetaspaceSize has been specified on the command line. |
jmasa@4064 | 242 | _result = |
jmasa@4064 | 243 | _loader_data->metaspace_non_null()->expand_and_allocate(_size, _mdtype); |
jmasa@5946 | 244 | if (_result == NULL) { |
jmasa@5946 | 245 | // If expansion failed, do a last-ditch collection and try allocating |
jmasa@5946 | 246 | // again. A last-ditch collection will clear softrefs. This |
jmasa@5946 | 247 | // behavior is similar to the last-ditch collection done for perm |
jmasa@5946 | 248 | // gen when it was full and a collection for failed allocation |
jmasa@5946 | 249 | // did not free perm gen space. |
jmasa@5946 | 250 | heap->collect_as_vm_thread(GCCause::_last_ditch_collection); |
jmasa@5946 | 251 | _result = |
jmasa@5946 | 252 | _loader_data->metaspace_non_null()->allocate(_size, _mdtype); |
jmasa@5946 | 253 | } |
jmasa@4131 | 254 | } |
jmasa@4131 | 255 | if (Verbose && PrintGCDetails && _result == NULL) { |
jmasa@4131 | 256 | gclog_or_tty->print_cr("\nAfter Metaspace GC failed to allocate size " |
jmasa@4131 | 257 | SIZE_FORMAT, _size); |
coleenp@4037 | 258 | } |
coleenp@4037 | 259 | } |
coleenp@4037 | 260 | |
coleenp@4037 | 261 | if (_result == NULL && GC_locker::is_active_and_needs_gc()) { |
apetrusenko@574 | 262 | set_gc_locked(); |
apetrusenko@574 | 263 | } |
apetrusenko@574 | 264 | } |