Thu, 27 Feb 2020 05:40:59 +0000
8187078: -XX:+VerifyOops finds numerous problems when running JPRT
Reviewed-by: andrew
duke@435 | 1 | /* |
drchase@6680 | 2 | * Copyright (c) 1997, 2014, Oracle and/or its affiliates. All rights reserved. |
duke@435 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
duke@435 | 4 | * |
duke@435 | 5 | * This code is free software; you can redistribute it and/or modify it |
duke@435 | 6 | * under the terms of the GNU General Public License version 2 only, as |
duke@435 | 7 | * published by the Free Software Foundation. |
duke@435 | 8 | * |
duke@435 | 9 | * This code is distributed in the hope that it will be useful, but WITHOUT |
duke@435 | 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
duke@435 | 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
duke@435 | 12 | * version 2 for more details (a copy is included in the LICENSE file that |
duke@435 | 13 | * accompanied this code). |
duke@435 | 14 | * |
duke@435 | 15 | * You should have received a copy of the GNU General Public License version |
duke@435 | 16 | * 2 along with this work; if not, write to the Free Software Foundation, |
duke@435 | 17 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
duke@435 | 18 | * |
trims@1907 | 19 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
trims@1907 | 20 | * or visit www.oracle.com if you need additional information or have any |
trims@1907 | 21 | * questions. |
duke@435 | 22 | * |
duke@435 | 23 | */ |
duke@435 | 24 | |
stefank@2314 | 25 | #include "precompiled.hpp" |
stefank@2314 | 26 | #include "memory/allocation.inline.hpp" |
coleenp@4037 | 27 | #include "oops/constantPool.hpp" |
stefank@2314 | 28 | #include "oops/oop.inline.hpp" |
stefank@2314 | 29 | #include "runtime/handles.inline.hpp" |
stefank@4299 | 30 | #include "runtime/thread.inline.hpp" |
stefank@2314 | 31 | #ifdef TARGET_OS_FAMILY_linux |
stefank@2314 | 32 | # include "os_linux.inline.hpp" |
stefank@2314 | 33 | #endif |
stefank@2314 | 34 | #ifdef TARGET_OS_FAMILY_solaris |
stefank@2314 | 35 | # include "os_solaris.inline.hpp" |
stefank@2314 | 36 | #endif |
stefank@2314 | 37 | #ifdef TARGET_OS_FAMILY_windows |
stefank@2314 | 38 | # include "os_windows.inline.hpp" |
stefank@2314 | 39 | #endif |
never@3156 | 40 | #ifdef TARGET_OS_FAMILY_bsd |
never@3156 | 41 | # include "os_bsd.inline.hpp" |
never@3156 | 42 | #endif |
duke@435 | 43 | |
drchase@6680 | 44 | PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC |
drchase@6680 | 45 | |
duke@435 | 46 | #ifdef ASSERT |
duke@435 | 47 | oop* HandleArea::allocate_handle(oop obj) { |
duke@435 | 48 | assert(_handle_mark_nesting > 1, "memory leak: allocating handle outside HandleMark"); |
duke@435 | 49 | assert(_no_handle_mark_nesting == 0, "allocating handle inside NoHandleMark"); |
twisti@6039 | 50 | assert(obj->is_oop(), err_msg("not an oop: " INTPTR_FORMAT, (intptr_t*) obj)); |
duke@435 | 51 | return real_allocate_handle(obj); |
duke@435 | 52 | } |
duke@435 | 53 | |
duke@435 | 54 | Handle::Handle(Thread* thread, oop obj) { |
duke@435 | 55 | assert(thread == Thread::current(), "sanity check"); |
duke@435 | 56 | if (obj == NULL) { |
duke@435 | 57 | _handle = NULL; |
duke@435 | 58 | } else { |
duke@435 | 59 | _handle = thread->handle_area()->allocate_handle(obj); |
duke@435 | 60 | } |
duke@435 | 61 | } |
duke@435 | 62 | |
duke@435 | 63 | #endif |
duke@435 | 64 | |
duke@435 | 65 | static uintx chunk_oops_do(OopClosure* f, Chunk* chunk, char* chunk_top) { |
duke@435 | 66 | oop* bottom = (oop*) chunk->bottom(); |
duke@435 | 67 | oop* top = (oop*) chunk_top; |
duke@435 | 68 | uintx handles_visited = top - bottom; |
duke@435 | 69 | assert(top >= bottom && top <= (oop*) chunk->top(), "just checking"); |
duke@435 | 70 | // during GC phase 3, a handle may be a forward pointer that |
duke@435 | 71 | // is not yet valid, so loosen the assertion |
duke@435 | 72 | while (bottom < top) { |
coleenp@4037 | 73 | // This test can be moved up but for now check every oop. |
coleenp@4037 | 74 | |
coleenp@4037 | 75 | assert((*bottom)->is_oop(), "handle should point to oop"); |
coleenp@4037 | 76 | |
duke@435 | 77 | f->do_oop(bottom++); |
duke@435 | 78 | } |
duke@435 | 79 | return handles_visited; |
duke@435 | 80 | } |
duke@435 | 81 | |
duke@435 | 82 | // Used for debugging handle allocation. |
duke@435 | 83 | NOT_PRODUCT(jint _nof_handlemarks = 0;) |
duke@435 | 84 | |
duke@435 | 85 | void HandleArea::oops_do(OopClosure* f) { |
duke@435 | 86 | uintx handles_visited = 0; |
duke@435 | 87 | // First handle the current chunk. It is filled to the high water mark. |
duke@435 | 88 | handles_visited += chunk_oops_do(f, _chunk, _hwm); |
duke@435 | 89 | // Then handle all previous chunks. They are completely filled. |
duke@435 | 90 | Chunk* k = _first; |
duke@435 | 91 | while(k != _chunk) { |
duke@435 | 92 | handles_visited += chunk_oops_do(f, k, k->top()); |
duke@435 | 93 | k = k->next(); |
duke@435 | 94 | } |
duke@435 | 95 | |
duke@435 | 96 | // The thread local handle areas should not get very large |
duke@435 | 97 | if (TraceHandleAllocation && handles_visited > TotalHandleAllocationLimit) { |
duke@435 | 98 | #ifdef ASSERT |
duke@435 | 99 | warning("%d: Visited in HandleMark : %d", |
duke@435 | 100 | _nof_handlemarks, handles_visited); |
duke@435 | 101 | #else |
duke@435 | 102 | warning("Visited in HandleMark : %d", handles_visited); |
duke@435 | 103 | #endif |
duke@435 | 104 | } |
duke@435 | 105 | if (_prev != NULL) _prev->oops_do(f); |
duke@435 | 106 | } |
duke@435 | 107 | |
duke@435 | 108 | void HandleMark::initialize(Thread* thread) { |
duke@435 | 109 | _thread = thread; |
duke@435 | 110 | // Save area |
duke@435 | 111 | _area = thread->handle_area(); |
duke@435 | 112 | // Save current top |
duke@435 | 113 | _chunk = _area->_chunk; |
duke@435 | 114 | _hwm = _area->_hwm; |
duke@435 | 115 | _max = _area->_max; |
zgu@3900 | 116 | _size_in_bytes = _area->_size_in_bytes; |
duke@435 | 117 | debug_only(_area->_handle_mark_nesting++); |
duke@435 | 118 | assert(_area->_handle_mark_nesting > 0, "must stack allocate HandleMarks"); |
duke@435 | 119 | debug_only(Atomic::inc(&_nof_handlemarks);) |
duke@435 | 120 | |
duke@435 | 121 | // Link this in the thread |
duke@435 | 122 | set_previous_handle_mark(thread->last_handle_mark()); |
duke@435 | 123 | thread->set_last_handle_mark(this); |
duke@435 | 124 | } |
duke@435 | 125 | |
duke@435 | 126 | |
duke@435 | 127 | HandleMark::~HandleMark() { |
duke@435 | 128 | HandleArea* area = _area; // help compilers with poor alias analysis |
duke@435 | 129 | assert(area == _thread->handle_area(), "sanity check"); |
duke@435 | 130 | assert(area->_handle_mark_nesting > 0, "must stack allocate HandleMarks" ); |
duke@435 | 131 | debug_only(area->_handle_mark_nesting--); |
duke@435 | 132 | |
duke@435 | 133 | // Debug code to trace the number of handles allocated per mark/ |
duke@435 | 134 | #ifdef ASSERT |
duke@435 | 135 | if (TraceHandleAllocation) { |
duke@435 | 136 | size_t handles = 0; |
duke@435 | 137 | Chunk *c = _chunk->next(); |
duke@435 | 138 | if (c == NULL) { |
duke@435 | 139 | handles = area->_hwm - _hwm; // no new chunk allocated |
duke@435 | 140 | } else { |
duke@435 | 141 | handles = _max - _hwm; // add rest in first chunk |
duke@435 | 142 | while(c != NULL) { |
duke@435 | 143 | handles += c->length(); |
duke@435 | 144 | c = c->next(); |
duke@435 | 145 | } |
duke@435 | 146 | handles -= area->_max - area->_hwm; // adjust for last trunk not full |
duke@435 | 147 | } |
duke@435 | 148 | handles /= sizeof(void *); // Adjust for size of a handle |
duke@435 | 149 | if (handles > HandleAllocationLimit) { |
duke@435 | 150 | // Note: _nof_handlemarks is only set in debug mode |
duke@435 | 151 | warning("%d: Allocated in HandleMark : %d", _nof_handlemarks, handles); |
duke@435 | 152 | } |
coleenp@4037 | 153 | |
coleenp@4037 | 154 | tty->print_cr("Handles %d", handles); |
duke@435 | 155 | } |
duke@435 | 156 | #endif |
duke@435 | 157 | |
duke@435 | 158 | // Delete later chunks |
duke@435 | 159 | if( _chunk->next() ) { |
zgu@4193 | 160 | // reset arena size before delete chunks. Otherwise, the total |
zgu@4193 | 161 | // arena size could exceed total chunk size |
zgu@4193 | 162 | assert(area->size_in_bytes() > size_in_bytes(), "Sanity check"); |
zgu@4193 | 163 | area->set_size_in_bytes(size_in_bytes()); |
duke@435 | 164 | _chunk->next_chop(); |
zgu@4193 | 165 | } else { |
zgu@4193 | 166 | assert(area->size_in_bytes() == size_in_bytes(), "Sanity check"); |
duke@435 | 167 | } |
duke@435 | 168 | // Roll back arena to saved top markers |
duke@435 | 169 | area->_chunk = _chunk; |
duke@435 | 170 | area->_hwm = _hwm; |
duke@435 | 171 | area->_max = _max; |
duke@435 | 172 | #ifdef ASSERT |
duke@435 | 173 | // clear out first chunk (to detect allocation bugs) |
duke@435 | 174 | if (ZapVMHandleArea) { |
duke@435 | 175 | memset(_hwm, badHandleValue, _max - _hwm); |
duke@435 | 176 | } |
duke@435 | 177 | Atomic::dec(&_nof_handlemarks); |
duke@435 | 178 | #endif |
duke@435 | 179 | |
duke@435 | 180 | // Unlink this from the thread |
duke@435 | 181 | _thread->set_last_handle_mark(previous_handle_mark()); |
duke@435 | 182 | } |
duke@435 | 183 | |
coleenp@5614 | 184 | void* HandleMark::operator new(size_t size) throw() { |
minqi@5103 | 185 | return AllocateHeap(size, mtThread); |
minqi@5103 | 186 | } |
minqi@5103 | 187 | |
coleenp@5614 | 188 | void* HandleMark::operator new [] (size_t size) throw() { |
minqi@5103 | 189 | return AllocateHeap(size, mtThread); |
minqi@5103 | 190 | } |
minqi@5103 | 191 | |
minqi@5103 | 192 | void HandleMark::operator delete(void* p) { |
minqi@5103 | 193 | FreeHeap(p, mtThread); |
minqi@5103 | 194 | } |
minqi@5103 | 195 | |
minqi@5103 | 196 | void HandleMark::operator delete[](void* p) { |
minqi@5103 | 197 | FreeHeap(p, mtThread); |
minqi@5103 | 198 | } |
minqi@5103 | 199 | |
duke@435 | 200 | #ifdef ASSERT |
duke@435 | 201 | |
duke@435 | 202 | NoHandleMark::NoHandleMark() { |
duke@435 | 203 | HandleArea* area = Thread::current()->handle_area(); |
duke@435 | 204 | area->_no_handle_mark_nesting++; |
duke@435 | 205 | assert(area->_no_handle_mark_nesting > 0, "must stack allocate NoHandleMark" ); |
duke@435 | 206 | } |
duke@435 | 207 | |
duke@435 | 208 | |
duke@435 | 209 | NoHandleMark::~NoHandleMark() { |
duke@435 | 210 | HandleArea* area = Thread::current()->handle_area(); |
duke@435 | 211 | assert(area->_no_handle_mark_nesting > 0, "must stack allocate NoHandleMark" ); |
duke@435 | 212 | area->_no_handle_mark_nesting--; |
duke@435 | 213 | } |
duke@435 | 214 | |
duke@435 | 215 | |
duke@435 | 216 | ResetNoHandleMark::ResetNoHandleMark() { |
duke@435 | 217 | HandleArea* area = Thread::current()->handle_area(); |
duke@435 | 218 | _no_handle_mark_nesting = area->_no_handle_mark_nesting; |
duke@435 | 219 | area->_no_handle_mark_nesting = 0; |
duke@435 | 220 | } |
duke@435 | 221 | |
duke@435 | 222 | |
duke@435 | 223 | ResetNoHandleMark::~ResetNoHandleMark() { |
duke@435 | 224 | HandleArea* area = Thread::current()->handle_area(); |
duke@435 | 225 | area->_no_handle_mark_nesting = _no_handle_mark_nesting; |
duke@435 | 226 | } |
duke@435 | 227 | |
duke@435 | 228 | #endif |