Mercurial > jdk8-mips64-public > hotspot / annotate
src/share/vm/memory/referenceType.hpp@2c022e432e10 (annotated)
src/share/vm/memory/referenceType.hpp
Fri, 20 Sep 2013 10:53:28 +0200
- author
- stefank
- date
- Fri, 20 Sep 2013 10:53:28 +0200
- changeset 5769
- 2c022e432e10
- parent 0
- f90c822e73f8
- child 7469
- 01dcaba9b3f3
- permissions
- -rw-r--r--
8024974: Incorrect use of GC_locker::is_active()
Summary: SymbolTable and StringTable can make calls to GC_locker::is_active() outside a safepoint. This isn't safe because the GC_locker active state (lock count) is only updated at a safepoint and only remains valid as long as _needs_gc is true. However, outside a safepoint_needs_gc can change to false at any time, which makes it impossible to do a correct call to is_active() in that context. In this case these calls can just be removed since the input argument to basic_add() should never be on the heap and so there's no need to check the GC_locker state. This change also adjusts the assert() in is_active() to makes sure all calls to this function are always done under a safepoint.
Reviewed-by: brutisso, dcubed
Contributed-by: per.liden@oracle.com
| aoqi@0 | 1 | /* |
| aoqi@0 | 2 | * Copyright (c) 2012, 2013, Oracle and/or its affiliates. All rights reserved. |
| aoqi@0 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
| aoqi@0 | 4 | * |
| aoqi@0 | 5 | * This code is free software; you can redistribute it and/or modify it |
| aoqi@0 | 6 | * under the terms of the GNU General Public License version 2 only, as |
| aoqi@0 | 7 | * published by the Free Software Foundation. |
| aoqi@0 | 8 | * |
| aoqi@0 | 9 | * This code is distributed in the hope that it will be useful, but WITHOUT |
| aoqi@0 | 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
| aoqi@0 | 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
| aoqi@0 | 12 | * version 2 for more details (a copy is included in the LICENSE file that |
| aoqi@0 | 13 | * accompanied this code). |
| aoqi@0 | 14 | * |
| aoqi@0 | 15 | * You should have received a copy of the GNU General Public License version |
| aoqi@0 | 16 | * 2 along with this work; if not, write to the Free Software Foundation, |
| aoqi@0 | 17 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
| aoqi@0 | 18 | * |
| aoqi@0 | 19 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
| aoqi@0 | 20 | * or visit www.oracle.com if you need additional information or have any |
| aoqi@0 | 21 | * questions. |
| aoqi@0 | 22 | * |
| aoqi@0 | 23 | */ |
| aoqi@0 | 24 | |
| aoqi@0 | 25 | #ifndef SHARE_VM_MEMORY_REFRERENCETYPE_HPP |
| aoqi@0 | 26 | #define SHARE_VM_MEMORY_REFRERENCETYPE_HPP |
| aoqi@0 | 27 | |
| aoqi@0 | 28 | #include "utilities/debug.hpp" |
| aoqi@0 | 29 | |
| aoqi@0 | 30 | // ReferenceType is used to distinguish between java/lang/ref/Reference subclasses |
| aoqi@0 | 31 | |
| aoqi@0 | 32 | enum ReferenceType { |
| aoqi@0 | 33 | REF_NONE, // Regular class |
| aoqi@0 | 34 | REF_OTHER, // Subclass of java/lang/ref/Reference, but not subclass of one of the classes below |
| aoqi@0 | 35 | REF_SOFT, // Subclass of java/lang/ref/SoftReference |
| aoqi@0 | 36 | REF_WEAK, // Subclass of java/lang/ref/WeakReference |
| aoqi@0 | 37 | REF_FINAL, // Subclass of java/lang/ref/FinalReference |
| aoqi@0 | 38 | REF_PHANTOM // Subclass of java/lang/ref/PhantomReference |
| aoqi@0 | 39 | }; |
| aoqi@0 | 40 | |
| aoqi@0 | 41 | #endif // SHARE_VM_MEMORY_REFRERENCETYPE_HPP |
