Fri, 20 Sep 2013 10:53:28 +0200
8024974: Incorrect use of GC_locker::is_active()
Summary: SymbolTable and StringTable can make calls to GC_locker::is_active() outside a safepoint. This isn't safe because the GC_locker active state (lock count) is only updated at a safepoint and only remains valid as long as _needs_gc is true. However, outside a safepoint_needs_gc can change to false at any time, which makes it impossible to do a correct call to is_active() in that context. In this case these calls can just be removed since the input argument to basic_add() should never be on the heap and so there's no need to check the GC_locker state. This change also adjusts the assert() in is_active() to makes sure all calls to this function are always done under a safepoint.
Reviewed-by: brutisso, dcubed
Contributed-by: per.liden@oracle.com
duke@435 | 1 | # |
mikael@4153 | 2 | # Copyright (c) 1997, 2012, Oracle and/or its affiliates. All rights reserved. |
duke@435 | 3 | # DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
duke@435 | 4 | # |
duke@435 | 5 | # This code is free software; you can redistribute it and/or modify it |
duke@435 | 6 | # under the terms of the GNU General Public License version 2 only, as |
duke@435 | 7 | # published by the Free Software Foundation. |
duke@435 | 8 | # |
duke@435 | 9 | # This code is distributed in the hope that it will be useful, but WITHOUT |
duke@435 | 10 | # ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
duke@435 | 11 | # FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
duke@435 | 12 | # version 2 for more details (a copy is included in the LICENSE file that |
duke@435 | 13 | # accompanied this code). |
duke@435 | 14 | # |
duke@435 | 15 | # You should have received a copy of the GNU General Public License version |
duke@435 | 16 | # 2 along with this work; if not, write to the Free Software Foundation, |
duke@435 | 17 | # Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
duke@435 | 18 | # |
trims@1907 | 19 | # Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
trims@1907 | 20 | # or visit www.oracle.com if you need additional information or have any |
trims@1907 | 21 | # questions. |
duke@435 | 22 | # |
duke@435 | 23 | # |
duke@435 | 24 | |
duke@435 | 25 | DEFAULTACTIONS=clean post_update create |
duke@435 | 26 | |
duke@435 | 27 | default:: $(SUBDIRS) |
duke@435 | 28 | |
duke@435 | 29 | !ifndef DIR |
duke@435 | 30 | DIR=. |
duke@435 | 31 | !endif |
duke@435 | 32 | |
erikj@3518 | 33 | !ifndef CXX |
erikj@3518 | 34 | CXX=cl.exe |
duke@435 | 35 | !endif |
duke@435 | 36 | |
duke@435 | 37 | |
duke@435 | 38 | !ifdef SUBDIRS |
dcubed@3990 | 39 | # \ is used below because $(MAKE) is nmake here, which expects Windows paths |
duke@435 | 40 | $(SUBDIRS): FORCE |
duke@435 | 41 | @if not exist $@ mkdir $@ |
dcubed@3990 | 42 | @if not exist $@/local.make echo # Empty > $@/local.make |
dcubed@3990 | 43 | @echo nmake $(ACTION) in $(DIR)/$@ |
dcubed@3990 | 44 | cd $@ && $(MAKE) -NOLOGO -f $(WorkSpace)\make\windows\makefiles\$@.make $(ACTION) DIR=$(DIR)\$@ BUILD_FLAVOR=$(BUILD_FLAVOR) |
duke@435 | 45 | !endif |
duke@435 | 46 | |
duke@435 | 47 | # Creates the needed directory |
duke@435 | 48 | create:: |
duke@435 | 49 | !if "$(DIR)" != "." |
duke@435 | 50 | @echo mkdir $(DIR) |
duke@435 | 51 | !endif |
duke@435 | 52 | |
duke@435 | 53 | # Epilog to update for generating derived files |
duke@435 | 54 | post_update:: |
duke@435 | 55 | |
duke@435 | 56 | # Removes scrap files |
duke@435 | 57 | clean:: FORCE |
duke@435 | 58 | -@rm -f *.OLD *.publish |
duke@435 | 59 | |
duke@435 | 60 | # Remove all scrap files and all generated files |
duke@435 | 61 | pure:: clean |
duke@435 | 62 | -@rm -f *.OLD *.publish |
duke@435 | 63 | |
duke@435 | 64 | $(DEFAULTACTIONS) $(ACTIONS):: |
duke@435 | 65 | !ifdef SUBDIRS |
duke@435 | 66 | @$(MAKE) -nologo ACTION=$@ DIR=$(DIR) |
duke@435 | 67 | !endif |
duke@435 | 68 | |
duke@435 | 69 | FORCE: |
duke@435 | 70 | |
duke@435 | 71 |