Mercurial > jdk8-mips64-public > hotspot / annotate
make/linux/platform_i486@2c022e432e10 (annotated)
make/linux/platform_i486
Fri, 20 Sep 2013 10:53:28 +0200
- author
- stefank
- date
- Fri, 20 Sep 2013 10:53:28 +0200
- changeset 5769
- 2c022e432e10
- parent 545
- a49a647afe9a
- child 6876
- 710a3c8b516e
- permissions
- -rw-r--r--
8024974: Incorrect use of GC_locker::is_active()
Summary: SymbolTable and StringTable can make calls to GC_locker::is_active() outside a safepoint. This isn't safe because the GC_locker active state (lock count) is only updated at a safepoint and only remains valid as long as _needs_gc is true. However, outside a safepoint_needs_gc can change to false at any time, which makes it impossible to do a correct call to is_active() in that context. In this case these calls can just be removed since the input argument to basic_add() should never be on the heap and so there's no need to check the GC_locker state. This change also adjusts the assert() in is_active() to makes sure all calls to this function are always done under a safepoint.
Reviewed-by: brutisso, dcubed
Contributed-by: per.liden@oracle.com
| duke@435 | 1 | os_family = linux |
| duke@435 | 2 | |
| duke@435 | 3 | arch = x86 |
| duke@435 | 4 | |
| duke@435 | 5 | arch_model = x86_32 |
| duke@435 | 6 | |
| duke@435 | 7 | os_arch = linux_x86 |
| duke@435 | 8 | |
| duke@435 | 9 | os_arch_model = linux_x86_32 |
| duke@435 | 10 | |
| duke@435 | 11 | lib_arch = i386 |
| duke@435 | 12 | |
| duke@435 | 13 | compiler = gcc |
| duke@435 | 14 | |
| duke@435 | 15 | sysdefs = -DLINUX -D_GNU_SOURCE -DIA32 |
