Wed, 28 Aug 2013 11:22:43 +0200
8023597: Optimize G1 barriers code for unsafe load_store
Summary: Avoid loading old values in G1 pre-barriers for inlined unsafe load_store nodes.
Reviewed-by: kvn, tonyp
Contributed-by: Martin Doerr <martin.doerr@sap.com>
never@1515 | 1 | /* |
kvn@3760 | 2 | * Copyright (c) 2009, 2012, Oracle and/or its affiliates. All rights reserved. |
never@1515 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
never@1515 | 4 | * |
never@1515 | 5 | * This code is free software; you can redistribute it and/or modify it |
never@1515 | 6 | * under the terms of the GNU General Public License version 2 only, as |
never@1515 | 7 | * published by the Free Software Foundation. |
never@1515 | 8 | * |
never@1515 | 9 | * This code is distributed in the hope that it will be useful, but WITHOUT |
never@1515 | 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
never@1515 | 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
never@1515 | 12 | * version 2 for more details (a copy is included in the LICENSE file that |
never@1515 | 13 | * accompanied this code). |
never@1515 | 14 | * |
never@1515 | 15 | * You should have received a copy of the GNU General Public License version |
never@1515 | 16 | * 2 along with this work; if not, write to the Free Software Foundation, |
never@1515 | 17 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
never@1515 | 18 | * |
trims@1907 | 19 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
trims@1907 | 20 | * or visit www.oracle.com if you need additional information or have any |
trims@1907 | 21 | * questions. |
never@1515 | 22 | * |
never@1515 | 23 | */ |
never@1515 | 24 | |
stefank@2314 | 25 | #include "precompiled.hpp" |
stefank@2314 | 26 | #include "compiler/compileLog.hpp" |
stefank@2314 | 27 | #include "opto/addnode.hpp" |
stefank@2314 | 28 | #include "opto/callGenerator.hpp" |
stefank@2314 | 29 | #include "opto/callnode.hpp" |
stefank@2314 | 30 | #include "opto/divnode.hpp" |
stefank@2314 | 31 | #include "opto/graphKit.hpp" |
stefank@2314 | 32 | #include "opto/idealKit.hpp" |
stefank@2314 | 33 | #include "opto/rootnode.hpp" |
stefank@2314 | 34 | #include "opto/runtime.hpp" |
stefank@2314 | 35 | #include "opto/stringopts.hpp" |
stefank@2314 | 36 | #include "opto/subnode.hpp" |
never@1515 | 37 | |
never@1515 | 38 | #define __ kit. |
never@1515 | 39 | |
never@1515 | 40 | class StringConcat : public ResourceObj { |
never@1515 | 41 | private: |
never@1515 | 42 | PhaseStringOpts* _stringopts; |
never@1515 | 43 | Node* _string_alloc; |
never@1515 | 44 | AllocateNode* _begin; // The allocation the begins the pattern |
never@1515 | 45 | CallStaticJavaNode* _end; // The final call of the pattern. Will either be |
never@1515 | 46 | // SB.toString or or String.<init>(SB.toString) |
never@1515 | 47 | bool _multiple; // indicates this is a fusion of two or more |
never@1515 | 48 | // separate StringBuilders |
never@1515 | 49 | |
never@1515 | 50 | Node* _arguments; // The list of arguments to be concatenated |
never@1515 | 51 | GrowableArray<int> _mode; // into a String along with a mode flag |
never@1515 | 52 | // indicating how to treat the value. |
never@1515 | 53 | |
never@1515 | 54 | Node_List _control; // List of control nodes that will be deleted |
never@1515 | 55 | Node_List _uncommon_traps; // Uncommon traps that needs to be rewritten |
never@1515 | 56 | // to restart at the initial JVMState. |
never@1515 | 57 | public: |
never@1515 | 58 | // Mode for converting arguments to Strings |
never@1515 | 59 | enum { |
never@1515 | 60 | StringMode, |
never@1515 | 61 | IntMode, |
kvn@2413 | 62 | CharMode, |
kvn@2413 | 63 | StringNullCheckMode |
never@1515 | 64 | }; |
never@1515 | 65 | |
never@1515 | 66 | StringConcat(PhaseStringOpts* stringopts, CallStaticJavaNode* end): |
never@1515 | 67 | _end(end), |
never@1515 | 68 | _begin(NULL), |
never@1515 | 69 | _multiple(false), |
never@1515 | 70 | _string_alloc(NULL), |
never@1515 | 71 | _stringopts(stringopts) { |
kvn@4115 | 72 | _arguments = new (_stringopts->C) Node(1); |
never@1515 | 73 | _arguments->del_req(0); |
never@1515 | 74 | } |
never@1515 | 75 | |
never@1515 | 76 | bool validate_control_flow(); |
never@1515 | 77 | |
never@1515 | 78 | void merge_add() { |
never@1515 | 79 | #if 0 |
never@1515 | 80 | // XXX This is place holder code for reusing an existing String |
never@1515 | 81 | // allocation but the logic for checking the state safety is |
never@1515 | 82 | // probably inadequate at the moment. |
never@1515 | 83 | CallProjections endprojs; |
never@1515 | 84 | sc->end()->extract_projections(&endprojs, false); |
never@1515 | 85 | if (endprojs.resproj != NULL) { |
never@1515 | 86 | for (SimpleDUIterator i(endprojs.resproj); i.has_next(); i.next()) { |
never@1515 | 87 | CallStaticJavaNode *use = i.get()->isa_CallStaticJava(); |
never@1515 | 88 | if (use != NULL && use->method() != NULL && |
never@2172 | 89 | use->method()->intrinsic_id() == vmIntrinsics::_String_String && |
never@1515 | 90 | use->in(TypeFunc::Parms + 1) == endprojs.resproj) { |
never@1515 | 91 | // Found useless new String(sb.toString()) so reuse the newly allocated String |
never@1515 | 92 | // when creating the result instead of allocating a new one. |
never@1515 | 93 | sc->set_string_alloc(use->in(TypeFunc::Parms)); |
never@1515 | 94 | sc->set_end(use); |
never@1515 | 95 | } |
never@1515 | 96 | } |
never@1515 | 97 | } |
never@1515 | 98 | #endif |
never@1515 | 99 | } |
never@1515 | 100 | |
never@1515 | 101 | StringConcat* merge(StringConcat* other, Node* arg); |
never@1515 | 102 | |
never@1515 | 103 | void set_allocation(AllocateNode* alloc) { |
never@1515 | 104 | _begin = alloc; |
never@1515 | 105 | } |
never@1515 | 106 | |
never@1515 | 107 | void append(Node* value, int mode) { |
never@1515 | 108 | _arguments->add_req(value); |
never@1515 | 109 | _mode.append(mode); |
never@1515 | 110 | } |
never@1515 | 111 | void push(Node* value, int mode) { |
never@1515 | 112 | _arguments->ins_req(0, value); |
never@1515 | 113 | _mode.insert_before(0, mode); |
never@1515 | 114 | } |
kvn@3889 | 115 | |
never@1515 | 116 | void push_string(Node* value) { |
never@1515 | 117 | push(value, StringMode); |
never@1515 | 118 | } |
kvn@2413 | 119 | void push_string_null_check(Node* value) { |
kvn@2413 | 120 | push(value, StringNullCheckMode); |
kvn@2413 | 121 | } |
never@1515 | 122 | void push_int(Node* value) { |
never@1515 | 123 | push(value, IntMode); |
never@1515 | 124 | } |
never@1515 | 125 | void push_char(Node* value) { |
never@1515 | 126 | push(value, CharMode); |
never@1515 | 127 | } |
never@1515 | 128 | |
kvn@3889 | 129 | static bool is_SB_toString(Node* call) { |
kvn@3889 | 130 | if (call->is_CallStaticJava()) { |
kvn@3889 | 131 | CallStaticJavaNode* csj = call->as_CallStaticJava(); |
kvn@3889 | 132 | ciMethod* m = csj->method(); |
kvn@3889 | 133 | if (m != NULL && |
kvn@3889 | 134 | (m->intrinsic_id() == vmIntrinsics::_StringBuilder_toString || |
kvn@3889 | 135 | m->intrinsic_id() == vmIntrinsics::_StringBuffer_toString)) { |
kvn@3889 | 136 | return true; |
kvn@3889 | 137 | } |
kvn@3889 | 138 | } |
kvn@3889 | 139 | return false; |
kvn@3889 | 140 | } |
kvn@3889 | 141 | |
kvn@3889 | 142 | static Node* skip_string_null_check(Node* value) { |
kvn@3889 | 143 | // Look for a diamond shaped Null check of toString() result |
kvn@3889 | 144 | // (could be code from String.valueOf()): |
kvn@3889 | 145 | // (Proj == NULL) ? "null":"CastPP(Proj)#NotNULL |
kvn@3889 | 146 | if (value->is_Phi()) { |
kvn@3889 | 147 | int true_path = value->as_Phi()->is_diamond_phi(); |
kvn@3889 | 148 | if (true_path != 0) { |
kvn@3889 | 149 | // phi->region->if_proj->ifnode->bool |
kvn@3889 | 150 | BoolNode* b = value->in(0)->in(1)->in(0)->in(1)->as_Bool(); |
kvn@3889 | 151 | Node* cmp = b->in(1); |
kvn@3889 | 152 | Node* v1 = cmp->in(1); |
kvn@3889 | 153 | Node* v2 = cmp->in(2); |
kvn@3889 | 154 | // Null check of the return of toString which can simply be skipped. |
kvn@3889 | 155 | if (b->_test._test == BoolTest::ne && |
kvn@3889 | 156 | v2->bottom_type() == TypePtr::NULL_PTR && |
kvn@3889 | 157 | value->in(true_path)->Opcode() == Op_CastPP && |
kvn@3889 | 158 | value->in(true_path)->in(1) == v1 && |
kvn@3889 | 159 | v1->is_Proj() && is_SB_toString(v1->in(0))) { |
kvn@3889 | 160 | return v1; |
kvn@3889 | 161 | } |
kvn@3889 | 162 | } |
kvn@3889 | 163 | } |
kvn@3889 | 164 | return value; |
kvn@3889 | 165 | } |
kvn@3889 | 166 | |
never@1515 | 167 | Node* argument(int i) { |
never@1515 | 168 | return _arguments->in(i); |
never@1515 | 169 | } |
kvn@3889 | 170 | Node* argument_uncast(int i) { |
kvn@3889 | 171 | Node* arg = argument(i); |
kvn@3889 | 172 | int amode = mode(i); |
kvn@3889 | 173 | if (amode == StringConcat::StringMode || |
kvn@3889 | 174 | amode == StringConcat::StringNullCheckMode) { |
kvn@3889 | 175 | arg = skip_string_null_check(arg); |
kvn@3889 | 176 | } |
kvn@3889 | 177 | return arg; |
kvn@3889 | 178 | } |
never@1515 | 179 | void set_argument(int i, Node* value) { |
never@1515 | 180 | _arguments->set_req(i, value); |
never@1515 | 181 | } |
never@1515 | 182 | int num_arguments() { |
never@1515 | 183 | return _mode.length(); |
never@1515 | 184 | } |
never@1515 | 185 | int mode(int i) { |
never@1515 | 186 | return _mode.at(i); |
never@1515 | 187 | } |
never@1515 | 188 | void add_control(Node* ctrl) { |
never@1515 | 189 | assert(!_control.contains(ctrl), "only push once"); |
never@1515 | 190 | _control.push(ctrl); |
never@1515 | 191 | } |
never@1515 | 192 | CallStaticJavaNode* end() { return _end; } |
never@1515 | 193 | AllocateNode* begin() { return _begin; } |
never@1515 | 194 | Node* string_alloc() { return _string_alloc; } |
never@1515 | 195 | |
never@1515 | 196 | void eliminate_unneeded_control(); |
never@1515 | 197 | void eliminate_initialize(InitializeNode* init); |
never@1515 | 198 | void eliminate_call(CallNode* call); |
never@1515 | 199 | |
never@1515 | 200 | void maybe_log_transform() { |
never@1515 | 201 | CompileLog* log = _stringopts->C->log(); |
never@1515 | 202 | if (log != NULL) { |
never@1515 | 203 | log->head("replace_string_concat arguments='%d' string_alloc='%d' multiple='%d'", |
never@1515 | 204 | num_arguments(), |
never@1515 | 205 | _string_alloc != NULL, |
never@1515 | 206 | _multiple); |
never@1515 | 207 | JVMState* p = _begin->jvms(); |
never@1515 | 208 | while (p != NULL) { |
never@1515 | 209 | log->elem("jvms bci='%d' method='%d'", p->bci(), log->identify(p->method())); |
never@1515 | 210 | p = p->caller(); |
never@1515 | 211 | } |
never@1515 | 212 | log->tail("replace_string_concat"); |
never@1515 | 213 | } |
never@1515 | 214 | } |
never@1515 | 215 | |
never@1515 | 216 | void convert_uncommon_traps(GraphKit& kit, const JVMState* jvms) { |
never@1515 | 217 | for (uint u = 0; u < _uncommon_traps.size(); u++) { |
never@1515 | 218 | Node* uct = _uncommon_traps.at(u); |
never@1515 | 219 | |
never@1515 | 220 | // Build a new call using the jvms state of the allocate |
twisti@2103 | 221 | address call_addr = SharedRuntime::uncommon_trap_blob()->entry_point(); |
never@1515 | 222 | const TypeFunc* call_type = OptoRuntime::uncommon_trap_Type(); |
never@1515 | 223 | const TypePtr* no_memory_effects = NULL; |
never@1515 | 224 | Compile* C = _stringopts->C; |
kvn@4115 | 225 | CallStaticJavaNode* call = new (C) CallStaticJavaNode(call_type, call_addr, "uncommon_trap", |
kvn@4115 | 226 | jvms->bci(), no_memory_effects); |
never@1515 | 227 | for (int e = 0; e < TypeFunc::Parms; e++) { |
never@1515 | 228 | call->init_req(e, uct->in(e)); |
never@1515 | 229 | } |
never@1515 | 230 | // Set the trap request to record intrinsic failure if this trap |
never@1515 | 231 | // is taken too many times. Ideally we would handle then traps by |
never@1515 | 232 | // doing the original bookkeeping in the MDO so that if it caused |
never@1515 | 233 | // the code to be thrown out we could still recompile and use the |
never@1515 | 234 | // optimization. Failing the uncommon traps doesn't really mean |
never@1515 | 235 | // that the optimization is a bad idea but there's no other way to |
never@1515 | 236 | // do the MDO updates currently. |
never@1515 | 237 | int trap_request = Deoptimization::make_trap_request(Deoptimization::Reason_intrinsic, |
never@1515 | 238 | Deoptimization::Action_make_not_entrant); |
never@1515 | 239 | call->init_req(TypeFunc::Parms, __ intcon(trap_request)); |
never@1515 | 240 | kit.add_safepoint_edges(call); |
never@1515 | 241 | |
never@1515 | 242 | _stringopts->gvn()->transform(call); |
never@1515 | 243 | C->gvn_replace_by(uct, call); |
bharadwaj@4315 | 244 | uct->disconnect_inputs(NULL, C); |
never@1515 | 245 | } |
never@1515 | 246 | } |
never@1515 | 247 | |
never@1515 | 248 | void cleanup() { |
never@1515 | 249 | // disconnect the hook node |
bharadwaj@4315 | 250 | _arguments->disconnect_inputs(NULL, _stringopts->C); |
never@1515 | 251 | } |
never@1515 | 252 | }; |
never@1515 | 253 | |
never@1515 | 254 | |
never@1515 | 255 | void StringConcat::eliminate_unneeded_control() { |
never@1515 | 256 | for (uint i = 0; i < _control.size(); i++) { |
never@1515 | 257 | Node* n = _control.at(i); |
kvn@3889 | 258 | if (n->is_Allocate()) { |
kvn@3889 | 259 | eliminate_initialize(n->as_Allocate()->initialization()); |
kvn@3889 | 260 | } |
never@1515 | 261 | if (n->is_Call()) { |
never@1515 | 262 | if (n != _end) { |
never@1515 | 263 | eliminate_call(n->as_Call()); |
never@1515 | 264 | } |
never@1515 | 265 | } else if (n->is_IfTrue()) { |
never@1515 | 266 | Compile* C = _stringopts->C; |
never@1515 | 267 | C->gvn_replace_by(n, n->in(0)->in(0)); |
roland@4409 | 268 | // get rid of the other projection |
roland@4409 | 269 | C->gvn_replace_by(n->in(0)->as_If()->proj_out(false), C->top()); |
never@1515 | 270 | } |
never@1515 | 271 | } |
never@1515 | 272 | } |
never@1515 | 273 | |
never@1515 | 274 | |
never@1515 | 275 | StringConcat* StringConcat::merge(StringConcat* other, Node* arg) { |
never@1515 | 276 | StringConcat* result = new StringConcat(_stringopts, _end); |
never@1515 | 277 | for (uint x = 0; x < _control.size(); x++) { |
never@1515 | 278 | Node* n = _control.at(x); |
never@1515 | 279 | if (n->is_Call()) { |
never@1515 | 280 | result->_control.push(n); |
never@1515 | 281 | } |
never@1515 | 282 | } |
never@1515 | 283 | for (uint x = 0; x < other->_control.size(); x++) { |
never@1515 | 284 | Node* n = other->_control.at(x); |
never@1515 | 285 | if (n->is_Call()) { |
never@1515 | 286 | result->_control.push(n); |
never@1515 | 287 | } |
never@1515 | 288 | } |
never@1515 | 289 | assert(result->_control.contains(other->_end), "what?"); |
never@1515 | 290 | assert(result->_control.contains(_begin), "what?"); |
never@1515 | 291 | for (int x = 0; x < num_arguments(); x++) { |
kvn@3889 | 292 | Node* argx = argument_uncast(x); |
kvn@3889 | 293 | if (argx == arg) { |
never@1515 | 294 | // replace the toString result with the all the arguments that |
never@1515 | 295 | // made up the other StringConcat |
never@1515 | 296 | for (int y = 0; y < other->num_arguments(); y++) { |
never@1515 | 297 | result->append(other->argument(y), other->mode(y)); |
never@1515 | 298 | } |
never@1515 | 299 | } else { |
kvn@3889 | 300 | result->append(argx, mode(x)); |
never@1515 | 301 | } |
never@1515 | 302 | } |
never@1515 | 303 | result->set_allocation(other->_begin); |
never@1515 | 304 | result->_multiple = true; |
never@1515 | 305 | return result; |
never@1515 | 306 | } |
never@1515 | 307 | |
never@1515 | 308 | |
never@1515 | 309 | void StringConcat::eliminate_call(CallNode* call) { |
never@1515 | 310 | Compile* C = _stringopts->C; |
never@1515 | 311 | CallProjections projs; |
never@1515 | 312 | call->extract_projections(&projs, false); |
never@1515 | 313 | if (projs.fallthrough_catchproj != NULL) { |
never@1515 | 314 | C->gvn_replace_by(projs.fallthrough_catchproj, call->in(TypeFunc::Control)); |
never@1515 | 315 | } |
never@1515 | 316 | if (projs.fallthrough_memproj != NULL) { |
never@1515 | 317 | C->gvn_replace_by(projs.fallthrough_memproj, call->in(TypeFunc::Memory)); |
never@1515 | 318 | } |
never@1515 | 319 | if (projs.catchall_memproj != NULL) { |
never@1515 | 320 | C->gvn_replace_by(projs.catchall_memproj, C->top()); |
never@1515 | 321 | } |
never@1515 | 322 | if (projs.fallthrough_ioproj != NULL) { |
never@1515 | 323 | C->gvn_replace_by(projs.fallthrough_ioproj, call->in(TypeFunc::I_O)); |
never@1515 | 324 | } |
never@1515 | 325 | if (projs.catchall_ioproj != NULL) { |
never@1515 | 326 | C->gvn_replace_by(projs.catchall_ioproj, C->top()); |
never@1515 | 327 | } |
never@1515 | 328 | if (projs.catchall_catchproj != NULL) { |
never@1515 | 329 | // EA can't cope with the partially collapsed graph this |
never@1515 | 330 | // creates so put it on the worklist to be collapsed later. |
never@1515 | 331 | for (SimpleDUIterator i(projs.catchall_catchproj); i.has_next(); i.next()) { |
never@1515 | 332 | Node *use = i.get(); |
never@1515 | 333 | int opc = use->Opcode(); |
never@1515 | 334 | if (opc == Op_CreateEx || opc == Op_Region) { |
never@1515 | 335 | _stringopts->record_dead_node(use); |
never@1515 | 336 | } |
never@1515 | 337 | } |
never@1515 | 338 | C->gvn_replace_by(projs.catchall_catchproj, C->top()); |
never@1515 | 339 | } |
never@1515 | 340 | if (projs.resproj != NULL) { |
never@1515 | 341 | C->gvn_replace_by(projs.resproj, C->top()); |
never@1515 | 342 | } |
never@1515 | 343 | C->gvn_replace_by(call, C->top()); |
never@1515 | 344 | } |
never@1515 | 345 | |
never@1515 | 346 | void StringConcat::eliminate_initialize(InitializeNode* init) { |
never@1515 | 347 | Compile* C = _stringopts->C; |
never@1515 | 348 | |
never@1515 | 349 | // Eliminate Initialize node. |
never@1515 | 350 | assert(init->outcnt() <= 2, "only a control and memory projection expected"); |
never@1515 | 351 | assert(init->req() <= InitializeNode::RawStores, "no pending inits"); |
never@1515 | 352 | Node *ctrl_proj = init->proj_out(TypeFunc::Control); |
never@1515 | 353 | if (ctrl_proj != NULL) { |
never@1515 | 354 | C->gvn_replace_by(ctrl_proj, init->in(TypeFunc::Control)); |
never@1515 | 355 | } |
never@1515 | 356 | Node *mem_proj = init->proj_out(TypeFunc::Memory); |
never@1515 | 357 | if (mem_proj != NULL) { |
never@1515 | 358 | Node *mem = init->in(TypeFunc::Memory); |
never@1515 | 359 | C->gvn_replace_by(mem_proj, mem); |
never@1515 | 360 | } |
never@1515 | 361 | C->gvn_replace_by(init, C->top()); |
bharadwaj@4315 | 362 | init->disconnect_inputs(NULL, C); |
never@1515 | 363 | } |
never@1515 | 364 | |
never@1515 | 365 | Node_List PhaseStringOpts::collect_toString_calls() { |
never@1515 | 366 | Node_List string_calls; |
never@1515 | 367 | Node_List worklist; |
never@1515 | 368 | |
never@1515 | 369 | _visited.Clear(); |
never@1515 | 370 | |
never@1515 | 371 | // Prime the worklist |
never@1515 | 372 | for (uint i = 1; i < C->root()->len(); i++) { |
never@1515 | 373 | Node* n = C->root()->in(i); |
never@1515 | 374 | if (n != NULL && !_visited.test_set(n->_idx)) { |
never@1515 | 375 | worklist.push(n); |
never@1515 | 376 | } |
never@1515 | 377 | } |
never@1515 | 378 | |
never@1515 | 379 | while (worklist.size() > 0) { |
never@1515 | 380 | Node* ctrl = worklist.pop(); |
kvn@3889 | 381 | if (StringConcat::is_SB_toString(ctrl)) { |
never@1515 | 382 | CallStaticJavaNode* csj = ctrl->as_CallStaticJava(); |
kvn@3889 | 383 | string_calls.push(csj); |
never@1515 | 384 | } |
never@1515 | 385 | if (ctrl->in(0) != NULL && !_visited.test_set(ctrl->in(0)->_idx)) { |
never@1515 | 386 | worklist.push(ctrl->in(0)); |
never@1515 | 387 | } |
never@1515 | 388 | if (ctrl->is_Region()) { |
never@1515 | 389 | for (uint i = 1; i < ctrl->len(); i++) { |
never@1515 | 390 | if (ctrl->in(i) != NULL && !_visited.test_set(ctrl->in(i)->_idx)) { |
never@1515 | 391 | worklist.push(ctrl->in(i)); |
never@1515 | 392 | } |
never@1515 | 393 | } |
never@1515 | 394 | } |
never@1515 | 395 | } |
never@1515 | 396 | return string_calls; |
never@1515 | 397 | } |
never@1515 | 398 | |
never@1515 | 399 | |
never@1515 | 400 | StringConcat* PhaseStringOpts::build_candidate(CallStaticJavaNode* call) { |
never@1515 | 401 | ciMethod* m = call->method(); |
never@1515 | 402 | ciSymbol* string_sig; |
never@1515 | 403 | ciSymbol* int_sig; |
never@1515 | 404 | ciSymbol* char_sig; |
never@1515 | 405 | if (m->holder() == C->env()->StringBuilder_klass()) { |
never@1515 | 406 | string_sig = ciSymbol::String_StringBuilder_signature(); |
never@1515 | 407 | int_sig = ciSymbol::int_StringBuilder_signature(); |
never@1515 | 408 | char_sig = ciSymbol::char_StringBuilder_signature(); |
never@1515 | 409 | } else if (m->holder() == C->env()->StringBuffer_klass()) { |
never@1515 | 410 | string_sig = ciSymbol::String_StringBuffer_signature(); |
never@1515 | 411 | int_sig = ciSymbol::int_StringBuffer_signature(); |
never@1515 | 412 | char_sig = ciSymbol::char_StringBuffer_signature(); |
never@1515 | 413 | } else { |
never@1515 | 414 | return NULL; |
never@1515 | 415 | } |
never@1515 | 416 | #ifndef PRODUCT |
never@1515 | 417 | if (PrintOptimizeStringConcat) { |
never@1515 | 418 | tty->print("considering toString call in "); |
never@1515 | 419 | call->jvms()->dump_spec(tty); tty->cr(); |
never@1515 | 420 | } |
never@1515 | 421 | #endif |
never@1515 | 422 | |
never@1515 | 423 | StringConcat* sc = new StringConcat(this, call); |
never@1515 | 424 | |
never@1515 | 425 | AllocateNode* alloc = NULL; |
never@1515 | 426 | InitializeNode* init = NULL; |
never@1515 | 427 | |
never@1515 | 428 | // possible opportunity for StringBuilder fusion |
never@1515 | 429 | CallStaticJavaNode* cnode = call; |
never@1515 | 430 | while (cnode) { |
never@1515 | 431 | Node* recv = cnode->in(TypeFunc::Parms)->uncast(); |
never@1515 | 432 | if (recv->is_Proj()) { |
never@1515 | 433 | recv = recv->in(0); |
never@1515 | 434 | } |
never@1515 | 435 | cnode = recv->isa_CallStaticJava(); |
never@1515 | 436 | if (cnode == NULL) { |
never@1515 | 437 | alloc = recv->isa_Allocate(); |
never@1515 | 438 | if (alloc == NULL) { |
never@1515 | 439 | break; |
never@1515 | 440 | } |
never@1515 | 441 | // Find the constructor call |
never@1515 | 442 | Node* result = alloc->result_cast(); |
roland@4409 | 443 | if (result == NULL || !result->is_CheckCastPP() || alloc->in(TypeFunc::Memory)->is_top()) { |
never@1515 | 444 | // strange looking allocation |
never@1515 | 445 | #ifndef PRODUCT |
never@1515 | 446 | if (PrintOptimizeStringConcat) { |
never@1515 | 447 | tty->print("giving up because allocation looks strange "); |
never@1515 | 448 | alloc->jvms()->dump_spec(tty); tty->cr(); |
never@1515 | 449 | } |
never@1515 | 450 | #endif |
never@1515 | 451 | break; |
never@1515 | 452 | } |
never@1515 | 453 | Node* constructor = NULL; |
never@1515 | 454 | for (SimpleDUIterator i(result); i.has_next(); i.next()) { |
never@1515 | 455 | CallStaticJavaNode *use = i.get()->isa_CallStaticJava(); |
never@2172 | 456 | if (use != NULL && |
never@2172 | 457 | use->method() != NULL && |
never@2172 | 458 | !use->method()->is_static() && |
never@1515 | 459 | use->method()->name() == ciSymbol::object_initializer_name() && |
never@1515 | 460 | use->method()->holder() == m->holder()) { |
never@1515 | 461 | // Matched the constructor. |
never@1515 | 462 | ciSymbol* sig = use->method()->signature()->as_symbol(); |
never@1515 | 463 | if (sig == ciSymbol::void_method_signature() || |
never@1515 | 464 | sig == ciSymbol::int_void_signature() || |
never@1515 | 465 | sig == ciSymbol::string_void_signature()) { |
never@1515 | 466 | if (sig == ciSymbol::string_void_signature()) { |
never@1515 | 467 | // StringBuilder(String) so pick this up as the first argument |
never@1515 | 468 | assert(use->in(TypeFunc::Parms + 1) != NULL, "what?"); |
kvn@2413 | 469 | const Type* type = _gvn->type(use->in(TypeFunc::Parms + 1)); |
kvn@2413 | 470 | if (type == TypePtr::NULL_PTR) { |
kvn@2413 | 471 | // StringBuilder(null) throws exception. |
kvn@2413 | 472 | #ifndef PRODUCT |
kvn@2413 | 473 | if (PrintOptimizeStringConcat) { |
kvn@2413 | 474 | tty->print("giving up because StringBuilder(null) throws exception"); |
kvn@2413 | 475 | alloc->jvms()->dump_spec(tty); tty->cr(); |
kvn@2413 | 476 | } |
kvn@2413 | 477 | #endif |
kvn@2413 | 478 | return NULL; |
kvn@2413 | 479 | } |
kvn@2413 | 480 | // StringBuilder(str) argument needs null check. |
kvn@2413 | 481 | sc->push_string_null_check(use->in(TypeFunc::Parms + 1)); |
never@1515 | 482 | } |
never@1515 | 483 | // The int variant takes an initial size for the backing |
never@1515 | 484 | // array so just treat it like the void version. |
never@1515 | 485 | constructor = use; |
never@1515 | 486 | } else { |
never@1515 | 487 | #ifndef PRODUCT |
never@1515 | 488 | if (PrintOptimizeStringConcat) { |
never@1515 | 489 | tty->print("unexpected constructor signature: %s", sig->as_utf8()); |
never@1515 | 490 | } |
never@1515 | 491 | #endif |
never@1515 | 492 | } |
never@1515 | 493 | break; |
never@1515 | 494 | } |
never@1515 | 495 | } |
never@1515 | 496 | if (constructor == NULL) { |
never@1515 | 497 | // couldn't find constructor |
never@1515 | 498 | #ifndef PRODUCT |
never@1515 | 499 | if (PrintOptimizeStringConcat) { |
never@1515 | 500 | tty->print("giving up because couldn't find constructor "); |
kvn@2413 | 501 | alloc->jvms()->dump_spec(tty); tty->cr(); |
never@1515 | 502 | } |
never@1515 | 503 | #endif |
never@1515 | 504 | break; |
never@1515 | 505 | } |
never@1515 | 506 | |
never@1515 | 507 | // Walked all the way back and found the constructor call so see |
never@1515 | 508 | // if this call converted into a direct string concatenation. |
never@1515 | 509 | sc->add_control(call); |
never@1515 | 510 | sc->add_control(constructor); |
never@1515 | 511 | sc->add_control(alloc); |
never@1515 | 512 | sc->set_allocation(alloc); |
never@1515 | 513 | if (sc->validate_control_flow()) { |
never@1515 | 514 | return sc; |
never@1515 | 515 | } else { |
never@1515 | 516 | return NULL; |
never@1515 | 517 | } |
never@1515 | 518 | } else if (cnode->method() == NULL) { |
never@1515 | 519 | break; |
never@2172 | 520 | } else if (!cnode->method()->is_static() && |
never@2172 | 521 | cnode->method()->holder() == m->holder() && |
never@1515 | 522 | cnode->method()->name() == ciSymbol::append_name() && |
never@1515 | 523 | (cnode->method()->signature()->as_symbol() == string_sig || |
never@1515 | 524 | cnode->method()->signature()->as_symbol() == char_sig || |
never@1515 | 525 | cnode->method()->signature()->as_symbol() == int_sig)) { |
never@1515 | 526 | sc->add_control(cnode); |
never@1515 | 527 | Node* arg = cnode->in(TypeFunc::Parms + 1); |
never@1515 | 528 | if (cnode->method()->signature()->as_symbol() == int_sig) { |
never@1515 | 529 | sc->push_int(arg); |
never@1515 | 530 | } else if (cnode->method()->signature()->as_symbol() == char_sig) { |
never@1515 | 531 | sc->push_char(arg); |
never@1515 | 532 | } else { |
never@1515 | 533 | if (arg->is_Proj() && arg->in(0)->is_CallStaticJava()) { |
never@1515 | 534 | CallStaticJavaNode* csj = arg->in(0)->as_CallStaticJava(); |
never@1515 | 535 | if (csj->method() != NULL && |
kvn@3927 | 536 | csj->method()->intrinsic_id() == vmIntrinsics::_Integer_toString && |
kvn@3927 | 537 | arg->outcnt() == 1) { |
kvn@3927 | 538 | // _control is the list of StringBuilder calls nodes which |
kvn@3927 | 539 | // will be replaced by new String code after this optimization. |
kvn@3927 | 540 | // Integer::toString() call is not part of StringBuilder calls |
kvn@3927 | 541 | // chain. It could be eliminated only if its result is used |
kvn@3927 | 542 | // only by this SB calls chain. |
kvn@3927 | 543 | // Another limitation: it should be used only once because |
kvn@3927 | 544 | // it is unknown that it is used only by this SB calls chain |
kvn@3927 | 545 | // until all related SB calls nodes are collected. |
kvn@3927 | 546 | assert(arg->unique_out() == cnode, "sanity"); |
never@1515 | 547 | sc->add_control(csj); |
never@1515 | 548 | sc->push_int(csj->in(TypeFunc::Parms)); |
never@1515 | 549 | continue; |
never@1515 | 550 | } |
never@1515 | 551 | } |
never@1515 | 552 | sc->push_string(arg); |
never@1515 | 553 | } |
never@1515 | 554 | continue; |
never@1515 | 555 | } else { |
never@1515 | 556 | // some unhandled signature |
never@1515 | 557 | #ifndef PRODUCT |
never@1515 | 558 | if (PrintOptimizeStringConcat) { |
never@1515 | 559 | tty->print("giving up because encountered unexpected signature "); |
never@1515 | 560 | cnode->tf()->dump(); tty->cr(); |
never@1515 | 561 | cnode->in(TypeFunc::Parms + 1)->dump(); |
never@1515 | 562 | } |
never@1515 | 563 | #endif |
never@1515 | 564 | break; |
never@1515 | 565 | } |
never@1515 | 566 | } |
never@1515 | 567 | return NULL; |
never@1515 | 568 | } |
never@1515 | 569 | |
never@1515 | 570 | |
never@1515 | 571 | PhaseStringOpts::PhaseStringOpts(PhaseGVN* gvn, Unique_Node_List*): |
never@1515 | 572 | Phase(StringOpts), |
never@1515 | 573 | _gvn(gvn), |
never@1515 | 574 | _visited(Thread::current()->resource_area()) { |
never@1515 | 575 | |
never@1515 | 576 | assert(OptimizeStringConcat, "shouldn't be here"); |
never@1515 | 577 | |
never@1515 | 578 | size_table_field = C->env()->Integer_klass()->get_field_by_name(ciSymbol::make("sizeTable"), |
never@1515 | 579 | ciSymbol::make("[I"), true); |
never@1515 | 580 | if (size_table_field == NULL) { |
never@1515 | 581 | // Something wrong so give up. |
never@1515 | 582 | assert(false, "why can't we find Integer.sizeTable?"); |
never@1515 | 583 | return; |
never@1515 | 584 | } |
never@1515 | 585 | |
never@1515 | 586 | // Collect the types needed to talk about the various slices of memory |
never@1515 | 587 | char_adr_idx = C->get_alias_index(TypeAryPtr::CHARS); |
never@1515 | 588 | |
never@1515 | 589 | // For each locally allocated StringBuffer see if the usages can be |
never@1515 | 590 | // collapsed into a single String construction. |
never@1515 | 591 | |
never@1515 | 592 | // Run through the list of allocation looking for SB.toString to see |
never@1515 | 593 | // if it's possible to fuse the usage of the SB into a single String |
never@1515 | 594 | // construction. |
never@1515 | 595 | GrowableArray<StringConcat*> concats; |
never@1515 | 596 | Node_List toStrings = collect_toString_calls(); |
never@1515 | 597 | while (toStrings.size() > 0) { |
never@1515 | 598 | StringConcat* sc = build_candidate(toStrings.pop()->as_CallStaticJava()); |
never@1515 | 599 | if (sc != NULL) { |
never@1515 | 600 | concats.push(sc); |
never@1515 | 601 | } |
never@1515 | 602 | } |
never@1515 | 603 | |
never@1515 | 604 | // try to coalesce separate concats |
never@1515 | 605 | restart: |
never@1515 | 606 | for (int c = 0; c < concats.length(); c++) { |
never@1515 | 607 | StringConcat* sc = concats.at(c); |
never@1515 | 608 | for (int i = 0; i < sc->num_arguments(); i++) { |
kvn@3889 | 609 | Node* arg = sc->argument_uncast(i); |
kvn@3889 | 610 | if (arg->is_Proj() && StringConcat::is_SB_toString(arg->in(0))) { |
never@1515 | 611 | CallStaticJavaNode* csj = arg->in(0)->as_CallStaticJava(); |
kvn@3889 | 612 | for (int o = 0; o < concats.length(); o++) { |
kvn@3889 | 613 | if (c == o) continue; |
kvn@3889 | 614 | StringConcat* other = concats.at(o); |
kvn@3889 | 615 | if (other->end() == csj) { |
kvn@3889 | 616 | #ifndef PRODUCT |
kvn@3889 | 617 | if (PrintOptimizeStringConcat) { |
kvn@3889 | 618 | tty->print_cr("considering stacked concats"); |
kvn@3889 | 619 | } |
kvn@3889 | 620 | #endif |
kvn@3889 | 621 | |
kvn@3889 | 622 | StringConcat* merged = sc->merge(other, arg); |
kvn@3889 | 623 | if (merged->validate_control_flow()) { |
never@1515 | 624 | #ifndef PRODUCT |
never@1515 | 625 | if (PrintOptimizeStringConcat) { |
kvn@3889 | 626 | tty->print_cr("stacking would succeed"); |
never@1515 | 627 | } |
never@1515 | 628 | #endif |
kvn@3889 | 629 | if (c < o) { |
kvn@3889 | 630 | concats.remove_at(o); |
kvn@3889 | 631 | concats.at_put(c, merged); |
kvn@3889 | 632 | } else { |
kvn@3889 | 633 | concats.remove_at(c); |
kvn@3889 | 634 | concats.at_put(o, merged); |
kvn@3889 | 635 | } |
kvn@3889 | 636 | goto restart; |
kvn@3889 | 637 | } else { |
never@1515 | 638 | #ifndef PRODUCT |
kvn@3889 | 639 | if (PrintOptimizeStringConcat) { |
kvn@3889 | 640 | tty->print_cr("stacking would fail"); |
kvn@3889 | 641 | } |
never@1515 | 642 | #endif |
never@1515 | 643 | } |
never@1515 | 644 | } |
never@1515 | 645 | } |
never@1515 | 646 | } |
never@1515 | 647 | } |
never@1515 | 648 | } |
never@1515 | 649 | |
never@1515 | 650 | |
never@1515 | 651 | for (int c = 0; c < concats.length(); c++) { |
never@1515 | 652 | StringConcat* sc = concats.at(c); |
never@1515 | 653 | replace_string_concat(sc); |
never@1515 | 654 | } |
never@1515 | 655 | |
never@1515 | 656 | remove_dead_nodes(); |
never@1515 | 657 | } |
never@1515 | 658 | |
never@1515 | 659 | void PhaseStringOpts::record_dead_node(Node* dead) { |
never@1515 | 660 | dead_worklist.push(dead); |
never@1515 | 661 | } |
never@1515 | 662 | |
never@1515 | 663 | void PhaseStringOpts::remove_dead_nodes() { |
never@1515 | 664 | // Delete any dead nodes to make things clean enough that escape |
never@1515 | 665 | // analysis doesn't get unhappy. |
never@1515 | 666 | while (dead_worklist.size() > 0) { |
never@1515 | 667 | Node* use = dead_worklist.pop(); |
never@1515 | 668 | int opc = use->Opcode(); |
never@1515 | 669 | switch (opc) { |
never@1515 | 670 | case Op_Region: { |
never@1515 | 671 | uint i = 1; |
never@1515 | 672 | for (i = 1; i < use->req(); i++) { |
never@1515 | 673 | if (use->in(i) != C->top()) { |
never@1515 | 674 | break; |
never@1515 | 675 | } |
never@1515 | 676 | } |
never@1515 | 677 | if (i >= use->req()) { |
never@1515 | 678 | for (SimpleDUIterator i(use); i.has_next(); i.next()) { |
never@1515 | 679 | Node* m = i.get(); |
never@1515 | 680 | if (m->is_Phi()) { |
never@1515 | 681 | dead_worklist.push(m); |
never@1515 | 682 | } |
never@1515 | 683 | } |
never@1515 | 684 | C->gvn_replace_by(use, C->top()); |
never@1515 | 685 | } |
never@1515 | 686 | break; |
never@1515 | 687 | } |
never@1515 | 688 | case Op_AddP: |
never@1515 | 689 | case Op_CreateEx: { |
never@1515 | 690 | // Recurisvely clean up references to CreateEx so EA doesn't |
never@1515 | 691 | // get unhappy about the partially collapsed graph. |
never@1515 | 692 | for (SimpleDUIterator i(use); i.has_next(); i.next()) { |
never@1515 | 693 | Node* m = i.get(); |
never@1515 | 694 | if (m->is_AddP()) { |
never@1515 | 695 | dead_worklist.push(m); |
never@1515 | 696 | } |
never@1515 | 697 | } |
never@1515 | 698 | C->gvn_replace_by(use, C->top()); |
never@1515 | 699 | break; |
never@1515 | 700 | } |
never@1515 | 701 | case Op_Phi: |
never@1515 | 702 | if (use->in(0) == C->top()) { |
never@1515 | 703 | C->gvn_replace_by(use, C->top()); |
never@1515 | 704 | } |
never@1515 | 705 | break; |
never@1515 | 706 | } |
never@1515 | 707 | } |
never@1515 | 708 | } |
never@1515 | 709 | |
never@1515 | 710 | |
never@1515 | 711 | bool StringConcat::validate_control_flow() { |
never@1515 | 712 | // We found all the calls and arguments now lets see if it's |
never@1515 | 713 | // safe to transform the graph as we would expect. |
never@1515 | 714 | |
never@1515 | 715 | // Check to see if this resulted in too many uncommon traps previously |
never@1515 | 716 | if (Compile::current()->too_many_traps(_begin->jvms()->method(), _begin->jvms()->bci(), |
never@1515 | 717 | Deoptimization::Reason_intrinsic)) { |
never@1515 | 718 | return false; |
never@1515 | 719 | } |
never@1515 | 720 | |
never@1515 | 721 | // Walk backwards over the control flow from toString to the |
never@1515 | 722 | // allocation and make sure all the control flow is ok. This |
never@1515 | 723 | // means it's either going to be eliminated once the calls are |
never@1515 | 724 | // removed or it can safely be transformed into an uncommon |
never@1515 | 725 | // trap. |
never@1515 | 726 | |
never@1515 | 727 | int null_check_count = 0; |
never@1515 | 728 | Unique_Node_List ctrl_path; |
never@1515 | 729 | |
never@1515 | 730 | assert(_control.contains(_begin), "missing"); |
never@1515 | 731 | assert(_control.contains(_end), "missing"); |
never@1515 | 732 | |
never@1515 | 733 | // Collect the nodes that we know about and will eliminate into ctrl_path |
never@1515 | 734 | for (uint i = 0; i < _control.size(); i++) { |
never@1515 | 735 | // Push the call and it's control projection |
never@1515 | 736 | Node* n = _control.at(i); |
never@1515 | 737 | if (n->is_Allocate()) { |
never@1515 | 738 | AllocateNode* an = n->as_Allocate(); |
never@1515 | 739 | InitializeNode* init = an->initialization(); |
never@1515 | 740 | ctrl_path.push(init); |
never@1515 | 741 | ctrl_path.push(init->as_Multi()->proj_out(0)); |
never@1515 | 742 | } |
never@1515 | 743 | if (n->is_Call()) { |
never@1515 | 744 | CallNode* cn = n->as_Call(); |
never@1515 | 745 | ctrl_path.push(cn); |
never@1515 | 746 | ctrl_path.push(cn->proj_out(0)); |
never@1515 | 747 | ctrl_path.push(cn->proj_out(0)->unique_out()); |
roland@4357 | 748 | if (cn->proj_out(0)->unique_out()->as_Catch()->proj_out(0) != NULL) { |
roland@4357 | 749 | ctrl_path.push(cn->proj_out(0)->unique_out()->as_Catch()->proj_out(0)); |
roland@4357 | 750 | } |
never@1515 | 751 | } else { |
never@1515 | 752 | ShouldNotReachHere(); |
never@1515 | 753 | } |
never@1515 | 754 | } |
never@1515 | 755 | |
never@1515 | 756 | // Skip backwards through the control checking for unexpected contro flow |
never@1515 | 757 | Node* ptr = _end; |
never@1515 | 758 | bool fail = false; |
never@1515 | 759 | while (ptr != _begin) { |
never@1515 | 760 | if (ptr->is_Call() && ctrl_path.member(ptr)) { |
never@1515 | 761 | ptr = ptr->in(0); |
never@1515 | 762 | } else if (ptr->is_CatchProj() && ctrl_path.member(ptr)) { |
never@1515 | 763 | ptr = ptr->in(0)->in(0)->in(0); |
never@1515 | 764 | assert(ctrl_path.member(ptr), "should be a known piece of control"); |
never@1515 | 765 | } else if (ptr->is_IfTrue()) { |
never@1515 | 766 | IfNode* iff = ptr->in(0)->as_If(); |
never@1515 | 767 | BoolNode* b = iff->in(1)->isa_Bool(); |
roland@4357 | 768 | |
roland@4357 | 769 | if (b == NULL) { |
roland@4357 | 770 | fail = true; |
roland@4357 | 771 | break; |
roland@4357 | 772 | } |
roland@4357 | 773 | |
never@1515 | 774 | Node* cmp = b->in(1); |
never@1515 | 775 | Node* v1 = cmp->in(1); |
never@1515 | 776 | Node* v2 = cmp->in(2); |
never@1515 | 777 | Node* otherproj = iff->proj_out(1 - ptr->as_Proj()->_con); |
never@1515 | 778 | |
never@1515 | 779 | // Null check of the return of append which can simply be eliminated |
never@1515 | 780 | if (b->_test._test == BoolTest::ne && |
never@1515 | 781 | v2->bottom_type() == TypePtr::NULL_PTR && |
never@1515 | 782 | v1->is_Proj() && ctrl_path.member(v1->in(0))) { |
never@1515 | 783 | // NULL check of the return value of the append |
never@1515 | 784 | null_check_count++; |
never@1515 | 785 | if (otherproj->outcnt() == 1) { |
never@1515 | 786 | CallStaticJavaNode* call = otherproj->unique_out()->isa_CallStaticJava(); |
never@1515 | 787 | if (call != NULL && call->_name != NULL && strcmp(call->_name, "uncommon_trap") == 0) { |
never@1515 | 788 | ctrl_path.push(call); |
never@1515 | 789 | } |
never@1515 | 790 | } |
never@1515 | 791 | _control.push(ptr); |
never@1515 | 792 | ptr = ptr->in(0)->in(0); |
never@1515 | 793 | continue; |
never@1515 | 794 | } |
never@1515 | 795 | |
never@1515 | 796 | // A test which leads to an uncommon trap which should be safe. |
never@1515 | 797 | // Later this trap will be converted into a trap that restarts |
never@1515 | 798 | // at the beginning. |
never@1515 | 799 | if (otherproj->outcnt() == 1) { |
never@1515 | 800 | CallStaticJavaNode* call = otherproj->unique_out()->isa_CallStaticJava(); |
never@1515 | 801 | if (call != NULL && call->_name != NULL && strcmp(call->_name, "uncommon_trap") == 0) { |
never@1515 | 802 | // control flow leads to uct so should be ok |
never@1515 | 803 | _uncommon_traps.push(call); |
never@1515 | 804 | ctrl_path.push(call); |
never@1515 | 805 | ptr = ptr->in(0)->in(0); |
never@1515 | 806 | continue; |
never@1515 | 807 | } |
never@1515 | 808 | } |
never@1515 | 809 | |
never@1515 | 810 | #ifndef PRODUCT |
never@1515 | 811 | // Some unexpected control flow we don't know how to handle. |
never@1515 | 812 | if (PrintOptimizeStringConcat) { |
never@1515 | 813 | tty->print_cr("failing with unknown test"); |
never@1515 | 814 | b->dump(); |
never@1515 | 815 | cmp->dump(); |
never@1515 | 816 | v1->dump(); |
never@1515 | 817 | v2->dump(); |
never@1515 | 818 | tty->cr(); |
never@1515 | 819 | } |
never@1515 | 820 | #endif |
kvn@2927 | 821 | fail = true; |
never@1515 | 822 | break; |
never@1515 | 823 | } else if (ptr->is_Proj() && ptr->in(0)->is_Initialize()) { |
never@1515 | 824 | ptr = ptr->in(0)->in(0); |
never@1515 | 825 | } else if (ptr->is_Region()) { |
never@1515 | 826 | Node* copy = ptr->as_Region()->is_copy(); |
never@1515 | 827 | if (copy != NULL) { |
never@1515 | 828 | ptr = copy; |
never@1515 | 829 | continue; |
never@1515 | 830 | } |
never@1515 | 831 | if (ptr->req() == 3 && |
never@1515 | 832 | ptr->in(1) != NULL && ptr->in(1)->is_Proj() && |
never@1515 | 833 | ptr->in(2) != NULL && ptr->in(2)->is_Proj() && |
never@1515 | 834 | ptr->in(1)->in(0) == ptr->in(2)->in(0) && |
never@1515 | 835 | ptr->in(1)->in(0) != NULL && ptr->in(1)->in(0)->is_If()) { |
never@1515 | 836 | // Simple diamond. |
never@1515 | 837 | // XXX should check for possibly merging stores. simple data merges are ok. |
roland@4409 | 838 | // The IGVN will make this simple diamond go away when it |
roland@4409 | 839 | // transforms the Region. Make sure it sees it. |
roland@4409 | 840 | Compile::current()->record_for_igvn(ptr); |
never@1515 | 841 | ptr = ptr->in(1)->in(0)->in(0); |
never@1515 | 842 | continue; |
never@1515 | 843 | } |
never@1515 | 844 | #ifndef PRODUCT |
never@1515 | 845 | if (PrintOptimizeStringConcat) { |
never@1515 | 846 | tty->print_cr("fusion would fail for region"); |
never@1515 | 847 | _begin->dump(); |
never@1515 | 848 | ptr->dump(2); |
never@1515 | 849 | } |
never@1515 | 850 | #endif |
never@1515 | 851 | fail = true; |
never@1515 | 852 | break; |
never@1515 | 853 | } else { |
never@1515 | 854 | // other unknown control |
never@1515 | 855 | if (!fail) { |
never@1515 | 856 | #ifndef PRODUCT |
never@1515 | 857 | if (PrintOptimizeStringConcat) { |
never@1515 | 858 | tty->print_cr("fusion would fail for"); |
never@1515 | 859 | _begin->dump(); |
never@1515 | 860 | } |
never@1515 | 861 | #endif |
never@1515 | 862 | fail = true; |
never@1515 | 863 | } |
never@1515 | 864 | #ifndef PRODUCT |
never@1515 | 865 | if (PrintOptimizeStringConcat) { |
never@1515 | 866 | ptr->dump(); |
never@1515 | 867 | } |
never@1515 | 868 | #endif |
never@1515 | 869 | ptr = ptr->in(0); |
never@1515 | 870 | } |
never@1515 | 871 | } |
never@1515 | 872 | #ifndef PRODUCT |
never@1515 | 873 | if (PrintOptimizeStringConcat && fail) { |
never@1515 | 874 | tty->cr(); |
never@1515 | 875 | } |
never@1515 | 876 | #endif |
never@1515 | 877 | if (fail) return !fail; |
never@1515 | 878 | |
never@1515 | 879 | // Validate that all these results produced are contained within |
never@1515 | 880 | // this cluster of objects. First collect all the results produced |
never@1515 | 881 | // by calls in the region. |
never@1515 | 882 | _stringopts->_visited.Clear(); |
never@1515 | 883 | Node_List worklist; |
never@1515 | 884 | Node* final_result = _end->proj_out(TypeFunc::Parms); |
never@1515 | 885 | for (uint i = 0; i < _control.size(); i++) { |
never@1515 | 886 | CallNode* cnode = _control.at(i)->isa_Call(); |
never@1515 | 887 | if (cnode != NULL) { |
never@1515 | 888 | _stringopts->_visited.test_set(cnode->_idx); |
never@1515 | 889 | } |
never@1515 | 890 | Node* result = cnode != NULL ? cnode->proj_out(TypeFunc::Parms) : NULL; |
never@1515 | 891 | if (result != NULL && result != final_result) { |
never@1515 | 892 | worklist.push(result); |
never@1515 | 893 | } |
never@1515 | 894 | } |
never@1515 | 895 | |
never@1515 | 896 | Node* last_result = NULL; |
never@1515 | 897 | while (worklist.size() > 0) { |
never@1515 | 898 | Node* result = worklist.pop(); |
never@1515 | 899 | if (_stringopts->_visited.test_set(result->_idx)) |
never@1515 | 900 | continue; |
never@1515 | 901 | for (SimpleDUIterator i(result); i.has_next(); i.next()) { |
never@1515 | 902 | Node *use = i.get(); |
never@1515 | 903 | if (ctrl_path.member(use)) { |
never@1515 | 904 | // already checked this |
never@1515 | 905 | continue; |
never@1515 | 906 | } |
never@1515 | 907 | int opc = use->Opcode(); |
never@1515 | 908 | if (opc == Op_CmpP || opc == Op_Node) { |
never@1515 | 909 | ctrl_path.push(use); |
never@1515 | 910 | continue; |
never@1515 | 911 | } |
never@1515 | 912 | if (opc == Op_CastPP || opc == Op_CheckCastPP) { |
never@1515 | 913 | for (SimpleDUIterator j(use); j.has_next(); j.next()) { |
never@1515 | 914 | worklist.push(j.get()); |
never@1515 | 915 | } |
never@1515 | 916 | worklist.push(use->in(1)); |
never@1515 | 917 | ctrl_path.push(use); |
never@1515 | 918 | continue; |
never@1515 | 919 | } |
never@1515 | 920 | #ifndef PRODUCT |
never@1515 | 921 | if (PrintOptimizeStringConcat) { |
never@1515 | 922 | if (result != last_result) { |
never@1515 | 923 | last_result = result; |
never@1515 | 924 | tty->print_cr("extra uses for result:"); |
never@1515 | 925 | last_result->dump(); |
never@1515 | 926 | } |
never@1515 | 927 | use->dump(); |
never@1515 | 928 | } |
never@1515 | 929 | #endif |
never@1515 | 930 | fail = true; |
never@1515 | 931 | break; |
never@1515 | 932 | } |
never@1515 | 933 | } |
never@1515 | 934 | |
never@1515 | 935 | #ifndef PRODUCT |
never@1515 | 936 | if (PrintOptimizeStringConcat && !fail) { |
never@1515 | 937 | ttyLocker ttyl; |
never@1515 | 938 | tty->cr(); |
never@1515 | 939 | tty->print("fusion would succeed (%d %d) for ", null_check_count, _uncommon_traps.size()); |
never@1515 | 940 | _begin->jvms()->dump_spec(tty); tty->cr(); |
never@1515 | 941 | for (int i = 0; i < num_arguments(); i++) { |
never@1515 | 942 | argument(i)->dump(); |
never@1515 | 943 | } |
never@1515 | 944 | _control.dump(); |
never@1515 | 945 | tty->cr(); |
never@1515 | 946 | } |
never@1515 | 947 | #endif |
never@1515 | 948 | |
never@1515 | 949 | return !fail; |
never@1515 | 950 | } |
never@1515 | 951 | |
never@1515 | 952 | Node* PhaseStringOpts::fetch_static_field(GraphKit& kit, ciField* field) { |
never@3746 | 953 | const TypeInstPtr* mirror_type = TypeInstPtr::make(field->holder()->java_mirror()); |
never@3746 | 954 | Node* klass_node = __ makecon(mirror_type); |
never@1515 | 955 | BasicType bt = field->layout_type(); |
never@1515 | 956 | ciType* field_klass = field->type(); |
never@1515 | 957 | |
never@1515 | 958 | const Type *type; |
never@1515 | 959 | if( bt == T_OBJECT ) { |
never@1515 | 960 | if (!field->type()->is_loaded()) { |
never@1515 | 961 | type = TypeInstPtr::BOTTOM; |
never@1515 | 962 | } else if (field->is_constant()) { |
never@1515 | 963 | // This can happen if the constant oop is non-perm. |
never@1515 | 964 | ciObject* con = field->constant_value().as_object(); |
never@1515 | 965 | // Do not "join" in the previous type; it doesn't add value, |
never@1515 | 966 | // and may yield a vacuous result if the field is of interface type. |
jcoomes@2661 | 967 | type = TypeOopPtr::make_from_constant(con, true)->isa_oopptr(); |
never@1515 | 968 | assert(type != NULL, "field singleton type must be consistent"); |
never@3746 | 969 | return __ makecon(type); |
never@1515 | 970 | } else { |
never@1515 | 971 | type = TypeOopPtr::make_from_klass(field_klass->as_klass()); |
never@1515 | 972 | } |
never@1515 | 973 | } else { |
never@1515 | 974 | type = Type::get_const_basic_type(bt); |
never@1515 | 975 | } |
never@1515 | 976 | |
never@1515 | 977 | return kit.make_load(NULL, kit.basic_plus_adr(klass_node, field->offset_in_bytes()), |
never@1515 | 978 | type, T_OBJECT, |
never@3746 | 979 | C->get_alias_index(mirror_type->add_offset(field->offset_in_bytes()))); |
never@1515 | 980 | } |
never@1515 | 981 | |
never@1515 | 982 | Node* PhaseStringOpts::int_stringSize(GraphKit& kit, Node* arg) { |
kvn@4115 | 983 | RegionNode *final_merge = new (C) RegionNode(3); |
never@1515 | 984 | kit.gvn().set_type(final_merge, Type::CONTROL); |
kvn@4115 | 985 | Node* final_size = new (C) PhiNode(final_merge, TypeInt::INT); |
never@1515 | 986 | kit.gvn().set_type(final_size, TypeInt::INT); |
never@1515 | 987 | |
never@1515 | 988 | IfNode* iff = kit.create_and_map_if(kit.control(), |
never@1515 | 989 | __ Bool(__ CmpI(arg, __ intcon(0x80000000)), BoolTest::ne), |
never@1515 | 990 | PROB_FAIR, COUNT_UNKNOWN); |
never@1515 | 991 | Node* is_min = __ IfFalse(iff); |
never@1515 | 992 | final_merge->init_req(1, is_min); |
never@1515 | 993 | final_size->init_req(1, __ intcon(11)); |
never@1515 | 994 | |
never@1515 | 995 | kit.set_control(__ IfTrue(iff)); |
never@1515 | 996 | if (kit.stopped()) { |
never@1515 | 997 | final_merge->init_req(2, C->top()); |
never@1515 | 998 | final_size->init_req(2, C->top()); |
never@1515 | 999 | } else { |
never@1515 | 1000 | |
never@1515 | 1001 | // int size = (i < 0) ? stringSize(-i) + 1 : stringSize(i); |
kvn@4115 | 1002 | RegionNode *r = new (C) RegionNode(3); |
never@1515 | 1003 | kit.gvn().set_type(r, Type::CONTROL); |
kvn@4115 | 1004 | Node *phi = new (C) PhiNode(r, TypeInt::INT); |
never@1515 | 1005 | kit.gvn().set_type(phi, TypeInt::INT); |
kvn@4115 | 1006 | Node *size = new (C) PhiNode(r, TypeInt::INT); |
never@1515 | 1007 | kit.gvn().set_type(size, TypeInt::INT); |
never@1515 | 1008 | Node* chk = __ CmpI(arg, __ intcon(0)); |
never@1515 | 1009 | Node* p = __ Bool(chk, BoolTest::lt); |
never@1515 | 1010 | IfNode* iff = kit.create_and_map_if(kit.control(), p, PROB_FAIR, COUNT_UNKNOWN); |
never@1515 | 1011 | Node* lessthan = __ IfTrue(iff); |
never@1515 | 1012 | Node* greaterequal = __ IfFalse(iff); |
never@1515 | 1013 | r->init_req(1, lessthan); |
never@1515 | 1014 | phi->init_req(1, __ SubI(__ intcon(0), arg)); |
never@1515 | 1015 | size->init_req(1, __ intcon(1)); |
never@1515 | 1016 | r->init_req(2, greaterequal); |
never@1515 | 1017 | phi->init_req(2, arg); |
never@1515 | 1018 | size->init_req(2, __ intcon(0)); |
never@1515 | 1019 | kit.set_control(r); |
never@1515 | 1020 | C->record_for_igvn(r); |
never@1515 | 1021 | C->record_for_igvn(phi); |
never@1515 | 1022 | C->record_for_igvn(size); |
never@1515 | 1023 | |
never@1515 | 1024 | // for (int i=0; ; i++) |
never@1515 | 1025 | // if (x <= sizeTable[i]) |
never@1515 | 1026 | // return i+1; |
kvn@2665 | 1027 | |
kvn@2665 | 1028 | // Add loop predicate first. |
kvn@2665 | 1029 | kit.add_predicate(); |
kvn@2665 | 1030 | |
kvn@4115 | 1031 | RegionNode *loop = new (C) RegionNode(3); |
never@1515 | 1032 | loop->init_req(1, kit.control()); |
never@1515 | 1033 | kit.gvn().set_type(loop, Type::CONTROL); |
never@1515 | 1034 | |
kvn@4115 | 1035 | Node *index = new (C) PhiNode(loop, TypeInt::INT); |
never@1515 | 1036 | index->init_req(1, __ intcon(0)); |
never@1515 | 1037 | kit.gvn().set_type(index, TypeInt::INT); |
never@1515 | 1038 | kit.set_control(loop); |
never@1515 | 1039 | Node* sizeTable = fetch_static_field(kit, size_table_field); |
never@1515 | 1040 | |
never@1515 | 1041 | Node* value = kit.load_array_element(NULL, sizeTable, index, TypeAryPtr::INTS); |
never@1515 | 1042 | C->record_for_igvn(value); |
never@1515 | 1043 | Node* limit = __ CmpI(phi, value); |
never@1515 | 1044 | Node* limitb = __ Bool(limit, BoolTest::le); |
never@1515 | 1045 | IfNode* iff2 = kit.create_and_map_if(kit.control(), limitb, PROB_MIN, COUNT_UNKNOWN); |
never@1515 | 1046 | Node* lessEqual = __ IfTrue(iff2); |
never@1515 | 1047 | Node* greater = __ IfFalse(iff2); |
never@1515 | 1048 | |
never@1515 | 1049 | loop->init_req(2, greater); |
never@1515 | 1050 | index->init_req(2, __ AddI(index, __ intcon(1))); |
never@1515 | 1051 | |
never@1515 | 1052 | kit.set_control(lessEqual); |
never@1515 | 1053 | C->record_for_igvn(loop); |
never@1515 | 1054 | C->record_for_igvn(index); |
never@1515 | 1055 | |
never@1515 | 1056 | final_merge->init_req(2, kit.control()); |
never@1515 | 1057 | final_size->init_req(2, __ AddI(__ AddI(index, size), __ intcon(1))); |
never@1515 | 1058 | } |
never@1515 | 1059 | |
never@1515 | 1060 | kit.set_control(final_merge); |
never@1515 | 1061 | C->record_for_igvn(final_merge); |
never@1515 | 1062 | C->record_for_igvn(final_size); |
never@1515 | 1063 | |
never@1515 | 1064 | return final_size; |
never@1515 | 1065 | } |
never@1515 | 1066 | |
never@1515 | 1067 | void PhaseStringOpts::int_getChars(GraphKit& kit, Node* arg, Node* char_array, Node* start, Node* end) { |
kvn@4115 | 1068 | RegionNode *final_merge = new (C) RegionNode(4); |
never@1515 | 1069 | kit.gvn().set_type(final_merge, Type::CONTROL); |
never@1515 | 1070 | Node *final_mem = PhiNode::make(final_merge, kit.memory(char_adr_idx), Type::MEMORY, TypeAryPtr::CHARS); |
never@1515 | 1071 | kit.gvn().set_type(final_mem, Type::MEMORY); |
never@1515 | 1072 | |
never@1515 | 1073 | // need to handle Integer.MIN_VALUE specially because negating doesn't make it positive |
never@1515 | 1074 | { |
never@1515 | 1075 | // i == MIN_VALUE |
never@1515 | 1076 | IfNode* iff = kit.create_and_map_if(kit.control(), |
never@1515 | 1077 | __ Bool(__ CmpI(arg, __ intcon(0x80000000)), BoolTest::ne), |
never@1515 | 1078 | PROB_FAIR, COUNT_UNKNOWN); |
never@1515 | 1079 | |
never@1515 | 1080 | Node* old_mem = kit.memory(char_adr_idx); |
never@1515 | 1081 | |
never@1515 | 1082 | kit.set_control(__ IfFalse(iff)); |
never@1515 | 1083 | if (kit.stopped()) { |
never@1515 | 1084 | // Statically not equal to MIN_VALUE so this path is dead |
never@1515 | 1085 | final_merge->init_req(3, kit.control()); |
never@1515 | 1086 | } else { |
never@1515 | 1087 | copy_string(kit, __ makecon(TypeInstPtr::make(C->env()->the_min_jint_string())), |
never@1515 | 1088 | char_array, start); |
never@1515 | 1089 | final_merge->init_req(3, kit.control()); |
never@1515 | 1090 | final_mem->init_req(3, kit.memory(char_adr_idx)); |
never@1515 | 1091 | } |
never@1515 | 1092 | |
never@1515 | 1093 | kit.set_control(__ IfTrue(iff)); |
never@1515 | 1094 | kit.set_memory(old_mem, char_adr_idx); |
never@1515 | 1095 | } |
never@1515 | 1096 | |
never@1515 | 1097 | |
never@1515 | 1098 | // Simplified version of Integer.getChars |
never@1515 | 1099 | |
never@1515 | 1100 | // int q, r; |
never@1515 | 1101 | // int charPos = index; |
never@1515 | 1102 | Node* charPos = end; |
never@1515 | 1103 | |
never@1515 | 1104 | // char sign = 0; |
never@1515 | 1105 | |
never@1515 | 1106 | Node* i = arg; |
never@1515 | 1107 | Node* sign = __ intcon(0); |
never@1515 | 1108 | |
never@1515 | 1109 | // if (i < 0) { |
never@1515 | 1110 | // sign = '-'; |
never@1515 | 1111 | // i = -i; |
never@1515 | 1112 | // } |
never@1515 | 1113 | { |
never@1515 | 1114 | IfNode* iff = kit.create_and_map_if(kit.control(), |
never@1515 | 1115 | __ Bool(__ CmpI(arg, __ intcon(0)), BoolTest::lt), |
never@1515 | 1116 | PROB_FAIR, COUNT_UNKNOWN); |
never@1515 | 1117 | |
kvn@4115 | 1118 | RegionNode *merge = new (C) RegionNode(3); |
never@1515 | 1119 | kit.gvn().set_type(merge, Type::CONTROL); |
kvn@4115 | 1120 | i = new (C) PhiNode(merge, TypeInt::INT); |
never@1515 | 1121 | kit.gvn().set_type(i, TypeInt::INT); |
kvn@4115 | 1122 | sign = new (C) PhiNode(merge, TypeInt::INT); |
never@1515 | 1123 | kit.gvn().set_type(sign, TypeInt::INT); |
never@1515 | 1124 | |
never@1515 | 1125 | merge->init_req(1, __ IfTrue(iff)); |
never@1515 | 1126 | i->init_req(1, __ SubI(__ intcon(0), arg)); |
never@1515 | 1127 | sign->init_req(1, __ intcon('-')); |
never@1515 | 1128 | merge->init_req(2, __ IfFalse(iff)); |
never@1515 | 1129 | i->init_req(2, arg); |
never@1515 | 1130 | sign->init_req(2, __ intcon(0)); |
never@1515 | 1131 | |
never@1515 | 1132 | kit.set_control(merge); |
never@1515 | 1133 | |
never@1515 | 1134 | C->record_for_igvn(merge); |
never@1515 | 1135 | C->record_for_igvn(i); |
never@1515 | 1136 | C->record_for_igvn(sign); |
never@1515 | 1137 | } |
never@1515 | 1138 | |
never@1515 | 1139 | // for (;;) { |
never@1515 | 1140 | // q = i / 10; |
never@1515 | 1141 | // r = i - ((q << 3) + (q << 1)); // r = i-(q*10) ... |
never@1515 | 1142 | // buf [--charPos] = digits [r]; |
never@1515 | 1143 | // i = q; |
never@1515 | 1144 | // if (i == 0) break; |
never@1515 | 1145 | // } |
never@1515 | 1146 | |
never@1515 | 1147 | { |
kvn@2665 | 1148 | // Add loop predicate first. |
kvn@2665 | 1149 | kit.add_predicate(); |
kvn@2665 | 1150 | |
kvn@4115 | 1151 | RegionNode *head = new (C) RegionNode(3); |
never@1515 | 1152 | head->init_req(1, kit.control()); |
never@1515 | 1153 | kit.gvn().set_type(head, Type::CONTROL); |
kvn@4115 | 1154 | Node *i_phi = new (C) PhiNode(head, TypeInt::INT); |
never@1515 | 1155 | i_phi->init_req(1, i); |
never@1515 | 1156 | kit.gvn().set_type(i_phi, TypeInt::INT); |
never@1515 | 1157 | charPos = PhiNode::make(head, charPos); |
never@1515 | 1158 | kit.gvn().set_type(charPos, TypeInt::INT); |
never@1515 | 1159 | Node *mem = PhiNode::make(head, kit.memory(char_adr_idx), Type::MEMORY, TypeAryPtr::CHARS); |
never@1515 | 1160 | kit.gvn().set_type(mem, Type::MEMORY); |
never@1515 | 1161 | kit.set_control(head); |
never@1515 | 1162 | kit.set_memory(mem, char_adr_idx); |
never@1515 | 1163 | |
never@1685 | 1164 | Node* q = __ DivI(NULL, i_phi, __ intcon(10)); |
never@1515 | 1165 | Node* r = __ SubI(i_phi, __ AddI(__ LShiftI(q, __ intcon(3)), |
never@1515 | 1166 | __ LShiftI(q, __ intcon(1)))); |
never@1515 | 1167 | Node* m1 = __ SubI(charPos, __ intcon(1)); |
never@1515 | 1168 | Node* ch = __ AddI(r, __ intcon('0')); |
never@1515 | 1169 | |
never@1515 | 1170 | Node* st = __ store_to_memory(kit.control(), kit.array_element_address(char_array, m1, T_CHAR), |
never@1515 | 1171 | ch, T_CHAR, char_adr_idx); |
never@1515 | 1172 | |
never@1515 | 1173 | |
never@1515 | 1174 | IfNode* iff = kit.create_and_map_if(head, __ Bool(__ CmpI(q, __ intcon(0)), BoolTest::ne), |
never@1515 | 1175 | PROB_FAIR, COUNT_UNKNOWN); |
never@1515 | 1176 | Node* ne = __ IfTrue(iff); |
never@1515 | 1177 | Node* eq = __ IfFalse(iff); |
never@1515 | 1178 | |
never@1515 | 1179 | head->init_req(2, ne); |
never@1515 | 1180 | mem->init_req(2, st); |
never@1515 | 1181 | i_phi->init_req(2, q); |
never@1515 | 1182 | charPos->init_req(2, m1); |
never@1515 | 1183 | |
never@1515 | 1184 | charPos = m1; |
never@1515 | 1185 | |
never@1515 | 1186 | kit.set_control(eq); |
never@1515 | 1187 | kit.set_memory(st, char_adr_idx); |
never@1515 | 1188 | |
never@1515 | 1189 | C->record_for_igvn(head); |
never@1515 | 1190 | C->record_for_igvn(mem); |
never@1515 | 1191 | C->record_for_igvn(i_phi); |
never@1515 | 1192 | C->record_for_igvn(charPos); |
never@1515 | 1193 | } |
never@1515 | 1194 | |
never@1515 | 1195 | { |
never@1515 | 1196 | // if (sign != 0) { |
never@1515 | 1197 | // buf [--charPos] = sign; |
never@1515 | 1198 | // } |
never@1515 | 1199 | IfNode* iff = kit.create_and_map_if(kit.control(), |
never@1515 | 1200 | __ Bool(__ CmpI(sign, __ intcon(0)), BoolTest::ne), |
never@1515 | 1201 | PROB_FAIR, COUNT_UNKNOWN); |
never@1515 | 1202 | |
never@1515 | 1203 | final_merge->init_req(2, __ IfFalse(iff)); |
never@1515 | 1204 | final_mem->init_req(2, kit.memory(char_adr_idx)); |
never@1515 | 1205 | |
never@1515 | 1206 | kit.set_control(__ IfTrue(iff)); |
never@1515 | 1207 | if (kit.stopped()) { |
never@1515 | 1208 | final_merge->init_req(1, C->top()); |
never@1515 | 1209 | final_mem->init_req(1, C->top()); |
never@1515 | 1210 | } else { |
never@1515 | 1211 | Node* m1 = __ SubI(charPos, __ intcon(1)); |
never@1515 | 1212 | Node* st = __ store_to_memory(kit.control(), kit.array_element_address(char_array, m1, T_CHAR), |
never@1515 | 1213 | sign, T_CHAR, char_adr_idx); |
never@1515 | 1214 | |
never@1515 | 1215 | final_merge->init_req(1, kit.control()); |
never@1515 | 1216 | final_mem->init_req(1, st); |
never@1515 | 1217 | } |
never@1515 | 1218 | |
never@1515 | 1219 | kit.set_control(final_merge); |
never@1515 | 1220 | kit.set_memory(final_mem, char_adr_idx); |
never@1515 | 1221 | |
never@1515 | 1222 | C->record_for_igvn(final_merge); |
never@1515 | 1223 | C->record_for_igvn(final_mem); |
never@1515 | 1224 | } |
never@1515 | 1225 | } |
never@1515 | 1226 | |
never@1515 | 1227 | |
never@1515 | 1228 | Node* PhaseStringOpts::copy_string(GraphKit& kit, Node* str, Node* char_array, Node* start) { |
never@1515 | 1229 | Node* string = str; |
kvn@3760 | 1230 | Node* offset = kit.load_String_offset(kit.control(), string); |
kvn@3760 | 1231 | Node* count = kit.load_String_length(kit.control(), string); |
kvn@3760 | 1232 | Node* value = kit.load_String_value (kit.control(), string); |
never@1515 | 1233 | |
never@1515 | 1234 | // copy the contents |
never@1515 | 1235 | if (offset->is_Con() && count->is_Con() && value->is_Con() && count->get_int() < unroll_string_copy_length) { |
never@1515 | 1236 | // For small constant strings just emit individual stores. |
never@1515 | 1237 | // A length of 6 seems like a good space/speed tradeof. |
never@1515 | 1238 | int c = count->get_int(); |
never@1515 | 1239 | int o = offset->get_int(); |
never@1515 | 1240 | const TypeOopPtr* t = kit.gvn().type(value)->isa_oopptr(); |
never@1515 | 1241 | ciTypeArray* value_array = t->const_oop()->as_type_array(); |
never@1515 | 1242 | for (int e = 0; e < c; e++) { |
never@1515 | 1243 | __ store_to_memory(kit.control(), kit.array_element_address(char_array, start, T_CHAR), |
never@1515 | 1244 | __ intcon(value_array->char_at(o + e)), T_CHAR, char_adr_idx); |
never@1515 | 1245 | start = __ AddI(start, __ intcon(1)); |
never@1515 | 1246 | } |
never@1515 | 1247 | } else { |
never@1515 | 1248 | Node* src_ptr = kit.array_element_address(value, offset, T_CHAR); |
never@1515 | 1249 | Node* dst_ptr = kit.array_element_address(char_array, start, T_CHAR); |
never@1515 | 1250 | Node* c = count; |
never@1515 | 1251 | Node* extra = NULL; |
never@1515 | 1252 | #ifdef _LP64 |
never@1515 | 1253 | c = __ ConvI2L(c); |
never@1515 | 1254 | extra = C->top(); |
never@1515 | 1255 | #endif |
never@1515 | 1256 | Node* call = kit.make_runtime_call(GraphKit::RC_LEAF|GraphKit::RC_NO_FP, |
never@1515 | 1257 | OptoRuntime::fast_arraycopy_Type(), |
never@1515 | 1258 | CAST_FROM_FN_PTR(address, StubRoutines::jshort_disjoint_arraycopy()), |
never@1515 | 1259 | "jshort_disjoint_arraycopy", TypeAryPtr::CHARS, |
never@1515 | 1260 | src_ptr, dst_ptr, c, extra); |
never@1515 | 1261 | start = __ AddI(start, count); |
never@1515 | 1262 | } |
never@1515 | 1263 | return start; |
never@1515 | 1264 | } |
never@1515 | 1265 | |
never@1515 | 1266 | |
never@1515 | 1267 | void PhaseStringOpts::replace_string_concat(StringConcat* sc) { |
never@1515 | 1268 | // Log a little info about the transformation |
never@1515 | 1269 | sc->maybe_log_transform(); |
never@1515 | 1270 | |
never@1515 | 1271 | // pull the JVMState of the allocation into a SafePointNode to serve as |
never@1515 | 1272 | // as a shim for the insertion of the new code. |
never@1515 | 1273 | JVMState* jvms = sc->begin()->jvms()->clone_shallow(C); |
never@1515 | 1274 | uint size = sc->begin()->req(); |
kvn@4115 | 1275 | SafePointNode* map = new (C) SafePointNode(size, jvms); |
never@1515 | 1276 | |
never@1515 | 1277 | // copy the control and memory state from the final call into our |
never@1515 | 1278 | // new starting state. This allows any preceeding tests to feed |
never@1515 | 1279 | // into the new section of code. |
never@1515 | 1280 | for (uint i1 = 0; i1 < TypeFunc::Parms; i1++) { |
never@1515 | 1281 | map->init_req(i1, sc->end()->in(i1)); |
never@1515 | 1282 | } |
never@1515 | 1283 | // blow away old allocation arguments |
never@1515 | 1284 | for (uint i1 = TypeFunc::Parms; i1 < jvms->debug_start(); i1++) { |
never@1515 | 1285 | map->init_req(i1, C->top()); |
never@1515 | 1286 | } |
never@1515 | 1287 | // Copy the rest of the inputs for the JVMState |
never@1515 | 1288 | for (uint i1 = jvms->debug_start(); i1 < sc->begin()->req(); i1++) { |
never@1515 | 1289 | map->init_req(i1, sc->begin()->in(i1)); |
never@1515 | 1290 | } |
never@1515 | 1291 | // Make sure the memory state is a MergeMem for parsing. |
never@1515 | 1292 | if (!map->in(TypeFunc::Memory)->is_MergeMem()) { |
never@1515 | 1293 | map->set_req(TypeFunc::Memory, MergeMemNode::make(C, map->in(TypeFunc::Memory))); |
never@1515 | 1294 | } |
never@1515 | 1295 | |
never@1515 | 1296 | jvms->set_map(map); |
never@1515 | 1297 | map->ensure_stack(jvms, jvms->method()->max_stack()); |
never@1515 | 1298 | |
never@1515 | 1299 | |
never@1515 | 1300 | // disconnect all the old StringBuilder calls from the graph |
never@1515 | 1301 | sc->eliminate_unneeded_control(); |
never@1515 | 1302 | |
never@1515 | 1303 | // At this point all the old work has been completely removed from |
never@1515 | 1304 | // the graph and the saved JVMState exists at the point where the |
never@1515 | 1305 | // final toString call used to be. |
never@1515 | 1306 | GraphKit kit(jvms); |
never@1515 | 1307 | |
never@1515 | 1308 | // There may be uncommon traps which are still using the |
never@1515 | 1309 | // intermediate states and these need to be rewritten to point at |
never@1515 | 1310 | // the JVMState at the beginning of the transformation. |
never@1515 | 1311 | sc->convert_uncommon_traps(kit, jvms); |
never@1515 | 1312 | |
never@1515 | 1313 | // Now insert the logic to compute the size of the string followed |
never@1515 | 1314 | // by all the logic to construct array and resulting string. |
never@1515 | 1315 | |
never@1515 | 1316 | Node* null_string = __ makecon(TypeInstPtr::make(C->env()->the_null_string())); |
never@1515 | 1317 | |
never@1515 | 1318 | // Create a region for the overflow checks to merge into. |
never@1515 | 1319 | int args = MAX2(sc->num_arguments(), 1); |
kvn@4115 | 1320 | RegionNode* overflow = new (C) RegionNode(args); |
never@1515 | 1321 | kit.gvn().set_type(overflow, Type::CONTROL); |
never@1515 | 1322 | |
never@1515 | 1323 | // Create a hook node to hold onto the individual sizes since they |
never@1515 | 1324 | // are need for the copying phase. |
kvn@4115 | 1325 | Node* string_sizes = new (C) Node(args); |
never@1515 | 1326 | |
never@1515 | 1327 | Node* length = __ intcon(0); |
never@1515 | 1328 | for (int argi = 0; argi < sc->num_arguments(); argi++) { |
never@1515 | 1329 | Node* arg = sc->argument(argi); |
never@1515 | 1330 | switch (sc->mode(argi)) { |
never@1515 | 1331 | case StringConcat::IntMode: { |
never@1515 | 1332 | Node* string_size = int_stringSize(kit, arg); |
never@1515 | 1333 | |
never@1515 | 1334 | // accumulate total |
never@1515 | 1335 | length = __ AddI(length, string_size); |
never@1515 | 1336 | |
never@1515 | 1337 | // Cache this value for the use by int_toString |
never@1515 | 1338 | string_sizes->init_req(argi, string_size); |
never@1515 | 1339 | break; |
never@1515 | 1340 | } |
kvn@2413 | 1341 | case StringConcat::StringNullCheckMode: { |
kvn@2413 | 1342 | const Type* type = kit.gvn().type(arg); |
kvn@2413 | 1343 | assert(type != TypePtr::NULL_PTR, "missing check"); |
kvn@2413 | 1344 | if (!type->higher_equal(TypeInstPtr::NOTNULL)) { |
kvn@2413 | 1345 | // Null check with uncommont trap since |
kvn@2413 | 1346 | // StringBuilder(null) throws exception. |
kvn@2413 | 1347 | // Use special uncommon trap instead of |
kvn@2413 | 1348 | // calling normal do_null_check(). |
kvn@2413 | 1349 | Node* p = __ Bool(__ CmpP(arg, kit.null()), BoolTest::ne); |
kvn@2413 | 1350 | IfNode* iff = kit.create_and_map_if(kit.control(), p, PROB_MIN, COUNT_UNKNOWN); |
kvn@2413 | 1351 | overflow->add_req(__ IfFalse(iff)); |
kvn@2413 | 1352 | Node* notnull = __ IfTrue(iff); |
kvn@2413 | 1353 | kit.set_control(notnull); // set control for the cast_not_null |
kvn@2413 | 1354 | arg = kit.cast_not_null(arg, false); |
kvn@2413 | 1355 | sc->set_argument(argi, arg); |
kvn@2413 | 1356 | } |
kvn@2413 | 1357 | assert(kit.gvn().type(arg)->higher_equal(TypeInstPtr::NOTNULL), "sanity"); |
kvn@2413 | 1358 | // Fallthrough to add string length. |
kvn@2413 | 1359 | } |
never@1515 | 1360 | case StringConcat::StringMode: { |
never@1515 | 1361 | const Type* type = kit.gvn().type(arg); |
never@1515 | 1362 | if (type == TypePtr::NULL_PTR) { |
never@1515 | 1363 | // replace the argument with the null checked version |
never@1515 | 1364 | arg = null_string; |
never@1515 | 1365 | sc->set_argument(argi, arg); |
never@1515 | 1366 | } else if (!type->higher_equal(TypeInstPtr::NOTNULL)) { |
never@1515 | 1367 | // s = s != null ? s : "null"; |
never@1515 | 1368 | // length = length + (s.count - s.offset); |
kvn@4115 | 1369 | RegionNode *r = new (C) RegionNode(3); |
never@1515 | 1370 | kit.gvn().set_type(r, Type::CONTROL); |
kvn@4115 | 1371 | Node *phi = new (C) PhiNode(r, type); |
never@1515 | 1372 | kit.gvn().set_type(phi, phi->bottom_type()); |
never@1515 | 1373 | Node* p = __ Bool(__ CmpP(arg, kit.null()), BoolTest::ne); |
never@1515 | 1374 | IfNode* iff = kit.create_and_map_if(kit.control(), p, PROB_MIN, COUNT_UNKNOWN); |
never@1515 | 1375 | Node* notnull = __ IfTrue(iff); |
never@1515 | 1376 | Node* isnull = __ IfFalse(iff); |
never@1685 | 1377 | kit.set_control(notnull); // set control for the cast_not_null |
never@1515 | 1378 | r->init_req(1, notnull); |
never@1685 | 1379 | phi->init_req(1, kit.cast_not_null(arg, false)); |
never@1515 | 1380 | r->init_req(2, isnull); |
never@1515 | 1381 | phi->init_req(2, null_string); |
never@1515 | 1382 | kit.set_control(r); |
never@1515 | 1383 | C->record_for_igvn(r); |
never@1515 | 1384 | C->record_for_igvn(phi); |
never@1515 | 1385 | // replace the argument with the null checked version |
never@1515 | 1386 | arg = phi; |
never@1515 | 1387 | sc->set_argument(argi, arg); |
never@1515 | 1388 | } |
kvn@3760 | 1389 | |
kvn@3760 | 1390 | Node* count = kit.load_String_length(kit.control(), arg); |
kvn@3760 | 1391 | |
never@1515 | 1392 | length = __ AddI(length, count); |
never@1515 | 1393 | string_sizes->init_req(argi, NULL); |
never@1515 | 1394 | break; |
never@1515 | 1395 | } |
never@1515 | 1396 | case StringConcat::CharMode: { |
never@1515 | 1397 | // one character only |
never@1515 | 1398 | length = __ AddI(length, __ intcon(1)); |
never@1515 | 1399 | break; |
never@1515 | 1400 | } |
never@1515 | 1401 | default: |
never@1515 | 1402 | ShouldNotReachHere(); |
never@1515 | 1403 | } |
never@1515 | 1404 | if (argi > 0) { |
never@1515 | 1405 | // Check that the sum hasn't overflowed |
never@1515 | 1406 | IfNode* iff = kit.create_and_map_if(kit.control(), |
never@1515 | 1407 | __ Bool(__ CmpI(length, __ intcon(0)), BoolTest::lt), |
never@1515 | 1408 | PROB_MIN, COUNT_UNKNOWN); |
never@1515 | 1409 | kit.set_control(__ IfFalse(iff)); |
never@1515 | 1410 | overflow->set_req(argi, __ IfTrue(iff)); |
never@1515 | 1411 | } |
never@1515 | 1412 | } |
never@1515 | 1413 | |
never@1515 | 1414 | { |
never@1515 | 1415 | // Hook |
never@1515 | 1416 | PreserveJVMState pjvms(&kit); |
never@1515 | 1417 | kit.set_control(overflow); |
kvn@2413 | 1418 | C->record_for_igvn(overflow); |
never@1515 | 1419 | kit.uncommon_trap(Deoptimization::Reason_intrinsic, |
never@1515 | 1420 | Deoptimization::Action_make_not_entrant); |
never@1515 | 1421 | } |
never@1515 | 1422 | |
roland@4357 | 1423 | Node* result; |
roland@4357 | 1424 | if (!kit.stopped()) { |
roland@4357 | 1425 | |
roland@4357 | 1426 | // length now contains the number of characters needed for the |
roland@4357 | 1427 | // char[] so create a new AllocateArray for the char[] |
roland@4357 | 1428 | Node* char_array = NULL; |
roland@4357 | 1429 | { |
roland@4357 | 1430 | PreserveReexecuteState preexecs(&kit); |
roland@4357 | 1431 | // The original jvms is for an allocation of either a String or |
roland@4357 | 1432 | // StringBuffer so no stack adjustment is necessary for proper |
roland@4357 | 1433 | // reexecution. If we deoptimize in the slow path the bytecode |
roland@4357 | 1434 | // will be reexecuted and the char[] allocation will be thrown away. |
roland@4357 | 1435 | kit.jvms()->set_should_reexecute(true); |
roland@4357 | 1436 | char_array = kit.new_array(__ makecon(TypeKlassPtr::make(ciTypeArrayKlass::make(T_CHAR))), |
roland@4357 | 1437 | length, 1); |
roland@4357 | 1438 | } |
roland@4357 | 1439 | |
roland@4357 | 1440 | // Mark the allocation so that zeroing is skipped since the code |
roland@4357 | 1441 | // below will overwrite the entire array |
roland@4357 | 1442 | AllocateArrayNode* char_alloc = AllocateArrayNode::Ideal_array_allocation(char_array, _gvn); |
roland@4357 | 1443 | char_alloc->maybe_set_complete(_gvn); |
roland@4357 | 1444 | |
roland@4357 | 1445 | // Now copy the string representations into the final char[] |
roland@4357 | 1446 | Node* start = __ intcon(0); |
roland@4357 | 1447 | for (int argi = 0; argi < sc->num_arguments(); argi++) { |
roland@4357 | 1448 | Node* arg = sc->argument(argi); |
roland@4357 | 1449 | switch (sc->mode(argi)) { |
roland@4357 | 1450 | case StringConcat::IntMode: { |
roland@4357 | 1451 | Node* end = __ AddI(start, string_sizes->in(argi)); |
roland@4357 | 1452 | // getChars words backwards so pass the ending point as well as the start |
roland@4357 | 1453 | int_getChars(kit, arg, char_array, start, end); |
roland@4357 | 1454 | start = end; |
roland@4357 | 1455 | break; |
roland@4357 | 1456 | } |
roland@4357 | 1457 | case StringConcat::StringNullCheckMode: |
roland@4357 | 1458 | case StringConcat::StringMode: { |
roland@4357 | 1459 | start = copy_string(kit, arg, char_array, start); |
roland@4357 | 1460 | break; |
roland@4357 | 1461 | } |
roland@4357 | 1462 | case StringConcat::CharMode: { |
roland@4357 | 1463 | __ store_to_memory(kit.control(), kit.array_element_address(char_array, start, T_CHAR), |
roland@4357 | 1464 | arg, T_CHAR, char_adr_idx); |
roland@4357 | 1465 | start = __ AddI(start, __ intcon(1)); |
roland@4357 | 1466 | break; |
roland@4357 | 1467 | } |
roland@4357 | 1468 | default: |
roland@4357 | 1469 | ShouldNotReachHere(); |
roland@4357 | 1470 | } |
roland@4357 | 1471 | } |
roland@4357 | 1472 | |
roland@4357 | 1473 | // If we're not reusing an existing String allocation then allocate one here. |
roland@4357 | 1474 | result = sc->string_alloc(); |
roland@4357 | 1475 | if (result == NULL) { |
roland@4357 | 1476 | PreserveReexecuteState preexecs(&kit); |
roland@4357 | 1477 | // The original jvms is for an allocation of either a String or |
roland@4357 | 1478 | // StringBuffer so no stack adjustment is necessary for proper |
roland@4357 | 1479 | // reexecution. |
roland@4357 | 1480 | kit.jvms()->set_should_reexecute(true); |
roland@4357 | 1481 | result = kit.new_instance(__ makecon(TypeKlassPtr::make(C->env()->String_klass()))); |
roland@4357 | 1482 | } |
roland@4357 | 1483 | |
roland@4357 | 1484 | // Intialize the string |
roland@4357 | 1485 | if (java_lang_String::has_offset_field()) { |
roland@4357 | 1486 | kit.store_String_offset(kit.control(), result, __ intcon(0)); |
roland@4357 | 1487 | kit.store_String_length(kit.control(), result, length); |
roland@4357 | 1488 | } |
roland@4357 | 1489 | kit.store_String_value(kit.control(), result, char_array); |
roland@4357 | 1490 | } else { |
roland@4357 | 1491 | result = C->top(); |
never@1515 | 1492 | } |
never@1515 | 1493 | // hook up the outgoing control and result |
never@1515 | 1494 | kit.replace_call(sc->end(), result); |
never@1515 | 1495 | |
never@1515 | 1496 | // Unhook any hook nodes |
bharadwaj@4315 | 1497 | string_sizes->disconnect_inputs(NULL, C); |
never@1515 | 1498 | sc->cleanup(); |
never@1515 | 1499 | } |