Tue, 15 Mar 2011 06:35:10 -0700
7024234: 2/3 jvmti tests fail assert(!_oops_are_stale) failed: oops are stale on Win-AMD64
Summary: Move initialization of the '_instance' field to avoid race with ServiceThread start.
Reviewed-by: dholmes, kamg, never, dsamersoff, ysr, coleenp, acorn
duke@435 | 1 | /* |
stefank@2314 | 2 | * Copyright (c) 1998, 2010, Oracle and/or its affiliates. All rights reserved. |
duke@435 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
duke@435 | 4 | * |
duke@435 | 5 | * This code is free software; you can redistribute it and/or modify it |
duke@435 | 6 | * under the terms of the GNU General Public License version 2 only, as |
duke@435 | 7 | * published by the Free Software Foundation. |
duke@435 | 8 | * |
duke@435 | 9 | * This code is distributed in the hope that it will be useful, but WITHOUT |
duke@435 | 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
duke@435 | 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
duke@435 | 12 | * version 2 for more details (a copy is included in the LICENSE file that |
duke@435 | 13 | * accompanied this code). |
duke@435 | 14 | * |
duke@435 | 15 | * You should have received a copy of the GNU General Public License version |
duke@435 | 16 | * 2 along with this work; if not, write to the Free Software Foundation, |
duke@435 | 17 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
duke@435 | 18 | * |
trims@1907 | 19 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
trims@1907 | 20 | * or visit www.oracle.com if you need additional information or have any |
trims@1907 | 21 | * questions. |
duke@435 | 22 | * |
duke@435 | 23 | */ |
duke@435 | 24 | |
stefank@2314 | 25 | #ifndef SHARE_VM_RUNTIME_HANDLES_INLINE_HPP |
stefank@2314 | 26 | #define SHARE_VM_RUNTIME_HANDLES_INLINE_HPP |
stefank@2314 | 27 | |
stefank@2314 | 28 | #include "runtime/handles.hpp" |
stefank@2314 | 29 | #ifdef TARGET_OS_FAMILY_linux |
stefank@2314 | 30 | # include "thread_linux.inline.hpp" |
stefank@2314 | 31 | #endif |
stefank@2314 | 32 | #ifdef TARGET_OS_FAMILY_solaris |
stefank@2314 | 33 | # include "thread_solaris.inline.hpp" |
stefank@2314 | 34 | #endif |
stefank@2314 | 35 | #ifdef TARGET_OS_FAMILY_windows |
stefank@2314 | 36 | # include "thread_windows.inline.hpp" |
stefank@2314 | 37 | #endif |
stefank@2314 | 38 | |
duke@435 | 39 | // these inline functions are in a separate file to break an include cycle |
duke@435 | 40 | // between Thread and Handle |
duke@435 | 41 | |
duke@435 | 42 | inline Handle::Handle(oop obj) { |
duke@435 | 43 | if (obj == NULL) { |
duke@435 | 44 | _handle = NULL; |
duke@435 | 45 | } else { |
duke@435 | 46 | _handle = Thread::current()->handle_area()->allocate_handle(obj); |
duke@435 | 47 | } |
duke@435 | 48 | } |
duke@435 | 49 | |
duke@435 | 50 | |
duke@435 | 51 | #ifndef ASSERT |
duke@435 | 52 | inline Handle::Handle(Thread* thread, oop obj) { |
duke@435 | 53 | assert(thread == Thread::current(), "sanity check"); |
duke@435 | 54 | if (obj == NULL) { |
duke@435 | 55 | _handle = NULL; |
duke@435 | 56 | } else { |
duke@435 | 57 | _handle = thread->handle_area()->allocate_handle(obj); |
duke@435 | 58 | } |
duke@435 | 59 | } |
duke@435 | 60 | #endif // ASSERT |
duke@435 | 61 | |
duke@435 | 62 | |
duke@435 | 63 | inline HandleMark::HandleMark() { |
duke@435 | 64 | initialize(Thread::current()); |
duke@435 | 65 | } |
duke@435 | 66 | |
duke@435 | 67 | |
duke@435 | 68 | inline void HandleMark::push() { |
duke@435 | 69 | // This is intentionally a NOP. pop_and_restore will reset |
duke@435 | 70 | // values to the HandleMark further down the stack, typically |
duke@435 | 71 | // in JavaCalls::call_helper. |
duke@435 | 72 | debug_only(_area->_handle_mark_nesting++); |
duke@435 | 73 | } |
duke@435 | 74 | |
duke@435 | 75 | inline void HandleMark::pop_and_restore() { |
duke@435 | 76 | HandleArea* area = _area; // help compilers with poor alias analysis |
duke@435 | 77 | // Delete later chunks |
duke@435 | 78 | if( _chunk->next() ) { |
duke@435 | 79 | _chunk->next_chop(); |
duke@435 | 80 | } |
duke@435 | 81 | // Roll back arena to saved top markers |
duke@435 | 82 | area->_chunk = _chunk; |
duke@435 | 83 | area->_hwm = _hwm; |
duke@435 | 84 | area->_max = _max; |
duke@435 | 85 | NOT_PRODUCT(area->set_size_in_bytes(_size_in_bytes);) |
duke@435 | 86 | debug_only(area->_handle_mark_nesting--); |
duke@435 | 87 | } |
stefank@2314 | 88 | |
stefank@2314 | 89 | #endif // SHARE_VM_RUNTIME_HANDLES_INLINE_HPP |