Mon, 04 Nov 2013 21:59:54 +0100
8027445: SIGSEGV at TestFloatingDecimal.testAppendToDouble()I
Summary: String.equals() intrinsic shouldn't use integer length input in pointer arithmetic without an i2l.
Reviewed-by: kvn, twisti
duke@435 | 1 | /* |
coleenp@4037 | 2 | * Copyright (c) 2004, 2012, Oracle and/or its affiliates. All rights reserved. |
duke@435 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
duke@435 | 4 | * |
duke@435 | 5 | * This code is free software; you can redistribute it and/or modify it |
duke@435 | 6 | * under the terms of the GNU General Public License version 2 only, as |
duke@435 | 7 | * published by the Free Software Foundation. |
duke@435 | 8 | * |
duke@435 | 9 | * This code is distributed in the hope that it will be useful, but WITHOUT |
duke@435 | 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
duke@435 | 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
duke@435 | 12 | * version 2 for more details (a copy is included in the LICENSE file that |
duke@435 | 13 | * accompanied this code). |
duke@435 | 14 | * |
duke@435 | 15 | * You should have received a copy of the GNU General Public License version |
duke@435 | 16 | * 2 along with this work; if not, write to the Free Software Foundation, |
duke@435 | 17 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
duke@435 | 18 | * |
trims@1907 | 19 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
trims@1907 | 20 | * or visit www.oracle.com if you need additional information or have any |
trims@1907 | 21 | * questions. |
duke@435 | 22 | * |
duke@435 | 23 | */ |
duke@435 | 24 | |
stefank@2314 | 25 | #include "precompiled.hpp" |
twisti@4323 | 26 | #include "asm/macroAssembler.inline.hpp" |
twisti@4323 | 27 | #include "asm/codeBuffer.hpp" |
coleenp@4037 | 28 | #include "memory/metaspaceShared.hpp" |
duke@435 | 29 | |
duke@435 | 30 | // Generate the self-patching vtable method: |
duke@435 | 31 | // |
duke@435 | 32 | // This method will be called (as any other Klass virtual method) with |
duke@435 | 33 | // the Klass itself as the first argument. Example: |
duke@435 | 34 | // |
duke@435 | 35 | // oop obj; |
coleenp@4037 | 36 | // int size = obj->klass()->oop_size(this); |
duke@435 | 37 | // |
duke@435 | 38 | // for which the virtual method call is Klass::oop_size(); |
duke@435 | 39 | // |
duke@435 | 40 | // The dummy method is called with the Klass object as the first |
duke@435 | 41 | // operand, and an object as the second argument. |
duke@435 | 42 | // |
duke@435 | 43 | |
duke@435 | 44 | //===================================================================== |
duke@435 | 45 | |
duke@435 | 46 | // All of the dummy methods in the vtable are essentially identical, |
coleenp@4037 | 47 | // differing only by an ordinal constant, and they bear no relationship |
duke@435 | 48 | // to the original method which the caller intended. Also, there needs |
duke@435 | 49 | // to be 'vtbl_list_size' instances of the vtable in order to |
duke@435 | 50 | // differentiate between the 'vtable_list_size' original Klass objects. |
duke@435 | 51 | |
duke@435 | 52 | #define __ masm-> |
duke@435 | 53 | |
coleenp@4037 | 54 | void MetaspaceShared::generate_vtable_methods(void** vtbl_list, |
duke@435 | 55 | void** vtable, |
duke@435 | 56 | char** md_top, |
duke@435 | 57 | char* md_end, |
duke@435 | 58 | char** mc_top, |
duke@435 | 59 | char* mc_end) { |
duke@435 | 60 | |
duke@435 | 61 | intptr_t vtable_bytes = (num_virtuals * vtbl_list_size) * sizeof(void*); |
duke@435 | 62 | *(intptr_t *)(*md_top) = vtable_bytes; |
duke@435 | 63 | *md_top += sizeof(intptr_t); |
duke@435 | 64 | void** dummy_vtable = (void**)*md_top; |
duke@435 | 65 | *vtable = dummy_vtable; |
duke@435 | 66 | *md_top += vtable_bytes; |
duke@435 | 67 | |
duke@435 | 68 | guarantee(*md_top <= md_end, "Insufficient space for vtables."); |
duke@435 | 69 | |
duke@435 | 70 | // Get ready to generate dummy methods. |
duke@435 | 71 | |
duke@435 | 72 | CodeBuffer cb((unsigned char*)*mc_top, mc_end - *mc_top); |
duke@435 | 73 | MacroAssembler* masm = new MacroAssembler(&cb); |
duke@435 | 74 | |
duke@435 | 75 | Label common_code; |
duke@435 | 76 | for (int i = 0; i < vtbl_list_size; ++i) { |
duke@435 | 77 | for (int j = 0; j < num_virtuals; ++j) { |
duke@435 | 78 | dummy_vtable[num_virtuals * i + j] = (void*)masm->pc(); |
duke@435 | 79 | __ save(SP, -256, SP); |
never@2658 | 80 | int offset = (i << 8) + j; |
never@2658 | 81 | Register src = G0; |
never@2658 | 82 | if (!Assembler::is_simm13(offset)) { |
never@2658 | 83 | __ sethi(offset, L0); |
never@2658 | 84 | src = L0; |
never@2658 | 85 | offset = offset & ((1 << 10) - 1); |
never@2658 | 86 | } |
duke@435 | 87 | __ brx(Assembler::always, false, Assembler::pt, common_code); |
duke@435 | 88 | |
duke@435 | 89 | // Load L0 with a value indicating vtable/offset pair. |
duke@435 | 90 | // -- bits[ 7..0] (8 bits) which virtual method in table? |
never@2658 | 91 | // -- bits[13..8] (6 bits) which virtual method table? |
never@2658 | 92 | __ delayed()->or3(src, offset, L0); |
duke@435 | 93 | } |
duke@435 | 94 | } |
duke@435 | 95 | |
duke@435 | 96 | __ bind(common_code); |
duke@435 | 97 | |
duke@435 | 98 | // Expecting to be called with the "this" pointer in O0/I0 (where |
duke@435 | 99 | // "this" is a Klass object). In addition, L0 was set (above) to |
duke@435 | 100 | // identify the method and table. |
duke@435 | 101 | |
duke@435 | 102 | // Look up the correct vtable pointer. |
duke@435 | 103 | |
duke@435 | 104 | __ set((intptr_t)vtbl_list, L2); // L2 = address of new vtable list. |
duke@435 | 105 | __ srl(L0, 8, L3); // Isolate L3 = vtable identifier. |
duke@435 | 106 | __ sll(L3, LogBytesPerWord, L3); |
duke@435 | 107 | __ ld_ptr(L2, L3, L3); // L3 = new (correct) vtable pointer. |
duke@435 | 108 | __ st_ptr(L3, Address(I0, 0)); // Save correct vtable ptr in entry. |
duke@435 | 109 | |
duke@435 | 110 | // Restore registers and jump to the correct method; |
duke@435 | 111 | |
duke@435 | 112 | __ and3(L0, 255, L4); // Isolate L3 = method offset;. |
duke@435 | 113 | __ sll(L4, LogBytesPerWord, L4); |
duke@435 | 114 | __ ld_ptr(L3, L4, L4); // Get address of correct virtual method |
twisti@1162 | 115 | __ jmpl(L4, 0, G0); // Jump to correct method. |
duke@435 | 116 | __ delayed()->restore(); // Restore registers. |
duke@435 | 117 | |
duke@435 | 118 | __ flush(); |
duke@435 | 119 | *mc_top = (char*)__ pc(); |
duke@435 | 120 | |
duke@435 | 121 | guarantee(*mc_top <= mc_end, "Insufficient space for method wrappers."); |
duke@435 | 122 | } |