src/share/vm/opto/lcm.cpp

Thu, 21 Aug 2008 23:36:31 -0400

author
tonyp
date
Thu, 21 Aug 2008 23:36:31 -0400
changeset 791
1ee8caae33af
parent 779
6aae2f9d0294
parent 688
b0fe4deeb9fb
child 800
5f44674206d3
permissions
-rw-r--r--

Merge

duke@435 1 /*
xdono@631 2 * Copyright 1998-2008 Sun Microsystems, Inc. All Rights Reserved.
duke@435 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
duke@435 4 *
duke@435 5 * This code is free software; you can redistribute it and/or modify it
duke@435 6 * under the terms of the GNU General Public License version 2 only, as
duke@435 7 * published by the Free Software Foundation.
duke@435 8 *
duke@435 9 * This code is distributed in the hope that it will be useful, but WITHOUT
duke@435 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
duke@435 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
duke@435 12 * version 2 for more details (a copy is included in the LICENSE file that
duke@435 13 * accompanied this code).
duke@435 14 *
duke@435 15 * You should have received a copy of the GNU General Public License version
duke@435 16 * 2 along with this work; if not, write to the Free Software Foundation,
duke@435 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
duke@435 18 *
duke@435 19 * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
duke@435 20 * CA 95054 USA or visit www.sun.com if you need additional information or
duke@435 21 * have any questions.
duke@435 22 *
duke@435 23 */
duke@435 24
duke@435 25 // Optimization - Graph Style
duke@435 26
duke@435 27 #include "incls/_precompiled.incl"
duke@435 28 #include "incls/_lcm.cpp.incl"
duke@435 29
duke@435 30 //------------------------------implicit_null_check----------------------------
duke@435 31 // Detect implicit-null-check opportunities. Basically, find NULL checks
duke@435 32 // with suitable memory ops nearby. Use the memory op to do the NULL check.
duke@435 33 // I can generate a memory op if there is not one nearby.
duke@435 34 // The proj is the control projection for the not-null case.
duke@435 35 // The val is the pointer being checked for nullness.
duke@435 36 void Block::implicit_null_check(PhaseCFG *cfg, Node *proj, Node *val, int allowed_reasons) {
duke@435 37 // Assume if null check need for 0 offset then always needed
duke@435 38 // Intel solaris doesn't support any null checks yet and no
duke@435 39 // mechanism exists (yet) to set the switches at an os_cpu level
duke@435 40 if( !ImplicitNullChecks || MacroAssembler::needs_explicit_null_check(0)) return;
duke@435 41
duke@435 42 // Make sure the ptr-is-null path appears to be uncommon!
duke@435 43 float f = end()->as_MachIf()->_prob;
duke@435 44 if( proj->Opcode() == Op_IfTrue ) f = 1.0f - f;
duke@435 45 if( f > PROB_UNLIKELY_MAG(4) ) return;
duke@435 46
duke@435 47 uint bidx = 0; // Capture index of value into memop
duke@435 48 bool was_store; // Memory op is a store op
duke@435 49
duke@435 50 // Get the successor block for if the test ptr is non-null
duke@435 51 Block* not_null_block; // this one goes with the proj
duke@435 52 Block* null_block;
duke@435 53 if (_nodes[_nodes.size()-1] == proj) {
duke@435 54 null_block = _succs[0];
duke@435 55 not_null_block = _succs[1];
duke@435 56 } else {
duke@435 57 assert(_nodes[_nodes.size()-2] == proj, "proj is one or the other");
duke@435 58 not_null_block = _succs[0];
duke@435 59 null_block = _succs[1];
duke@435 60 }
duke@435 61
duke@435 62 // Search the exception block for an uncommon trap.
duke@435 63 // (See Parse::do_if and Parse::do_ifnull for the reason
duke@435 64 // we need an uncommon trap. Briefly, we need a way to
duke@435 65 // detect failure of this optimization, as in 6366351.)
duke@435 66 {
duke@435 67 bool found_trap = false;
duke@435 68 for (uint i1 = 0; i1 < null_block->_nodes.size(); i1++) {
duke@435 69 Node* nn = null_block->_nodes[i1];
duke@435 70 if (nn->is_MachCall() &&
duke@435 71 nn->as_MachCall()->entry_point() ==
duke@435 72 SharedRuntime::uncommon_trap_blob()->instructions_begin()) {
duke@435 73 const Type* trtype = nn->in(TypeFunc::Parms)->bottom_type();
duke@435 74 if (trtype->isa_int() && trtype->is_int()->is_con()) {
duke@435 75 jint tr_con = trtype->is_int()->get_con();
duke@435 76 Deoptimization::DeoptReason reason = Deoptimization::trap_request_reason(tr_con);
duke@435 77 Deoptimization::DeoptAction action = Deoptimization::trap_request_action(tr_con);
duke@435 78 assert((int)reason < (int)BitsPerInt, "recode bit map");
duke@435 79 if (is_set_nth_bit(allowed_reasons, (int) reason)
duke@435 80 && action != Deoptimization::Action_none) {
duke@435 81 // This uncommon trap is sure to recompile, eventually.
duke@435 82 // When that happens, C->too_many_traps will prevent
duke@435 83 // this transformation from happening again.
duke@435 84 found_trap = true;
duke@435 85 }
duke@435 86 }
duke@435 87 break;
duke@435 88 }
duke@435 89 }
duke@435 90 if (!found_trap) {
duke@435 91 // We did not find an uncommon trap.
duke@435 92 return;
duke@435 93 }
duke@435 94 }
duke@435 95
duke@435 96 // Search the successor block for a load or store who's base value is also
duke@435 97 // the tested value. There may be several.
duke@435 98 Node_List *out = new Node_List(Thread::current()->resource_area());
duke@435 99 MachNode *best = NULL; // Best found so far
duke@435 100 for (DUIterator i = val->outs(); val->has_out(i); i++) {
duke@435 101 Node *m = val->out(i);
duke@435 102 if( !m->is_Mach() ) continue;
duke@435 103 MachNode *mach = m->as_Mach();
duke@435 104 was_store = false;
duke@435 105 switch( mach->ideal_Opcode() ) {
duke@435 106 case Op_LoadB:
duke@435 107 case Op_LoadC:
duke@435 108 case Op_LoadD:
duke@435 109 case Op_LoadF:
duke@435 110 case Op_LoadI:
duke@435 111 case Op_LoadL:
duke@435 112 case Op_LoadP:
coleenp@548 113 case Op_LoadN:
duke@435 114 case Op_LoadS:
duke@435 115 case Op_LoadKlass:
kvn@599 116 case Op_LoadNKlass:
duke@435 117 case Op_LoadRange:
duke@435 118 case Op_LoadD_unaligned:
duke@435 119 case Op_LoadL_unaligned:
duke@435 120 break;
duke@435 121 case Op_StoreB:
duke@435 122 case Op_StoreC:
duke@435 123 case Op_StoreCM:
duke@435 124 case Op_StoreD:
duke@435 125 case Op_StoreF:
duke@435 126 case Op_StoreI:
duke@435 127 case Op_StoreL:
duke@435 128 case Op_StoreP:
coleenp@548 129 case Op_StoreN:
duke@435 130 was_store = true; // Memory op is a store op
duke@435 131 // Stores will have their address in slot 2 (memory in slot 1).
duke@435 132 // If the value being nul-checked is in another slot, it means we
duke@435 133 // are storing the checked value, which does NOT check the value!
duke@435 134 if( mach->in(2) != val ) continue;
duke@435 135 break; // Found a memory op?
duke@435 136 case Op_StrComp:
rasbold@604 137 case Op_AryEq:
duke@435 138 // Not a legit memory op for implicit null check regardless of
duke@435 139 // embedded loads
duke@435 140 continue;
duke@435 141 default: // Also check for embedded loads
duke@435 142 if( !mach->needs_anti_dependence_check() )
duke@435 143 continue; // Not an memory op; skip it
duke@435 144 break;
duke@435 145 }
duke@435 146 // check if the offset is not too high for implicit exception
duke@435 147 {
duke@435 148 intptr_t offset = 0;
duke@435 149 const TypePtr *adr_type = NULL; // Do not need this return value here
duke@435 150 const Node* base = mach->get_base_and_disp(offset, adr_type);
duke@435 151 if (base == NULL || base == NodeSentinel) {
duke@435 152 // cannot reason about it; is probably not implicit null exception
duke@435 153 } else {
duke@435 154 const TypePtr* tptr = base->bottom_type()->is_ptr();
duke@435 155 // Give up if offset is not a compile-time constant
duke@435 156 if( offset == Type::OffsetBot || tptr->_offset == Type::OffsetBot )
duke@435 157 continue;
duke@435 158 offset += tptr->_offset; // correct if base is offseted
duke@435 159 if( MacroAssembler::needs_explicit_null_check(offset) )
duke@435 160 continue; // Give up is reference is beyond 4K page size
duke@435 161 }
duke@435 162 }
duke@435 163
duke@435 164 // Check ctrl input to see if the null-check dominates the memory op
duke@435 165 Block *cb = cfg->_bbs[mach->_idx];
duke@435 166 cb = cb->_idom; // Always hoist at least 1 block
duke@435 167 if( !was_store ) { // Stores can be hoisted only one block
duke@435 168 while( cb->_dom_depth > (_dom_depth + 1))
duke@435 169 cb = cb->_idom; // Hoist loads as far as we want
duke@435 170 // The non-null-block should dominate the memory op, too. Live
duke@435 171 // range spilling will insert a spill in the non-null-block if it is
duke@435 172 // needs to spill the memory op for an implicit null check.
duke@435 173 if (cb->_dom_depth == (_dom_depth + 1)) {
duke@435 174 if (cb != not_null_block) continue;
duke@435 175 cb = cb->_idom;
duke@435 176 }
duke@435 177 }
duke@435 178 if( cb != this ) continue;
duke@435 179
duke@435 180 // Found a memory user; see if it can be hoisted to check-block
duke@435 181 uint vidx = 0; // Capture index of value into memop
duke@435 182 uint j;
duke@435 183 for( j = mach->req()-1; j > 0; j-- ) {
duke@435 184 if( mach->in(j) == val ) vidx = j;
duke@435 185 // Block of memory-op input
duke@435 186 Block *inb = cfg->_bbs[mach->in(j)->_idx];
duke@435 187 Block *b = this; // Start from nul check
duke@435 188 while( b != inb && b->_dom_depth > inb->_dom_depth )
duke@435 189 b = b->_idom; // search upwards for input
duke@435 190 // See if input dominates null check
duke@435 191 if( b != inb )
duke@435 192 break;
duke@435 193 }
duke@435 194 if( j > 0 )
duke@435 195 continue;
duke@435 196 Block *mb = cfg->_bbs[mach->_idx];
duke@435 197 // Hoisting stores requires more checks for the anti-dependence case.
duke@435 198 // Give up hoisting if we have to move the store past any load.
duke@435 199 if( was_store ) {
duke@435 200 Block *b = mb; // Start searching here for a local load
duke@435 201 // mach use (faulting) trying to hoist
duke@435 202 // n might be blocker to hoisting
duke@435 203 while( b != this ) {
duke@435 204 uint k;
duke@435 205 for( k = 1; k < b->_nodes.size(); k++ ) {
duke@435 206 Node *n = b->_nodes[k];
duke@435 207 if( n->needs_anti_dependence_check() &&
duke@435 208 n->in(LoadNode::Memory) == mach->in(StoreNode::Memory) )
duke@435 209 break; // Found anti-dependent load
duke@435 210 }
duke@435 211 if( k < b->_nodes.size() )
duke@435 212 break; // Found anti-dependent load
duke@435 213 // Make sure control does not do a merge (would have to check allpaths)
duke@435 214 if( b->num_preds() != 2 ) break;
duke@435 215 b = cfg->_bbs[b->pred(1)->_idx]; // Move up to predecessor block
duke@435 216 }
duke@435 217 if( b != this ) continue;
duke@435 218 }
duke@435 219
duke@435 220 // Make sure this memory op is not already being used for a NullCheck
duke@435 221 Node *e = mb->end();
duke@435 222 if( e->is_MachNullCheck() && e->in(1) == mach )
duke@435 223 continue; // Already being used as a NULL check
duke@435 224
duke@435 225 // Found a candidate! Pick one with least dom depth - the highest
duke@435 226 // in the dom tree should be closest to the null check.
duke@435 227 if( !best ||
duke@435 228 cfg->_bbs[mach->_idx]->_dom_depth < cfg->_bbs[best->_idx]->_dom_depth ) {
duke@435 229 best = mach;
duke@435 230 bidx = vidx;
duke@435 231
duke@435 232 }
duke@435 233 }
duke@435 234 // No candidate!
duke@435 235 if( !best ) return;
duke@435 236
duke@435 237 // ---- Found an implicit null check
duke@435 238 extern int implicit_null_checks;
duke@435 239 implicit_null_checks++;
duke@435 240
duke@435 241 // Hoist the memory candidate up to the end of the test block.
duke@435 242 Block *old_block = cfg->_bbs[best->_idx];
duke@435 243 old_block->find_remove(best);
duke@435 244 add_inst(best);
duke@435 245 cfg->_bbs.map(best->_idx,this);
duke@435 246
duke@435 247 // Move the control dependence
duke@435 248 if (best->in(0) && best->in(0) == old_block->_nodes[0])
duke@435 249 best->set_req(0, _nodes[0]);
duke@435 250
duke@435 251 // Check for flag-killing projections that also need to be hoisted
duke@435 252 // Should be DU safe because no edge updates.
duke@435 253 for (DUIterator_Fast jmax, j = best->fast_outs(jmax); j < jmax; j++) {
duke@435 254 Node* n = best->fast_out(j);
duke@435 255 if( n->Opcode() == Op_MachProj ) {
duke@435 256 cfg->_bbs[n->_idx]->find_remove(n);
duke@435 257 add_inst(n);
duke@435 258 cfg->_bbs.map(n->_idx,this);
duke@435 259 }
duke@435 260 }
duke@435 261
duke@435 262 Compile *C = cfg->C;
duke@435 263 // proj==Op_True --> ne test; proj==Op_False --> eq test.
duke@435 264 // One of two graph shapes got matched:
duke@435 265 // (IfTrue (If (Bool NE (CmpP ptr NULL))))
duke@435 266 // (IfFalse (If (Bool EQ (CmpP ptr NULL))))
duke@435 267 // NULL checks are always branch-if-eq. If we see a IfTrue projection
duke@435 268 // then we are replacing a 'ne' test with a 'eq' NULL check test.
duke@435 269 // We need to flip the projections to keep the same semantics.
duke@435 270 if( proj->Opcode() == Op_IfTrue ) {
duke@435 271 // Swap order of projections in basic block to swap branch targets
duke@435 272 Node *tmp1 = _nodes[end_idx()+1];
duke@435 273 Node *tmp2 = _nodes[end_idx()+2];
duke@435 274 _nodes.map(end_idx()+1, tmp2);
duke@435 275 _nodes.map(end_idx()+2, tmp1);
duke@435 276 Node *tmp = new (C, 1) Node(C->top()); // Use not NULL input
duke@435 277 tmp1->replace_by(tmp);
duke@435 278 tmp2->replace_by(tmp1);
duke@435 279 tmp->replace_by(tmp2);
duke@435 280 tmp->destruct();
duke@435 281 }
duke@435 282
duke@435 283 // Remove the existing null check; use a new implicit null check instead.
duke@435 284 // Since schedule-local needs precise def-use info, we need to correct
duke@435 285 // it as well.
duke@435 286 Node *old_tst = proj->in(0);
duke@435 287 MachNode *nul_chk = new (C) MachNullCheckNode(old_tst->in(0),best,bidx);
duke@435 288 _nodes.map(end_idx(),nul_chk);
duke@435 289 cfg->_bbs.map(nul_chk->_idx,this);
duke@435 290 // Redirect users of old_test to nul_chk
duke@435 291 for (DUIterator_Last i2min, i2 = old_tst->last_outs(i2min); i2 >= i2min; --i2)
duke@435 292 old_tst->last_out(i2)->set_req(0, nul_chk);
duke@435 293 // Clean-up any dead code
duke@435 294 for (uint i3 = 0; i3 < old_tst->req(); i3++)
duke@435 295 old_tst->set_req(i3, NULL);
duke@435 296
duke@435 297 cfg->latency_from_uses(nul_chk);
duke@435 298 cfg->latency_from_uses(best);
duke@435 299 }
duke@435 300
duke@435 301
duke@435 302 //------------------------------select-----------------------------------------
duke@435 303 // Select a nice fellow from the worklist to schedule next. If there is only
duke@435 304 // one choice, then use it. Projections take top priority for correctness
duke@435 305 // reasons - if I see a projection, then it is next. There are a number of
duke@435 306 // other special cases, for instructions that consume condition codes, et al.
duke@435 307 // These are chosen immediately. Some instructions are required to immediately
duke@435 308 // precede the last instruction in the block, and these are taken last. Of the
duke@435 309 // remaining cases (most), choose the instruction with the greatest latency
duke@435 310 // (that is, the most number of pseudo-cycles required to the end of the
duke@435 311 // routine). If there is a tie, choose the instruction with the most inputs.
duke@435 312 Node *Block::select(PhaseCFG *cfg, Node_List &worklist, int *ready_cnt, VectorSet &next_call, uint sched_slot) {
duke@435 313
duke@435 314 // If only a single entry on the stack, use it
duke@435 315 uint cnt = worklist.size();
duke@435 316 if (cnt == 1) {
duke@435 317 Node *n = worklist[0];
duke@435 318 worklist.map(0,worklist.pop());
duke@435 319 return n;
duke@435 320 }
duke@435 321
duke@435 322 uint choice = 0; // Bigger is most important
duke@435 323 uint latency = 0; // Bigger is scheduled first
duke@435 324 uint score = 0; // Bigger is better
kvn@688 325 int idx = -1; // Index in worklist
duke@435 326
duke@435 327 for( uint i=0; i<cnt; i++ ) { // Inspect entire worklist
duke@435 328 // Order in worklist is used to break ties.
duke@435 329 // See caller for how this is used to delay scheduling
duke@435 330 // of induction variable increments to after the other
duke@435 331 // uses of the phi are scheduled.
duke@435 332 Node *n = worklist[i]; // Get Node on worklist
duke@435 333
duke@435 334 int iop = n->is_Mach() ? n->as_Mach()->ideal_Opcode() : 0;
duke@435 335 if( n->is_Proj() || // Projections always win
duke@435 336 n->Opcode()== Op_Con || // So does constant 'Top'
duke@435 337 iop == Op_CreateEx || // Create-exception must start block
duke@435 338 iop == Op_CheckCastPP
duke@435 339 ) {
duke@435 340 worklist.map(i,worklist.pop());
duke@435 341 return n;
duke@435 342 }
duke@435 343
duke@435 344 // Final call in a block must be adjacent to 'catch'
duke@435 345 Node *e = end();
duke@435 346 if( e->is_Catch() && e->in(0)->in(0) == n )
duke@435 347 continue;
duke@435 348
duke@435 349 // Memory op for an implicit null check has to be at the end of the block
duke@435 350 if( e->is_MachNullCheck() && e->in(1) == n )
duke@435 351 continue;
duke@435 352
duke@435 353 uint n_choice = 2;
duke@435 354
duke@435 355 // See if this instruction is consumed by a branch. If so, then (as the
duke@435 356 // branch is the last instruction in the basic block) force it to the
duke@435 357 // end of the basic block
duke@435 358 if ( must_clone[iop] ) {
duke@435 359 // See if any use is a branch
duke@435 360 bool found_machif = false;
duke@435 361
duke@435 362 for (DUIterator_Fast jmax, j = n->fast_outs(jmax); j < jmax; j++) {
duke@435 363 Node* use = n->fast_out(j);
duke@435 364
duke@435 365 // The use is a conditional branch, make them adjacent
duke@435 366 if (use->is_MachIf() && cfg->_bbs[use->_idx]==this ) {
duke@435 367 found_machif = true;
duke@435 368 break;
duke@435 369 }
duke@435 370
duke@435 371 // More than this instruction pending for successor to be ready,
duke@435 372 // don't choose this if other opportunities are ready
duke@435 373 if (ready_cnt[use->_idx] > 1)
duke@435 374 n_choice = 1;
duke@435 375 }
duke@435 376
duke@435 377 // loop terminated, prefer not to use this instruction
duke@435 378 if (found_machif)
duke@435 379 continue;
duke@435 380 }
duke@435 381
duke@435 382 // See if this has a predecessor that is "must_clone", i.e. sets the
duke@435 383 // condition code. If so, choose this first
duke@435 384 for (uint j = 0; j < n->req() ; j++) {
duke@435 385 Node *inn = n->in(j);
duke@435 386 if (inn) {
duke@435 387 if (inn->is_Mach() && must_clone[inn->as_Mach()->ideal_Opcode()] ) {
duke@435 388 n_choice = 3;
duke@435 389 break;
duke@435 390 }
duke@435 391 }
duke@435 392 }
duke@435 393
duke@435 394 // MachTemps should be scheduled last so they are near their uses
duke@435 395 if (n->is_MachTemp()) {
duke@435 396 n_choice = 1;
duke@435 397 }
duke@435 398
duke@435 399 uint n_latency = cfg->_node_latency.at_grow(n->_idx);
duke@435 400 uint n_score = n->req(); // Many inputs get high score to break ties
duke@435 401
duke@435 402 // Keep best latency found
duke@435 403 if( choice < n_choice ||
duke@435 404 ( choice == n_choice &&
duke@435 405 ( latency < n_latency ||
duke@435 406 ( latency == n_latency &&
duke@435 407 ( score < n_score ))))) {
duke@435 408 choice = n_choice;
duke@435 409 latency = n_latency;
duke@435 410 score = n_score;
duke@435 411 idx = i; // Also keep index in worklist
duke@435 412 }
duke@435 413 } // End of for all ready nodes in worklist
duke@435 414
kvn@688 415 assert(idx >= 0, "index should be set");
kvn@688 416 Node *n = worklist[(uint)idx]; // Get the winner
duke@435 417
kvn@688 418 worklist.map((uint)idx, worklist.pop()); // Compress worklist
duke@435 419 return n;
duke@435 420 }
duke@435 421
duke@435 422
duke@435 423 //------------------------------set_next_call----------------------------------
duke@435 424 void Block::set_next_call( Node *n, VectorSet &next_call, Block_Array &bbs ) {
duke@435 425 if( next_call.test_set(n->_idx) ) return;
duke@435 426 for( uint i=0; i<n->len(); i++ ) {
duke@435 427 Node *m = n->in(i);
duke@435 428 if( !m ) continue; // must see all nodes in block that precede call
duke@435 429 if( bbs[m->_idx] == this )
duke@435 430 set_next_call( m, next_call, bbs );
duke@435 431 }
duke@435 432 }
duke@435 433
duke@435 434 //------------------------------needed_for_next_call---------------------------
duke@435 435 // Set the flag 'next_call' for each Node that is needed for the next call to
duke@435 436 // be scheduled. This flag lets me bias scheduling so Nodes needed for the
duke@435 437 // next subroutine call get priority - basically it moves things NOT needed
duke@435 438 // for the next call till after the call. This prevents me from trying to
duke@435 439 // carry lots of stuff live across a call.
duke@435 440 void Block::needed_for_next_call(Node *this_call, VectorSet &next_call, Block_Array &bbs) {
duke@435 441 // Find the next control-defining Node in this block
duke@435 442 Node* call = NULL;
duke@435 443 for (DUIterator_Fast imax, i = this_call->fast_outs(imax); i < imax; i++) {
duke@435 444 Node* m = this_call->fast_out(i);
duke@435 445 if( bbs[m->_idx] == this && // Local-block user
duke@435 446 m != this_call && // Not self-start node
duke@435 447 m->is_Call() )
duke@435 448 call = m;
duke@435 449 break;
duke@435 450 }
duke@435 451 if (call == NULL) return; // No next call (e.g., block end is near)
duke@435 452 // Set next-call for all inputs to this call
duke@435 453 set_next_call(call, next_call, bbs);
duke@435 454 }
duke@435 455
duke@435 456 //------------------------------sched_call-------------------------------------
duke@435 457 uint Block::sched_call( Matcher &matcher, Block_Array &bbs, uint node_cnt, Node_List &worklist, int *ready_cnt, MachCallNode *mcall, VectorSet &next_call ) {
duke@435 458 RegMask regs;
duke@435 459
duke@435 460 // Schedule all the users of the call right now. All the users are
duke@435 461 // projection Nodes, so they must be scheduled next to the call.
duke@435 462 // Collect all the defined registers.
duke@435 463 for (DUIterator_Fast imax, i = mcall->fast_outs(imax); i < imax; i++) {
duke@435 464 Node* n = mcall->fast_out(i);
duke@435 465 assert( n->Opcode()==Op_MachProj, "" );
duke@435 466 --ready_cnt[n->_idx];
duke@435 467 assert( !ready_cnt[n->_idx], "" );
duke@435 468 // Schedule next to call
duke@435 469 _nodes.map(node_cnt++, n);
duke@435 470 // Collect defined registers
duke@435 471 regs.OR(n->out_RegMask());
duke@435 472 // Check for scheduling the next control-definer
duke@435 473 if( n->bottom_type() == Type::CONTROL )
duke@435 474 // Warm up next pile of heuristic bits
duke@435 475 needed_for_next_call(n, next_call, bbs);
duke@435 476
duke@435 477 // Children of projections are now all ready
duke@435 478 for (DUIterator_Fast jmax, j = n->fast_outs(jmax); j < jmax; j++) {
duke@435 479 Node* m = n->fast_out(j); // Get user
duke@435 480 if( bbs[m->_idx] != this ) continue;
duke@435 481 if( m->is_Phi() ) continue;
duke@435 482 if( !--ready_cnt[m->_idx] )
duke@435 483 worklist.push(m);
duke@435 484 }
duke@435 485
duke@435 486 }
duke@435 487
duke@435 488 // Act as if the call defines the Frame Pointer.
duke@435 489 // Certainly the FP is alive and well after the call.
duke@435 490 regs.Insert(matcher.c_frame_pointer());
duke@435 491
duke@435 492 // Set all registers killed and not already defined by the call.
duke@435 493 uint r_cnt = mcall->tf()->range()->cnt();
duke@435 494 int op = mcall->ideal_Opcode();
duke@435 495 MachProjNode *proj = new (matcher.C, 1) MachProjNode( mcall, r_cnt+1, RegMask::Empty, MachProjNode::fat_proj );
duke@435 496 bbs.map(proj->_idx,this);
duke@435 497 _nodes.insert(node_cnt++, proj);
duke@435 498
duke@435 499 // Select the right register save policy.
duke@435 500 const char * save_policy;
duke@435 501 switch (op) {
duke@435 502 case Op_CallRuntime:
duke@435 503 case Op_CallLeaf:
duke@435 504 case Op_CallLeafNoFP:
duke@435 505 // Calling C code so use C calling convention
duke@435 506 save_policy = matcher._c_reg_save_policy;
duke@435 507 break;
duke@435 508
duke@435 509 case Op_CallStaticJava:
duke@435 510 case Op_CallDynamicJava:
duke@435 511 // Calling Java code so use Java calling convention
duke@435 512 save_policy = matcher._register_save_policy;
duke@435 513 break;
duke@435 514
duke@435 515 default:
duke@435 516 ShouldNotReachHere();
duke@435 517 }
duke@435 518
duke@435 519 // When using CallRuntime mark SOE registers as killed by the call
duke@435 520 // so values that could show up in the RegisterMap aren't live in a
duke@435 521 // callee saved register since the register wouldn't know where to
duke@435 522 // find them. CallLeaf and CallLeafNoFP are ok because they can't
duke@435 523 // have debug info on them. Strictly speaking this only needs to be
duke@435 524 // done for oops since idealreg2debugmask takes care of debug info
duke@435 525 // references but there no way to handle oops differently than other
duke@435 526 // pointers as far as the kill mask goes.
duke@435 527 bool exclude_soe = op == Op_CallRuntime;
duke@435 528
duke@435 529 // Fill in the kill mask for the call
duke@435 530 for( OptoReg::Name r = OptoReg::Name(0); r < _last_Mach_Reg; r=OptoReg::add(r,1) ) {
duke@435 531 if( !regs.Member(r) ) { // Not already defined by the call
duke@435 532 // Save-on-call register?
duke@435 533 if ((save_policy[r] == 'C') ||
duke@435 534 (save_policy[r] == 'A') ||
duke@435 535 ((save_policy[r] == 'E') && exclude_soe)) {
duke@435 536 proj->_rout.Insert(r);
duke@435 537 }
duke@435 538 }
duke@435 539 }
duke@435 540
duke@435 541 return node_cnt;
duke@435 542 }
duke@435 543
duke@435 544
duke@435 545 //------------------------------schedule_local---------------------------------
duke@435 546 // Topological sort within a block. Someday become a real scheduler.
duke@435 547 bool Block::schedule_local(PhaseCFG *cfg, Matcher &matcher, int *ready_cnt, VectorSet &next_call) {
duke@435 548 // Already "sorted" are the block start Node (as the first entry), and
duke@435 549 // the block-ending Node and any trailing control projections. We leave
duke@435 550 // these alone. PhiNodes and ParmNodes are made to follow the block start
duke@435 551 // Node. Everything else gets topo-sorted.
duke@435 552
duke@435 553 #ifndef PRODUCT
duke@435 554 if (cfg->trace_opto_pipelining()) {
duke@435 555 tty->print_cr("# --- schedule_local B%d, before: ---", _pre_order);
duke@435 556 for (uint i = 0;i < _nodes.size();i++) {
duke@435 557 tty->print("# ");
duke@435 558 _nodes[i]->fast_dump();
duke@435 559 }
duke@435 560 tty->print_cr("#");
duke@435 561 }
duke@435 562 #endif
duke@435 563
duke@435 564 // RootNode is already sorted
duke@435 565 if( _nodes.size() == 1 ) return true;
duke@435 566
duke@435 567 // Move PhiNodes and ParmNodes from 1 to cnt up to the start
duke@435 568 uint node_cnt = end_idx();
duke@435 569 uint phi_cnt = 1;
duke@435 570 uint i;
duke@435 571 for( i = 1; i<node_cnt; i++ ) { // Scan for Phi
duke@435 572 Node *n = _nodes[i];
duke@435 573 if( n->is_Phi() || // Found a PhiNode or ParmNode
duke@435 574 (n->is_Proj() && n->in(0) == head()) ) {
duke@435 575 // Move guy at 'phi_cnt' to the end; makes a hole at phi_cnt
duke@435 576 _nodes.map(i,_nodes[phi_cnt]);
duke@435 577 _nodes.map(phi_cnt++,n); // swap Phi/Parm up front
duke@435 578 } else { // All others
duke@435 579 // Count block-local inputs to 'n'
duke@435 580 uint cnt = n->len(); // Input count
duke@435 581 uint local = 0;
duke@435 582 for( uint j=0; j<cnt; j++ ) {
duke@435 583 Node *m = n->in(j);
duke@435 584 if( m && cfg->_bbs[m->_idx] == this && !m->is_top() )
duke@435 585 local++; // One more block-local input
duke@435 586 }
duke@435 587 ready_cnt[n->_idx] = local; // Count em up
duke@435 588
duke@435 589 // A few node types require changing a required edge to a precedence edge
duke@435 590 // before allocation.
ysr@777 591 if( UseConcMarkSweepGC || UseG1GC ) {
duke@435 592 if( n->is_Mach() && n->as_Mach()->ideal_Opcode() == Op_StoreCM ) {
duke@435 593 // Note: Required edges with an index greater than oper_input_base
duke@435 594 // are not supported by the allocator.
duke@435 595 // Note2: Can only depend on unmatched edge being last,
duke@435 596 // can not depend on its absolute position.
duke@435 597 Node *oop_store = n->in(n->req() - 1);
duke@435 598 n->del_req(n->req() - 1);
duke@435 599 n->add_prec(oop_store);
duke@435 600 assert(cfg->_bbs[oop_store->_idx]->_dom_depth <= this->_dom_depth, "oop_store must dominate card-mark");
duke@435 601 }
duke@435 602 }
kvn@688 603 if( n->is_Mach() && n->as_Mach()->ideal_Opcode() == Op_MemBarAcquire &&
kvn@688 604 n->req() > TypeFunc::Parms ) {
kvn@688 605 // MemBarAcquire could be created without Precedent edge.
kvn@688 606 // del_req() replaces the specified edge with the last input edge
kvn@688 607 // and then removes the last edge. If the specified edge > number of
kvn@688 608 // edges the last edge will be moved outside of the input edges array
kvn@688 609 // and the edge will be lost. This is why this code should be
kvn@688 610 // executed only when Precedent (== TypeFunc::Parms) edge is present.
duke@435 611 Node *x = n->in(TypeFunc::Parms);
duke@435 612 n->del_req(TypeFunc::Parms);
duke@435 613 n->add_prec(x);
duke@435 614 }
duke@435 615 }
duke@435 616 }
duke@435 617 for(uint i2=i; i2<_nodes.size(); i2++ ) // Trailing guys get zapped count
duke@435 618 ready_cnt[_nodes[i2]->_idx] = 0;
duke@435 619
duke@435 620 // All the prescheduled guys do not hold back internal nodes
duke@435 621 uint i3;
duke@435 622 for(i3 = 0; i3<phi_cnt; i3++ ) { // For all pre-scheduled
duke@435 623 Node *n = _nodes[i3]; // Get pre-scheduled
duke@435 624 for (DUIterator_Fast jmax, j = n->fast_outs(jmax); j < jmax; j++) {
duke@435 625 Node* m = n->fast_out(j);
duke@435 626 if( cfg->_bbs[m->_idx] ==this ) // Local-block user
duke@435 627 ready_cnt[m->_idx]--; // Fix ready count
duke@435 628 }
duke@435 629 }
duke@435 630
duke@435 631 Node_List delay;
duke@435 632 // Make a worklist
duke@435 633 Node_List worklist;
duke@435 634 for(uint i4=i3; i4<node_cnt; i4++ ) { // Put ready guys on worklist
duke@435 635 Node *m = _nodes[i4];
duke@435 636 if( !ready_cnt[m->_idx] ) { // Zero ready count?
duke@435 637 if (m->is_iteratively_computed()) {
duke@435 638 // Push induction variable increments last to allow other uses
duke@435 639 // of the phi to be scheduled first. The select() method breaks
duke@435 640 // ties in scheduling by worklist order.
duke@435 641 delay.push(m);
never@560 642 } else if (m->is_Mach() && m->as_Mach()->ideal_Opcode() == Op_CreateEx) {
never@560 643 // Force the CreateEx to the top of the list so it's processed
never@560 644 // first and ends up at the start of the block.
never@560 645 worklist.insert(0, m);
duke@435 646 } else {
duke@435 647 worklist.push(m); // Then on to worklist!
duke@435 648 }
duke@435 649 }
duke@435 650 }
duke@435 651 while (delay.size()) {
duke@435 652 Node* d = delay.pop();
duke@435 653 worklist.push(d);
duke@435 654 }
duke@435 655
duke@435 656 // Warm up the 'next_call' heuristic bits
duke@435 657 needed_for_next_call(_nodes[0], next_call, cfg->_bbs);
duke@435 658
duke@435 659 #ifndef PRODUCT
duke@435 660 if (cfg->trace_opto_pipelining()) {
duke@435 661 for (uint j=0; j<_nodes.size(); j++) {
duke@435 662 Node *n = _nodes[j];
duke@435 663 int idx = n->_idx;
duke@435 664 tty->print("# ready cnt:%3d ", ready_cnt[idx]);
duke@435 665 tty->print("latency:%3d ", cfg->_node_latency.at_grow(idx));
duke@435 666 tty->print("%4d: %s\n", idx, n->Name());
duke@435 667 }
duke@435 668 }
duke@435 669 #endif
duke@435 670
duke@435 671 // Pull from worklist and schedule
duke@435 672 while( worklist.size() ) { // Worklist is not ready
duke@435 673
duke@435 674 #ifndef PRODUCT
duke@435 675 if (cfg->trace_opto_pipelining()) {
duke@435 676 tty->print("# ready list:");
duke@435 677 for( uint i=0; i<worklist.size(); i++ ) { // Inspect entire worklist
duke@435 678 Node *n = worklist[i]; // Get Node on worklist
duke@435 679 tty->print(" %d", n->_idx);
duke@435 680 }
duke@435 681 tty->cr();
duke@435 682 }
duke@435 683 #endif
duke@435 684
duke@435 685 // Select and pop a ready guy from worklist
duke@435 686 Node* n = select(cfg, worklist, ready_cnt, next_call, phi_cnt);
duke@435 687 _nodes.map(phi_cnt++,n); // Schedule him next
duke@435 688
duke@435 689 #ifndef PRODUCT
duke@435 690 if (cfg->trace_opto_pipelining()) {
duke@435 691 tty->print("# select %d: %s", n->_idx, n->Name());
duke@435 692 tty->print(", latency:%d", cfg->_node_latency.at_grow(n->_idx));
duke@435 693 n->dump();
duke@435 694 if (Verbose) {
duke@435 695 tty->print("# ready list:");
duke@435 696 for( uint i=0; i<worklist.size(); i++ ) { // Inspect entire worklist
duke@435 697 Node *n = worklist[i]; // Get Node on worklist
duke@435 698 tty->print(" %d", n->_idx);
duke@435 699 }
duke@435 700 tty->cr();
duke@435 701 }
duke@435 702 }
duke@435 703
duke@435 704 #endif
duke@435 705 if( n->is_MachCall() ) {
duke@435 706 MachCallNode *mcall = n->as_MachCall();
duke@435 707 phi_cnt = sched_call(matcher, cfg->_bbs, phi_cnt, worklist, ready_cnt, mcall, next_call);
duke@435 708 continue;
duke@435 709 }
duke@435 710 // Children are now all ready
duke@435 711 for (DUIterator_Fast i5max, i5 = n->fast_outs(i5max); i5 < i5max; i5++) {
duke@435 712 Node* m = n->fast_out(i5); // Get user
duke@435 713 if( cfg->_bbs[m->_idx] != this ) continue;
duke@435 714 if( m->is_Phi() ) continue;
duke@435 715 if( !--ready_cnt[m->_idx] )
duke@435 716 worklist.push(m);
duke@435 717 }
duke@435 718 }
duke@435 719
duke@435 720 if( phi_cnt != end_idx() ) {
duke@435 721 // did not schedule all. Retry, Bailout, or Die
duke@435 722 Compile* C = matcher.C;
duke@435 723 if (C->subsume_loads() == true && !C->failing()) {
duke@435 724 // Retry with subsume_loads == false
duke@435 725 // If this is the first failure, the sentinel string will "stick"
duke@435 726 // to the Compile object, and the C2Compiler will see it and retry.
duke@435 727 C->record_failure(C2Compiler::retry_no_subsuming_loads());
duke@435 728 }
duke@435 729 // assert( phi_cnt == end_idx(), "did not schedule all" );
duke@435 730 return false;
duke@435 731 }
duke@435 732
duke@435 733 #ifndef PRODUCT
duke@435 734 if (cfg->trace_opto_pipelining()) {
duke@435 735 tty->print_cr("#");
duke@435 736 tty->print_cr("# after schedule_local");
duke@435 737 for (uint i = 0;i < _nodes.size();i++) {
duke@435 738 tty->print("# ");
duke@435 739 _nodes[i]->fast_dump();
duke@435 740 }
duke@435 741 tty->cr();
duke@435 742 }
duke@435 743 #endif
duke@435 744
duke@435 745
duke@435 746 return true;
duke@435 747 }
duke@435 748
duke@435 749 //--------------------------catch_cleanup_fix_all_inputs-----------------------
duke@435 750 static void catch_cleanup_fix_all_inputs(Node *use, Node *old_def, Node *new_def) {
duke@435 751 for (uint l = 0; l < use->len(); l++) {
duke@435 752 if (use->in(l) == old_def) {
duke@435 753 if (l < use->req()) {
duke@435 754 use->set_req(l, new_def);
duke@435 755 } else {
duke@435 756 use->rm_prec(l);
duke@435 757 use->add_prec(new_def);
duke@435 758 l--;
duke@435 759 }
duke@435 760 }
duke@435 761 }
duke@435 762 }
duke@435 763
duke@435 764 //------------------------------catch_cleanup_find_cloned_def------------------
duke@435 765 static Node *catch_cleanup_find_cloned_def(Block *use_blk, Node *def, Block *def_blk, Block_Array &bbs, int n_clone_idx) {
duke@435 766 assert( use_blk != def_blk, "Inter-block cleanup only");
duke@435 767
duke@435 768 // The use is some block below the Catch. Find and return the clone of the def
duke@435 769 // that dominates the use. If there is no clone in a dominating block, then
duke@435 770 // create a phi for the def in a dominating block.
duke@435 771
duke@435 772 // Find which successor block dominates this use. The successor
duke@435 773 // blocks must all be single-entry (from the Catch only; I will have
duke@435 774 // split blocks to make this so), hence they all dominate.
duke@435 775 while( use_blk->_dom_depth > def_blk->_dom_depth+1 )
duke@435 776 use_blk = use_blk->_idom;
duke@435 777
duke@435 778 // Find the successor
duke@435 779 Node *fixup = NULL;
duke@435 780
duke@435 781 uint j;
duke@435 782 for( j = 0; j < def_blk->_num_succs; j++ )
duke@435 783 if( use_blk == def_blk->_succs[j] )
duke@435 784 break;
duke@435 785
duke@435 786 if( j == def_blk->_num_succs ) {
duke@435 787 // Block at same level in dom-tree is not a successor. It needs a
duke@435 788 // PhiNode, the PhiNode uses from the def and IT's uses need fixup.
duke@435 789 Node_Array inputs = new Node_List(Thread::current()->resource_area());
duke@435 790 for(uint k = 1; k < use_blk->num_preds(); k++) {
duke@435 791 inputs.map(k, catch_cleanup_find_cloned_def(bbs[use_blk->pred(k)->_idx], def, def_blk, bbs, n_clone_idx));
duke@435 792 }
duke@435 793
duke@435 794 // Check to see if the use_blk already has an identical phi inserted.
duke@435 795 // If it exists, it will be at the first position since all uses of a
duke@435 796 // def are processed together.
duke@435 797 Node *phi = use_blk->_nodes[1];
duke@435 798 if( phi->is_Phi() ) {
duke@435 799 fixup = phi;
duke@435 800 for (uint k = 1; k < use_blk->num_preds(); k++) {
duke@435 801 if (phi->in(k) != inputs[k]) {
duke@435 802 // Not a match
duke@435 803 fixup = NULL;
duke@435 804 break;
duke@435 805 }
duke@435 806 }
duke@435 807 }
duke@435 808
duke@435 809 // If an existing PhiNode was not found, make a new one.
duke@435 810 if (fixup == NULL) {
duke@435 811 Node *new_phi = PhiNode::make(use_blk->head(), def);
duke@435 812 use_blk->_nodes.insert(1, new_phi);
duke@435 813 bbs.map(new_phi->_idx, use_blk);
duke@435 814 for (uint k = 1; k < use_blk->num_preds(); k++) {
duke@435 815 new_phi->set_req(k, inputs[k]);
duke@435 816 }
duke@435 817 fixup = new_phi;
duke@435 818 }
duke@435 819
duke@435 820 } else {
duke@435 821 // Found the use just below the Catch. Make it use the clone.
duke@435 822 fixup = use_blk->_nodes[n_clone_idx];
duke@435 823 }
duke@435 824
duke@435 825 return fixup;
duke@435 826 }
duke@435 827
duke@435 828 //--------------------------catch_cleanup_intra_block--------------------------
duke@435 829 // Fix all input edges in use that reference "def". The use is in the same
duke@435 830 // block as the def and both have been cloned in each successor block.
duke@435 831 static void catch_cleanup_intra_block(Node *use, Node *def, Block *blk, int beg, int n_clone_idx) {
duke@435 832
duke@435 833 // Both the use and def have been cloned. For each successor block,
duke@435 834 // get the clone of the use, and make its input the clone of the def
duke@435 835 // found in that block.
duke@435 836
duke@435 837 uint use_idx = blk->find_node(use);
duke@435 838 uint offset_idx = use_idx - beg;
duke@435 839 for( uint k = 0; k < blk->_num_succs; k++ ) {
duke@435 840 // Get clone in each successor block
duke@435 841 Block *sb = blk->_succs[k];
duke@435 842 Node *clone = sb->_nodes[offset_idx+1];
duke@435 843 assert( clone->Opcode() == use->Opcode(), "" );
duke@435 844
duke@435 845 // Make use-clone reference the def-clone
duke@435 846 catch_cleanup_fix_all_inputs(clone, def, sb->_nodes[n_clone_idx]);
duke@435 847 }
duke@435 848 }
duke@435 849
duke@435 850 //------------------------------catch_cleanup_inter_block---------------------
duke@435 851 // Fix all input edges in use that reference "def". The use is in a different
duke@435 852 // block than the def.
duke@435 853 static void catch_cleanup_inter_block(Node *use, Block *use_blk, Node *def, Block *def_blk, Block_Array &bbs, int n_clone_idx) {
duke@435 854 if( !use_blk ) return; // Can happen if the use is a precedence edge
duke@435 855
duke@435 856 Node *new_def = catch_cleanup_find_cloned_def(use_blk, def, def_blk, bbs, n_clone_idx);
duke@435 857 catch_cleanup_fix_all_inputs(use, def, new_def);
duke@435 858 }
duke@435 859
duke@435 860 //------------------------------call_catch_cleanup-----------------------------
duke@435 861 // If we inserted any instructions between a Call and his CatchNode,
duke@435 862 // clone the instructions on all paths below the Catch.
duke@435 863 void Block::call_catch_cleanup(Block_Array &bbs) {
duke@435 864
duke@435 865 // End of region to clone
duke@435 866 uint end = end_idx();
duke@435 867 if( !_nodes[end]->is_Catch() ) return;
duke@435 868 // Start of region to clone
duke@435 869 uint beg = end;
duke@435 870 while( _nodes[beg-1]->Opcode() != Op_MachProj ||
duke@435 871 !_nodes[beg-1]->in(0)->is_Call() ) {
duke@435 872 beg--;
duke@435 873 assert(beg > 0,"Catch cleanup walking beyond block boundary");
duke@435 874 }
duke@435 875 // Range of inserted instructions is [beg, end)
duke@435 876 if( beg == end ) return;
duke@435 877
duke@435 878 // Clone along all Catch output paths. Clone area between the 'beg' and
duke@435 879 // 'end' indices.
duke@435 880 for( uint i = 0; i < _num_succs; i++ ) {
duke@435 881 Block *sb = _succs[i];
duke@435 882 // Clone the entire area; ignoring the edge fixup for now.
duke@435 883 for( uint j = end; j > beg; j-- ) {
duke@435 884 Node *clone = _nodes[j-1]->clone();
duke@435 885 sb->_nodes.insert( 1, clone );
duke@435 886 bbs.map(clone->_idx,sb);
duke@435 887 }
duke@435 888 }
duke@435 889
duke@435 890
duke@435 891 // Fixup edges. Check the def-use info per cloned Node
duke@435 892 for(uint i2 = beg; i2 < end; i2++ ) {
duke@435 893 uint n_clone_idx = i2-beg+1; // Index of clone of n in each successor block
duke@435 894 Node *n = _nodes[i2]; // Node that got cloned
duke@435 895 // Need DU safe iterator because of edge manipulation in calls.
duke@435 896 Unique_Node_List *out = new Unique_Node_List(Thread::current()->resource_area());
duke@435 897 for (DUIterator_Fast j1max, j1 = n->fast_outs(j1max); j1 < j1max; j1++) {
duke@435 898 out->push(n->fast_out(j1));
duke@435 899 }
duke@435 900 uint max = out->size();
duke@435 901 for (uint j = 0; j < max; j++) {// For all users
duke@435 902 Node *use = out->pop();
duke@435 903 Block *buse = bbs[use->_idx];
duke@435 904 if( use->is_Phi() ) {
duke@435 905 for( uint k = 1; k < use->req(); k++ )
duke@435 906 if( use->in(k) == n ) {
duke@435 907 Node *fixup = catch_cleanup_find_cloned_def(bbs[buse->pred(k)->_idx], n, this, bbs, n_clone_idx);
duke@435 908 use->set_req(k, fixup);
duke@435 909 }
duke@435 910 } else {
duke@435 911 if (this == buse) {
duke@435 912 catch_cleanup_intra_block(use, n, this, beg, n_clone_idx);
duke@435 913 } else {
duke@435 914 catch_cleanup_inter_block(use, buse, n, this, bbs, n_clone_idx);
duke@435 915 }
duke@435 916 }
duke@435 917 } // End for all users
duke@435 918
duke@435 919 } // End of for all Nodes in cloned area
duke@435 920
duke@435 921 // Remove the now-dead cloned ops
duke@435 922 for(uint i3 = beg; i3 < end; i3++ ) {
duke@435 923 _nodes[beg]->disconnect_inputs(NULL);
duke@435 924 _nodes.remove(beg);
duke@435 925 }
duke@435 926
duke@435 927 // If the successor blocks have a CreateEx node, move it back to the top
duke@435 928 for(uint i4 = 0; i4 < _num_succs; i4++ ) {
duke@435 929 Block *sb = _succs[i4];
duke@435 930 uint new_cnt = end - beg;
duke@435 931 // Remove any newly created, but dead, nodes.
duke@435 932 for( uint j = new_cnt; j > 0; j-- ) {
duke@435 933 Node *n = sb->_nodes[j];
duke@435 934 if (n->outcnt() == 0 &&
duke@435 935 (!n->is_Proj() || n->as_Proj()->in(0)->outcnt() == 1) ){
duke@435 936 n->disconnect_inputs(NULL);
duke@435 937 sb->_nodes.remove(j);
duke@435 938 new_cnt--;
duke@435 939 }
duke@435 940 }
duke@435 941 // If any newly created nodes remain, move the CreateEx node to the top
duke@435 942 if (new_cnt > 0) {
duke@435 943 Node *cex = sb->_nodes[1+new_cnt];
duke@435 944 if( cex->is_Mach() && cex->as_Mach()->ideal_Opcode() == Op_CreateEx ) {
duke@435 945 sb->_nodes.remove(1+new_cnt);
duke@435 946 sb->_nodes.insert(1,cex);
duke@435 947 }
duke@435 948 }
duke@435 949 }
duke@435 950 }

mercurial